From: Paul Walmsley <pjw@kernel.org>
To: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-arch@vger.kernel.org, Peter Xu <peterx@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
Alexandre Ghiti <alexghiti@rivosinc.com>
Subject: Re: [PATCH RESEND v2] asm-generic: Remove pud_user() from pgtable-nopmd.h
Date: Wed, 14 Jan 2026 18:48:13 -0700 (MST) [thread overview]
Message-ID: <d7d3d58e-8b48-ddca-1afd-d2181b2872c3@kernel.org> (raw)
In-Reply-To: <61ef32ebc3ea2e926de2bebecf3b5c3a10989fca.1767720453.git.chleroy@kernel.org>
Hi Arnd,
On Tue, 6 Jan 2026, Christophe Leroy (CS GROUP) wrote:
> Commit 2c8a81dc0cc5 ("riscv/mm: fix two page table check related
> issues") added pud_user() in include/asm-generic/pgtable-nopmd.h
>
> But pud_user() only exists on ARM64 and RISCV and is not expected
> by any part of MM.
>
> Add the missing definition in arch/riscv/include/asm/pgtable-32.h
> and remove it from asm-generic/pgtable-nopmd.h
>
> A stub pud_user() is also required for ARM64 after
> commit ed928a3402d8 ("arm64/mm: fix page table check compile
> error for CONFIG_PGTABLE_LEVELS=2")
>
> Signed-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Reviewed-by: Oscar Salvador <osalvador@suse.de>
> Acked-by: Alexandre Ghiti <alexghiti@rivosinc.com> # riscv
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
> Who should take this patch ? I expected it to be merged by Arnd as asm-generic maintainer but this is the second time I resend.
>
> Should the patch go via riscv tree instead as the undue pud_user() was initialy introduced by riscv ?
>
> v2: Change ARM64 pud_user macro to pud_user(pud)
This one looks like it should go upstream through you?
If you'd prefer arch/riscv to pick it up, let us know.
thanks,
- Paul
next prev parent reply other threads:[~2026-01-15 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 17:34 [PATCH RESEND v2] asm-generic: Remove pud_user() from pgtable-nopmd.h Christophe Leroy (CS GROUP)
2026-01-15 1:48 ` Paul Walmsley [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-11-05 11:08 Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7d3d58e-8b48-ddca-1afd-d2181b2872c3@kernel.org \
--to=pjw@kernel.org \
--cc=alex@ghiti.fr \
--cc=alexghiti@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=chleroy@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=osalvador@suse.de \
--cc=palmer@dabbelt.com \
--cc=peterx@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox