Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mukesh R <mrathor@linux.microsoft.com>
To: Kameron Carr <kameroncarr@linux.microsoft.com>
Cc: Michael Kelley <mhklinux@outlook.com>,
	"decui@microsoft.com" <decui@microsoft.com>,
	"haiyangz@microsoft.com" <haiyangz@microsoft.com>,
	"wei.liu@kernel.org" <wei.liu@kernel.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"sudeep.holla@kernel.org" <sudeep.holla@kernel.org>,
	"thuth@redhat.com" <thuth@redhat.com>,
	"will@kernel.org" <will@kernel.org>
Subject: Re: [PATCH v6 4/6] Drivers: hv: Mark shared memory as decrypted for CCA Realms
Date: Tue, 17 Nov 2026 11:57:08 -0800	[thread overview]
Message-ID: <d7d4ba44-5c7f-9526-37dd-76744c277069@linux.microsoft.com> (raw)
In-Reply-To: <5fddb57c-8805-4fbd-9e27-1c8654f29436@linux.microsoft.com>

On 11/16/26 11:53, Kameron Carr wrote:
> On 11/13/2026 6:59 PM, Mukesh R wrote:
>> On 11/12/26 16:46, Mukesh R wrote:
>>> On 11/12/26 09:49, Kameron Carr wrote:
>>>> On 11/11/2026 6:43 PM, Mukesh R wrote:
>>>>> On 11/11/26 10:01, Michael Kelley wrote:
>>>>>> From: Kameron Carr <kameroncarr@linux.microsoft.com> Sent: Friday, October 30, 2026 5:14 PM
>>>>>>>
>>>>>>> In hv_common_cpu_init(), the per-CPU hypercall input/output pages need
>>>>>>> to be marked as decrypted (shared) for confidential VM isolation types.
>>>>>>> This is already done for SNP and TDX isolation; extend the same handling
>>>>>>> to Arm CCA Realm guests so that the host hypervisor can access the
>>>>>>> shared hypercall buffers.
>>>>>>>
>>>>>>> is_realm_world() is declared in include/linux/arm-rsi-cmds.h which only
>>>>>>> builds on arm64 (it includes <asm/memory.h>), so using it directly in
>>>>>>> the arch-neutral drivers/hv/hv_common.c would break the x86 build.
>>>>>>> Introduce a Hyper-V-specific helper following the established
>>>>>>> hv_isolation_type_snp() / hv_isolation_type_tdx() pattern.
>>>>>>>
>>>>>>> On architectures other than arm64 the weak default keeps the existing
>>>>>>> behaviour.
>>>>>>>
>>>>>>> Reviewed-by: Michael Kelley <mhklinux@outlook.com>
>>>>>>> Signed-off-by: Kameron Carr <kameroncarr@linux.microsoft.com>
>>>>>>> ---
>>>>>>>     arch/arm64/hyperv/mshyperv.c   |  5 +++++
>>>>>>>     drivers/hv/hv_common.c         | 17 +++++++++++++----
>>>>>>>     include/asm-generic/mshyperv.h |  1 +
>>>>>>>     3 files changed, 19 insertions(+), 4 deletions(-)
>>>>>>>
>>>>>>> diff --git a/arch/arm64/hyperv/mshyperv.c b/arch/arm64/hyperv/mshyperv.c
>>>>>>> index 46ab2da..da6c3aa0 100644
>>>>>>> --- a/arch/arm64/hyperv/mshyperv.c
>>>>>>> +++ b/arch/arm64/hyperv/mshyperv.c
>>>>>>> @@ -182,3 +182,8 @@ bool hv_is_hyperv_initialized(void)
>>>>>>>         return hyperv_initialized;
>>>>>>>     }
>>>>>>>     EXPORT_SYMBOL_GPL(hv_is_hyperv_initialized);
>>>>>>> +
>>>>>>> +bool hv_isolation_type_cca(void)
>>>>>>> +{
>>>>>>> +    return is_realm_world();
>>>>>>> +}
>>>>>>> diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
>>>>>>> index 31256cb..a60c92c 100644
>>>>>>> --- a/drivers/hv/hv_common.c
>>>>>>> +++ b/drivers/hv/hv_common.c
>>>>>>> @@ -476,6 +476,7 @@ int hv_common_cpu_init(unsigned int cpu)
>>>>>>>         u64 msr_vp_index;
>>>>>>>         gfp_t flags;
>>>>>>>         const int pgcount = hv_output_page_exists() ? 2 : 1;
>>>>>>> +    const size_t alloc_size = ALIGN((size_t)pgcount * HV_HYP_PAGE_SIZE, PAGE_SIZE);
>>>>>>>         void *mem;
>>>>>>>         int ret = 0;
>>>>>>>
>>>>>>> @@ -489,7 +490,7 @@ int hv_common_cpu_init(unsigned int cpu)
>>>>>>>          * online and then taken offline
>>>>>>>          */
>>>>>>>         if (!*inputarg) {
>>>>>>> -        mem = kmalloc_array(pgcount, HV_HYP_PAGE_SIZE, flags);
>>>>>>> +        mem = kmalloc(alloc_size, flags);
>>>>>>>             if (!mem)
>>>>>>>                 return -ENOMEM;
>>>>>>>
>>>>>>> @@ -499,14 +500,16 @@ int hv_common_cpu_init(unsigned int cpu)
>>>>>>>             }
>>>>>>>
>>>>>>>             if (!ms_hyperv.paravisor_present &&
>>>>>>> -            (hv_isolation_type_snp() || hv_isolation_type_tdx())) {
>>>>>>> -            ret = set_memory_decrypted((unsigned long)mem, pgcount);
>>>>>>> +            (hv_isolation_type_snp() || hv_isolation_type_tdx() ||
>>>>>>> +             hv_isolation_type_cca())) {
>>>>>>
>>>>>> Could this big "if" statement use "hv_is_isolation_supported()" instead
>>>>>> of explicitly testing for each CoCo VM type? I ask partly because
>>>>>> Mukesh Rathor has just submitted a patch [1] that introduces a new
>>>>>> function that does something almost exactly the same as
>>>>>> hv_is_isolation_supported() and uses it here.
>>>>>
>>>>>>> +            (hv_isolation_type_snp() || hv_isolation_type_tdx() ||
>>>>>>> +             hv_isolation_type_cca())) {
>>>>>
>>>>> With my change, this will become:
>>>>>
>>>>>           (hv_isolation_hw_cvm() || hv_isolation_type_cca())) {
>>>>
>>>> Any reason you wouldn't change hv_isolation_hw_cvm() to
>>>>
>>>>     return hv_isolation_type_snp() || hv_isolation_type_tdx() ||
>>>>       hv_isolation_type_cca()
>>>>
>>>> That would seem more logical to me.
>>>>
>>>
>>> We could, I just don't know if on cca, the repeat hypercall has same
>>> behavior. I was leaving that for the arm team. Anyways, I sent question
>>> to the hyp team, if they say yes, i can update my patch to include that.
>>>
>>> Thanks,
>>> -Mukesh
>>
>>
>> Confirming, arm has same behavior and needs the fix also. So, we can def
>> expand the check to include _cca.
>>
>> I just sent V1, renaming hv_isolation_hw_cvm() to hv_isolation_type_hw().
>> If your patch goes after mine, you just need to add to your 0004*:
>>
>> diff --git a/arch/arm64/hyperv/mshyperv.c b/arch/arm64/hyperv/mshyperv.c
>> index 4fdc26ade1d7..67a16b4d2235 100644
>> --- a/arch/arm64/hyperv/mshyperv.c
>> +++ b/arch/arm64/hyperv/mshyperv.c
>> @@ -134,3 +134,8 @@ bool hv_is_hyperv_initialized(void)
>>          return hyperv_initialized;
>>   }
>>   EXPORT_SYMBOL_GPL(hv_is_hyperv_initialized);
>> +
>> +bool hv_isolation_type_hw(void)
>> +{
>> +       return is_realm_world();
>> +}
>>
>>
>> OR, you could pick mine 0001-* and make it part of your series, and I
>> can drop it from mine and make it dependent on yours. But mine is small
>> enough that it has higher chances of going in first.....
>>
> 
> This patch set has already been applied to hyperv-next, so maybe you can
> rebase off that.
> 

Ok, I'll rebase my patches from hyperv-fixes to hyperv-next, and
resubmit.

Thanks,
-Mukesh



  reply	other threads:[~2026-11-17 19:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-31  0:14 [PATCH v6 0/6] arm64: hyperv: Add Realm support for Hyper-V Kameron Carr
2026-10-31  0:14 ` [PATCH v6 1/6] arm64: rsi: Add RSI host call structure and helper function Kameron Carr
2026-10-31  4:51   ` Dexuan Cui
2026-11-02 12:10     ` Catalin Marinas
2026-10-31  0:14 ` [PATCH v6 2/6] arm64: hyperv: Detect Hyper-V via RSI host call in CCA Realms Kameron Carr
2026-11-02 12:12   ` Catalin Marinas
2026-11-02 19:27     ` Kameron Carr
2026-11-03 14:01       ` Catalin Marinas
2026-10-31  0:14 ` [PATCH v6 3/6] arm64: hyperv: Add per-CPU RSI host call infrastructure for " Kameron Carr
2026-11-11 18:00   ` Michael Kelley
2026-11-11 19:40     ` Kameron Carr
2026-10-31  0:14 ` [PATCH v6 4/6] Drivers: hv: Mark shared memory as decrypted " Kameron Carr
2026-11-11 18:01   ` Michael Kelley
2026-11-11 22:36     ` Kameron Carr
2026-11-12  2:39       ` Michael Kelley
2026-11-12  2:43     ` Mukesh R
2026-11-12 17:49       ` Kameron Carr
2026-11-13  0:46         ` Mukesh R
2026-11-14  2:59           ` Mukesh R
2026-11-16 19:53             ` Kameron Carr
2026-11-17 19:57               ` Mukesh R [this message]
2026-10-31  0:14 ` [PATCH v6 5/6] arm64: hyperv: Route hypercalls through RSI host call in " Kameron Carr
2026-10-31  0:14 ` [PATCH v6 6/6] arm64: hyperv: Implement hv_is_isolation_supported() for " Kameron Carr
2026-11-11 18:01   ` Michael Kelley
2026-11-11 19:33     ` Kameron Carr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7d4ba44-5c7f-9526-37dd-76744c277069@linux.microsoft.com \
    --to=mrathor@linux.microsoft.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kameroncarr@linux.microsoft.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhklinux@outlook.com \
    --cc=sudeep.holla@kernel.org \
    --cc=thuth@redhat.com \
    --cc=wei.liu@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox