From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5665EB64D7 for ; Fri, 23 Jun 2023 13:30:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DLoRULmxyP7nSePsIA0ZhYzXVzce8ZVD3JM8+DYH9Fo=; b=jo90M1fLJqZuLt xurpoxFjieH1M1NjmCBp1iF/TU4ApPoF4x92nOx+80P3hx3q99v3z7UYlJo/v1IboyHPNfmMG5IAl Zt8b6nocuGA5VazYZvzbHnAF2e4J+nhF66jDOyFw/eTKoOFE/Anz74F42YQFtaObbCSe1hyRyfqIM doSmy6pu+r6WX8V/iDacvd3RAP+1jIZbxN8ldUV9hZuYBR0+SfFYUri2VmRhJYLIaH7VBN42oPrET QP2EULrGsC/B6PF7NTnMVJSrHPWRIhUHquSh3bn6as2+w3rM1OMHk9CatJJ26WLxW1E3nti2qKLm0 c2ucC2kIwBtI1Ml1oAmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCgqz-003eDW-1w; Fri, 23 Jun 2023 13:29:33 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCgqx-003eCN-0F; Fri, 23 Jun 2023 13:29:32 +0000 Received: from notapiano (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 38A836607135; Fri, 23 Jun 2023 14:29:25 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1687526966; bh=f25KcXi6OI+LncvpOIXHkVRpkniDYC2VeUuLYp3b3hU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GLoJELngos//bZbPLg0c9rK5fE1moLGbuBfaJuukcPv1OZHhXtJXzQnO0p0SuSOSF YflGSif3EVcWaJZPQ/Ss7JdCihtzPiVnNyq+OC26k7ddMYw7tZ/MUbSoetTk0UXqhi z+e892o09ky/Aokfifx2YsCjZetTknHB+KY/NQHuba0upMz6yD0oqxMFENcShbyNNj UchGt5ZzYuaboFhGI7oKokhZLWtUqkYXbOoQn6aUl3MWWSBvTi2iTX7LAkNT35qi7e Dv6a5IT46JGNvrCfhXDp5b0Hk/i5kngBTBrhUXKw8vNCSoKG7FWEah0ylUhmSVxIhc CWsdwwA/U3w5w== Date: Fri, 23 Jun 2023 09:29:21 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: AngeloGioacchino Del Regno Cc: chunkuang.hu@kernel.org, p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, matthias.bgg@gmail.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, wenst@chromium.org Subject: Re: [PATCH v3 9/9] drm/mediatek: dp: Add support for embedded DisplayPort aux-bus Message-ID: References: <20230404104800.301150-1-angelogioacchino.delregno@collabora.com> <20230404104800.301150-10-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230404104800.301150-10-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230623_062931_306473_AA9765A8 X-CRM114-Status: GOOD ( 25.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 04, 2023 at 12:48:00PM +0200, AngeloGioacchino Del Regno wrote: > For the eDP case we can support using aux-bus on MediaTek DP: this > gives us the possibility to declare our panel as generic "panel-edp" > which will automatically configure the timings and available modes > via the EDID that we read from it. > = > To do this, move the panel parsing at the end of the probe function > so that the hardware is initialized beforehand and also initialize > the DPTX AUX block and power both on as, when we populate the > aux-bus, the panel driver will trigger an EDID read to perform > panel detection. > = > Last but not least, since now the AUX transfers can happen in the > separated aux-bus, it was necessary to add an exclusion for the > cable_plugged_in check in `mtk_dp_aux_transfer()` and the easiest > way to do this is to simply ignore checking that when the bridge > type is eDP. > = > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/gpu/drm/mediatek/mtk_dp.c | 61 ++++++++++++++++++++++++++----- > 1 file changed, 51 insertions(+), 10 deletions(-) > = > diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek= /mtk_dp.c > index a67143c22024..8109f5b4392b 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dp.c > +++ b/drivers/gpu/drm/mediatek/mtk_dp.c [..] > @@ -2571,6 +2585,33 @@ static int mtk_dp_probe(struct platform_device *pd= ev) > mtk_dp->need_debounce =3D true; > timer_setup(&mtk_dp->debounce_timer, mtk_dp_debounce_timer, 0); > = > + if (mtk_dp->bridge.type =3D=3D DRM_MODE_CONNECTOR_eDP) { > + /* Initialize, reset and poweron the DPTX AUX block */ > + mtk_dp_initialize_aux_settings(mtk_dp); > + mtk_dp_power_enable(mtk_dp); > + > + /* Power on the panel to allow EDID read from aux-bus */ > + mtk_dp_aux_panel_poweron(mtk_dp, true); > + > + ret =3D devm_of_dp_aux_populate_bus(&mtk_dp->aux, NULL); This patch causes .../bin/aarch64-none-linux-gnu-ld: Unexpected GOT/PLT entries detected! .../bin/aarch64-none-linux-gnu-ld: Unexpected run-time procedure linkages d= etected! .../bin/aarch64-none-linux-gnu-ld: drivers/gpu/drm/mediatek/mtk_dp.o: in fu= nction `mtk_dp_probe': .../drivers/gpu/drm/mediatek/mtk_dp.c:2595: undefined reference to `devm_of= _dp_aux_populate_bus' You need diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kc= onfig index b451dee64d34..76cab28e010c 100644 --- a/drivers/gpu/drm/mediatek/Kconfig +++ b/drivers/gpu/drm/mediatek/Kconfig @@ -26,6 +26,7 @@ config DRM_MEDIATEK_DP select PHY_MTK_DP select DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_HELPER + select DRM_DP_AUX_BUS help DRM/KMS Display Port driver for MediaTek SoCs. Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel