From: Bean Huo <huobean@gmail.com>
To: Po-Wen Kao <powen.kao@mediatek.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: wsd_upstream@mediatek.com, peter.wang@mediatek.com,
stanley.chu@mediatek.com, alice.chao@mediatek.com,
naomi.chu@mediatek.com, chun-hung.wu@mediatek.com,
cc.chou@mediatek.com, eddie.huang@mediatek.com,
mason.zhang@mediatek.com, chaotian.jing@mediatek.com,
jiajie.hao@mediatek.com
Subject: Re: [PATCH v3 3/6] scsi: ufs: core: Fix mcq nr_hw_queues
Date: Sun, 26 Feb 2023 17:10:32 +0100 [thread overview]
Message-ID: <d7dbf7e2-5cfe-d728-4ca6-51ab8a6ac60c@gmail.com> (raw)
In-Reply-To: <20230223152757.13606-4-powen.kao@mediatek.com>
On 23.02.23 4:27 PM, Po-Wen Kao wrote:
> Since MAXQ is 0 based value, add one to obtain number of hardware queue.
MAXQ in Multi-Circular Queue Capability Register is 0 based, hence ..
>
> Signed-off-by: Po-Wen Kao<powen.kao@mediatek.com>
> ---
> drivers/ufs/core/ufs-mcq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index a39746b2a8be..f9af658b4ba2 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -150,7 +150,8 @@ static int ufshcd_mcq_config_nr_queues(struct ufs_hba *hba)
> u32 hba_maxq, rem, tot_queues;
> struct Scsi_Host *host = hba->host;
>
> - hba_maxq = FIELD_GET(MAX_QUEUE_SUP, hba->mcq_capabilities);
> + /* maxq is 0 based value */
> + hba_maxq = FIELD_GET(MAX_QUEUE_SUP, hba->mcq_capabilities) + 1 ;
Reviewed-by: Bean Huo <beanhuo@micron.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-26 16:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 15:27 [PATCH v3 0/6] Several UFS MCQ Code Changes Po-Wen Kao
2023-02-23 15:27 ` [PATCH v3 1/6] scsi: ufs: core: Fix mcq tag calcualtion Po-Wen Kao
2023-02-23 15:27 ` [PATCH v3 2/6] scsi: ufs: core: Rename symbols Po-Wen Kao
2023-03-01 7:12 ` Manivannan Sadhasivam
2023-02-23 15:27 ` [PATCH v3 3/6] scsi: ufs: core: Fix mcq nr_hw_queues Po-Wen Kao
2023-02-26 16:10 ` Bean Huo [this message]
2023-03-01 7:13 ` Manivannan Sadhasivam
2023-02-23 15:27 ` [PATCH v3 4/6] scsi: ufs: core: Remove redundant check Po-Wen Kao
2023-02-26 16:23 ` Bean Huo
2023-03-01 3:38 ` Powen Kao (高伯文)
2023-02-23 15:27 ` [PATCH v3 5/6] scsi: ufs: core: Export symbols for MTK driver module Po-Wen Kao
2023-02-23 15:27 ` [PATCH v3 6/6] scsi: ufs: ufs-mediatek: Add MCQ support for MTK platform Po-Wen Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7dbf7e2-5cfe-d728-4ca6-51ab8a6ac60c@gmail.com \
--to=huobean@gmail.com \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mason.zhang@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).