From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D32E1C6FA82 for ; Tue, 13 Sep 2022 09:51:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: CC:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u2rvSuYkWa/8sctlww3q3D4e1K5a7x0U9EJ9qF3alRg=; b=s9UnQ2OhaV9hzc C0o2tOR2JiRVSuqneo7qX+qtkHGT4kafA9iba9ZOuxTRFyRLxYO5PvN6Mdxhxat4ZZtjQ/PbC2tBP /e+hakn2miFrFHIxcZ2bS2m7CsF+8zGnSjWfmdTzqieLfy2ZRzp0/JelhJG6BpXnn4JJTsqkIsS2y WchBKuAIiudAnDwyv/HOx2GsjXKmMMZejfkPi9R6km0khOFQ1H11tBZkOCa5fKV8xXDLD+Vzw3c0h h3pB1AD1ZVeD0Mb0eSLgnyszZkX9ZxObhAwB3OiD2S2cM5XTrdlOmjitdxqQn7N6LBPzSLXDLsZF8 EpUdY2l5N7Vw4uRGFS5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY2YB-005do2-AW; Tue, 13 Sep 2022 09:49:53 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY2U8-005RqV-Eo; Tue, 13 Sep 2022 09:45:42 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 28D9jUwI040710; Tue, 13 Sep 2022 04:45:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1663062330; bh=AU++iYqWva29bjfI9XPz8HMqFvoP8KDo2s0Fll1WpH4=; h=Date:CC:Subject:To:References:From:In-Reply-To; b=GOna1rC0nCv/Dng5o3Q8QaywDzCvKovFlIV4Oq1JEi/JQhJJFnknFCrfF115lC2cF uwnFcbaImkbxaQ3Qjglgb4JzD/NAg1+v6x/Z1v1zPiwjwEOpQ1X6cNShvD9aJq3TE6 noTtnQyYQI1sr8k9S9pf2kXBsIeqP11fuLRbmyb0= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 28D9jUhE016051 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 13 Sep 2022 04:45:30 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Tue, 13 Sep 2022 04:45:30 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Tue, 13 Sep 2022 04:45:30 -0500 Received: from [10.24.69.241] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 28D9jQcd076907; Tue, 13 Sep 2022 04:45:26 -0500 Message-ID: Date: Tue, 13 Sep 2022 15:15:25 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 CC: , , , , , , , , , , , Subject: Re: [PATCH v5 2/3] dt-bindings: phy: ti: phy-gmii-sel: Add bindings for J7200 Content-Language: en-US To: Krzysztof Kozlowski , References: <20220912085650.83263-1-s-vadapalli@ti.com> <20220912085650.83263-3-s-vadapalli@ti.com> <7a673b7c-9e04-2a23-98b9-243696597bba@linaro.org> From: Siddharth Vadapalli In-Reply-To: <7a673b7c-9e04-2a23-98b9-243696597bba@linaro.org> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220913_024540_709745_B3D1A4B0 X-CRM114-Status: GOOD ( 15.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Krzysztof, On 13/09/22 14:57, Krzysztof Kozlowski wrote: > On 12/09/2022 10:56, Siddharth Vadapalli wrote: > >> required: >> - compatible >> - reg >> diff --git a/Documentation/devicetree/bindings/phy/ti,phy-gmii-sel.yaml b/Documentation/devicetree/bindings/phy/ti,phy-gmii-sel.yaml >> index 016a37db1ea1..da7cac537e15 100644 >> --- a/Documentation/devicetree/bindings/phy/ti,phy-gmii-sel.yaml >> +++ b/Documentation/devicetree/bindings/phy/ti,phy-gmii-sel.yaml >> @@ -53,12 +53,25 @@ properties: >> - ti,am43xx-phy-gmii-sel >> - ti,dm814-phy-gmii-sel >> - ti,am654-phy-gmii-sel >> + - ti,j7200-cpsw5g-phy-gmii-sel >> >> reg: >> maxItems: 1 >> >> '#phy-cells': true >> >> + ti,qsgmii-main-ports: >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + description: | >> + Required only for QSGMII mode. Array to select the port for > > Not really an array... > >> + QSGMII main mode. Rest of the ports are selected as QSGMII_SUB >> + ports automatically. Any one of the 4 CPSW5G ports can act as the >> + main port with the rest of them being the QSGMII_SUB ports. >> + maxItems: 1 > > > You say it is an array, but you have here just one item, so it is just > uint32. Do you expect it to grow? If so, when? Why it cannot grow now? Thank you for reviewing the patch. I have defined it as an array because I plan to reuse this property for other TI devices like J721e which supports up to two QSGMII main ports. J7200 on the other hand can have at most one QSGMII main port, which is why I have restricted the array size to one element as of this series. In the upcoming patches that I will be posting for J721e, I will be changing the maxItems to 2 for J721e's compatible while it will continue to remain 1 for J7200's compatible. This is the reason for defining the property as an array. Regards, Siddharth. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel