From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26DE0C4332F for ; Sat, 15 Oct 2022 22:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tG79W8fyN4pP2Etj9BV6rWxjI/S3S196kchJS3JeWhM=; b=pnKJeOn27fmgAT cNY5Or+1DhwijqzA4sGPQwIeZGeMWwFR1BtBCEDpJC5bXOdfqSWufIpfv4BzQpeS1Vl0Us9N7imy2 FPHIh/VSRWl67QXnVchWkiernX+0FW6UeEZO6DrZBmaNr3KJW2k+79NxXoz8c3ViHM5AhG4kTDqGE tSbXIFHNZhJGjpau68TFaQgVBMWOLhHk3XWRbbhQjQrkcVYmhjTC8biTCEeWjjAkNTTR+dtBQTyHh tuE7WfC/zhztI8PjQrAFMnRftiV8J3g/ZxumA9g7BSac7f2a+D/DSQHaHe/F6EtcY7ey8S/m6Roqf G5nj2UhibasG4SlDdS4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojpE7-0008Q6-2r; Sat, 15 Oct 2022 22:01:51 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojpE3-0008PF-AG for linux-arm-kernel@lists.infradead.org; Sat, 15 Oct 2022 22:01:49 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 3170184D45; Sun, 16 Oct 2022 00:01:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1665871305; bh=5RizyXD0uBD/KJYAOrgaaQ82URsfpCiastxnkITJOzc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=q8/gE9DdVNOn7S1q84SZIwimPE7gVl5387Gmc8rz7i7heCVnFQhD+lj2iQVqv/fab +ulNW3vS+3OED/AKBYHMDgaPv51HuDlHaYTjp+SEzDFR9uhXEB1M+BCiEmsnV+agdb 3dsPWxLwJHJXJSYHgXIDAEgjvn1V6gn2pGKba5LQgUTPN3yZ8RHNbO7hbvcNsnIqWT k4omQKCIbK41540a1p5qAxXx0E+tSGc1DNvVs0kjE6U4yU2/I3Yy9s3QDcrDsvybRj CVlbBPwHtZkRy12GwfBrdTIFtN1uB548sN9LGPBFeOVq9e3eLWn/T9g4+FMWS5BGwL J4iJjXrNsMqpQ== Message-ID: Date: Sun, 16 Oct 2022 00:01:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v7 07/10] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts Content-Language: en-US To: Jagan Teki , Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula References: <20221005151309.7278-1-jagan@amarulasolutions.com> <20221005151309.7278-8-jagan@amarulasolutions.com> From: Marek Vasut In-Reply-To: <20221005151309.7278-8-jagan@amarulasolutions.com> X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221015_150147_687162_3FA2022B X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/5/22 17:13, Jagan Teki wrote: [...] > @@ -1321,6 +1322,32 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, > pm_runtime_put_sync(dsi->dev); > } > > +#define MAX_INPUT_SEL_FORMATS 1 > + > +static u32 * > +samsung_dsim_atomic_get_input_bus_fmts(struct drm_bridge *bridge, > + struct drm_bridge_state *bridge_state, > + struct drm_crtc_state *crtc_state, > + struct drm_connector_state *conn_state, > + u32 output_fmt, > + unsigned int *num_input_fmts) > +{ > + u32 *input_fmts; > + > + *num_input_fmts = 0; > + > + input_fmts = kcalloc(MAX_INPUT_SEL_FORMATS, sizeof(*input_fmts), > + GFP_KERNEL); > + if (!input_fmts) > + return NULL; > + > + /* This is the DSI-end bus format */ > + input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24; > + *num_input_fmts = 1; Is this the only supported format ? NXP AN13573 lists the following: i.MX 8/RT MIPI DSI/CSI-2, Rev. 0, 21 March 2022 3.7.4 Pixel formats Table 14. DSI pixel packing formats Loosely Packed Pixel Stream, 20-bit YCbCr, 4:2:2 Packed Pixel Stream, 24-bit YCbCr, 4:2:2 Packed Pixel Stream, 16-bit YCbCr, 4:2:2 Packed Pixel Stream, 30-bit RGB, 10-10-10 Packed Pixel Stream, 36-bit RGB, 12-12-12 Packed Pixel Stream, 12-bit YCbCr, 4:2:0 Packed Pixel Stream, 16-bit RGB, 5-6-5 Packed Pixel Stream, 18-bit RGB, 6-6-6 Loosely Packed Pixel Stream, 18-bit RGB, 6-6-6 Packed Pixel Stream, 24-bit RGB, 8-8-8 Format The MX8MM/MN LCDIF can generate all of those RGB formats , the MX8MP LCDIFv3 can also generate the 16bit YCbCr . It seems there should be more formats here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel