From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C525EC433EF for ; Sat, 16 Apr 2022 00:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SS6O3k5G9h+U91/Hnqht1TzeNqxsztqAH4wQ3QTlqIQ=; b=m7hqqpeXKyARq+aPZbjNPVIk3Q VWT/5kP0KXV1X8rjvN9+gJJdt8yBlc0DBCtA4pZ1AljG9ol3uzn66hT5gs/30xhB2X/0r1A/QW13N S+/4KVRmbLP/BCWjmy6bZPLHLDcmEyHJXM0FZsnvlJ7pROyswRN/yX9pBd0SzYgNNqgRxk027NvpF vnuL8ZDwjB7sY5OdaJAWcqrv66jISqsq3myx5+vB+IuiQToKr8Tbef9KSp87E30wQCiFg+/XqoJXk YBlitZ+OKPAEs/+gm7pPHT/d1b/xj1f4y4Mm9pkr3LHdV+nI+DqC+f4qSJHN/ltDH2AxCtJvNBkWr uAIoidaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfVvs-00BlVe-6q; Sat, 16 Apr 2022 00:04:56 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfVvm-00BlTm-Tq for linux-arm-kernel@lists.infradead.org; Sat, 16 Apr 2022 00:04:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650067490; x=1681603490; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=ORZu87hIYWf3otFQvn50x69LdK/rm8I6UEhGlMpo+9U=; b=JrvaWoSDLxdfg2kuFh/GMKlNpqFFOA3a7BD2PQluDxCJ/PYQJcff5Y7g MZHxiBB3f02wRkjrUg/jenwl+Iosgguqd43FJfhf/bmVVY/lZk5MuEnu3 TZlX56ZIYOfmQzA3nCs5jwVhfqv+aV05c17SOFIi7k0m+vi4SYr8ELbvS sVEOcjVzR9uYQijjBvExKJTvZZHEeDWBivUNcfRD/FkwsNYZ/cl7j/w2q DjT9V9HkeRCCliPU1kL2pmQPTD5J94dUQpQLc8uKp8NkTIsHE8Axfholc dbfKca+vxewGgaCnPjZIrSJvkM4YErM20AvV245ZktNn/Zje5pww7HTfS A==; X-IronPort-AV: E=McAfee;i="6400,9594,10318"; a="243833801" X-IronPort-AV: E=Sophos;i="5.90,264,1643702400"; d="scan'208";a="243833801" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2022 17:04:48 -0700 X-IronPort-AV: E=Sophos;i="5.90,264,1643702400"; d="scan'208";a="574590902" Received: from blu2-mobl3.ccr.corp.intel.com (HELO [10.254.212.123]) ([10.254.212.123]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2022 17:04:44 -0700 Message-ID: Date: Sat, 16 Apr 2022 08:04:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 02/13] iommu: Move bus setup to IOMMU device registration Content-Language: en-US To: Robin Murphy , joro@8bytes.org, will@kernel.org References: From: Lu Baolu In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220415_170451_022062_A6ECA0E2 X-CRM114-Status: UNSURE ( 7.28 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jean-philippe@linaro.org, mjrosato@linux.ibm.com, sven@svenpeter.dev, zhang.lyra@gmail.com, robdclark@gmail.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, thierry.reding@gmail.com, linux-arm-kernel@lists.infradead.org, gerald.schaefer@linux.ibm.com, baolu.lu@linux.intel.com, yong.wu@mediatek.com, m.szyprowski@samsung.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/4/14 20:42, Robin Murphy wrote: > @@ -1883,27 +1900,12 @@ static int iommu_bus_init(struct bus_type *bus) > */ > int bus_set_iommu(struct bus_type *bus, const struct iommu_ops *ops) > { > - int err; > - > - if (ops == NULL) { > - bus->iommu_ops = NULL; > - return 0; > - } > - > - if (bus->iommu_ops != NULL) > + if (bus->iommu_ops && ops && bus->iommu_ops != ops) > return -EBUSY; > > bus->iommu_ops = ops; Do we still need to keep above lines in bus_set_iommu()? Best regards, baolu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel