From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D482CCD129A for ; Thu, 4 Apr 2024 09:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=29lOtTn63VKN031zaTFAB117OqSuM36RAi8z0Z4kjSg=; b=hAjkNDIb2ZvHQU PnxA368QlM+ujK0zbqMXLmsU+fQAYhXXMyHr/mgj3IcUUROxPQRpNgyWH1Nu6XMhg/w1+oxz63GxT ILoHr+UGwBPG+nk4Qrktp4C1Zbpm7KkX5ubmbO95RuJHimQwb6DnajVUf63LJF/SZ99lAUz8JPRaY EwU/t/cKE4PoaPcJ28U0KJFWaodmxbUVv3son1klvMMAlhWeP7NaWxtT2gjJO33t/kB6Npee8xt8A LzxuOcfgvwcvhpyxOki/Wsw5lKXMD5E8LmKNgP5S8R+0pp+F0zItpKic3NtHrgG/s1tKAMJUG/reF 5eUwSlnVsJykG7ZDpjbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsJ95-00000001yZm-3bP5; Thu, 04 Apr 2024 09:12:31 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsJ94-00000001yZ6-18K6 for linux-arm-kernel@bombadil.infradead.org; Thu, 04 Apr 2024 09:12:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=5/qWoFKpUTmI+in3AlD1AbpulfsA6eYWzxxFnlnE6c8=; b=amswD+wgypvyi9QK+Vy0jYxR4H 01+hL4TXdEYAxnYgpUwQhy4TZL3tB1bAiFvlqgAbcdQII3nPIlhJ/+JY8j30qHk55cF/YCFVvt9On /wlsXQpw6Vz4ZSVZj713sJ2IaQr0ofdhbij8vCGPRxwwYcejGyiIFWaLAzB8yerj3FlTwAnraepzr e5C+FaJHzAgfL7digkAMNC6At+RJQgyVvCTCVogAeP44M3lYpQyKW8YaHjKsMYB6iUOqOM0/r937z DYLPEw7zzNrmVpKVuwsYmMWNyySfcnLbxpJygL3t3LD1sAJOGFMj/iznGzjDYnBHW5SJR/db4cbK/ 2YYo4z6Q==; Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsJ8z-00000004sjn-2x07 for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 09:12:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1712221942; bh=exVdovH29+iUVKstBi8NnPFuIy61AH2Vqta8XcMCVyI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kw2J6XbU2CsUC0J3jShqRFHxhqZbUHWWuUGLyjU/+p5uLx+Up/tqcodfaPMRb7MWe xTmq7E8LFjwrK+wBZt859ugC89J1lTgT1XlrJRNIigskYlWPIJE5Zz6AFFZfmOw33Z Hu7YK1v4Lk2dMRySFuPVdU+8Q/cwIeYaf+VqUQqDIAcg0XWSukyb0XuJoAegWE0RGH OXt9E7JtRsMFzQLsXjbpCMSK+aFCFht99CTdTbi5PvAtKs/I5mc6/hCJ94nUjaDoTj Oq/FXLUB260Ah5I/76EiKB55DNG6rR+fJ+ScsMeG+7EmUA8x+vb+r2Z/zOoybgUDfG ytkWSki79xU3Q== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id D31FC3780029; Thu, 4 Apr 2024 09:12:21 +0000 (UTC) Message-ID: Date: Thu, 4 Apr 2024 11:12:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] arm64: dts: airoha: Add EN7581 clock node To: Lorenzo Bianconi Cc: linux-clk@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nbd@nbd.name, john@phrozen.org, devicetree@vger.kernel.org, dd@embedd.com, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, lorenzo.bianconi83@gmail.com References: <8465b7562bcf53a0adfdd4ae01b3ed94d6d5bc54.1712160869.git.lorenzo@kernel.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_101226_146066_317F4BBE X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 04/04/24 10:57, Lorenzo Bianconi ha scritto: >> Il 03/04/24 18:20, Lorenzo Bianconi ha scritto: >>> Introduce the Airoha EN7581 clock node in Airoha EN7581 dtsi >>> >>> Tested-by: Zhengping Zhang >>> Signed-off-by: Lorenzo Bianconi >>> --- >>> arch/arm64/boot/dts/airoha/en7581.dtsi | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/airoha/en7581.dtsi b/arch/arm64/boot/dts/airoha/en7581.dtsi >>> index 55eb1762fb11..a1daaaef0de0 100644 >>> --- a/arch/arm64/boot/dts/airoha/en7581.dtsi >>> +++ b/arch/arm64/boot/dts/airoha/en7581.dtsi >>> @@ -2,6 +2,7 @@ >>> #include >>> #include >>> +#include >>> / { >>> interrupt-parent = <&gic>; >>> @@ -150,5 +151,13 @@ uart1: serial@1fbf0000 { >>> interrupts = ; >>> clock-frequency = <1843200>; >>> }; >>> + >>> + scu: system-controller@1fa20000 { >> >> Uhm, why is this not a clock-controller but a system-controller? > > I used the same approach used for en7523.dtsi. I guess it is done > that way because the registers come from scu (system control unit) > regmap, but I guess we can use clock-controller instead. > Yeah, comes from there but you're actually defining a node for a clock-controller, not a system-controller... makes sense to define this as scuclk: clock-controller@1fa20000 ...or something along that line (for the phandle) so that, if another scu related node appears for whatever reason, we distinguish between scuxyz and scuclk. Cheers > Regards, > Lorenzo > >> >> Cheers, >> Angelo >> >>> + compatible = "airoha,en7581-scu"; >>> + reg = <0x0 0x1fa20000 0x0 0x400>, >>> + <0x0 0x1fb00000 0x0 0x1000>, >>> + <0x0 0x1fbe3400 0x0 0xfc>; >>> + #clock-cells = <1>; >>> + }; >>> }; >>> }; >> >> >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel