From mboxrd@z Thu Jan 1 00:00:00 1970 From: jonathanh@nvidia.com (Jon Hunter) Date: Thu, 3 Nov 2016 10:29:14 +0000 Subject: [PATCH V3 5/6] ARM: tegra: Add Tegra20 GMI support In-Reply-To: <1477576872-2665-6-git-send-email-mirza.krak@gmail.com> References: <1477576872-2665-1-git-send-email-mirza.krak@gmail.com> <1477576872-2665-6-git-send-email-mirza.krak@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 27/10/16 15:01, Mirza Krak wrote: > From: Mirza Krak > > Add a device node for the GMI controller found on Tegra20. > > Signed-off-by: Mirza Krak > Tested-by: Marcel Ziswiler > Tested-on: Colibri T20/T30 on EvalBoard V3.x and GMI-Memory Board > --- > > Changes in v2: > - added address-cells, size-cells and ranges properties > > Changes in v3: > - fixed range address which is not the same as Tegra30. > > arch/arm/boot/dts/tegra20.dtsi | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > index 2207c08..b22cddb 100644 > --- a/arch/arm/boot/dts/tegra20.dtsi > +++ b/arch/arm/boot/dts/tegra20.dtsi > @@ -1,4 +1,4 @@ > -#include > +include After fixing up this, can you also ... > #include > #include > #include > @@ -376,6 +376,20 @@ > status = "disabled"; > }; > > + Drop this additional line? > + gmi at 70009000 { > + compatible = "nvidia,tegra20-gmi"; > + reg = <0x70009000 0x1000>; > + #address-cells = <2>; > + #size-cells = <1>; > + ranges = <0 0 0xd0000000 0xfffffff>; > + clocks = <&tegra_car TEGRA20_CLK_NOR>; > + clock-names = "gmi"; > + resets = < &tegra_car 42>; Get rid of this additional space? > + reset-names = "gmi"; > + status = "disabled"; > + }; > + Otherwise ... Acked-by: Jon Hunter Cheers Jon -- nvpublic