From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B82A2C433EF for ; Fri, 8 Apr 2022 08:34:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ojttvjNW4Rmu7GAJ/ycga0iqUfVzQdWrO7nUAtIlJJM=; b=seTz1tavCqvadi E4/4IxQRtMW3vIeNiAt3CAGb/XUopzi55VJalNLJzBPxH8WI1VibfumUJNO6g+iBkN0YNpsF4zChV oSl+kGrufx1GEiIYPAQR91f2bzqkhbeqLux+PVP0cWDg+VAokVl4pDalwzGj9G1yDu3ah+VKGqx6M NpHrgukLbXuSqOV8E+z8mzLWLvsXXcRErCOhjldaBjGj1Ipni61Tyw0TvMZkPnCVCbewPqMTQFA78 Y9h2Fi9wOTgt7xQTQLK8iIPzpgq0mXl9SfTCzdlyThiPA52+2E7vP3fxYjHz521ZNEj3yGitHmWNJ wr2iUltUiGHfY/dyEJFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nck34-00Fu3F-QB; Fri, 08 Apr 2022 08:32:54 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nck2r-00FttS-Fk for linux-arm-kernel@lists.infradead.org; Fri, 08 Apr 2022 08:32:44 +0000 Received: by mail-ej1-x629.google.com with SMTP id i27so15825108ejd.9 for ; Fri, 08 Apr 2022 01:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=txV/NfQNrP1uyaZw5luTkUIuG9UIe6T8laPnVtE+ou4=; b=vGnmC+4yvuJ5/2224lsny3kyYz8KUeTaMBgGe9emI8XWejQGVyxSZmL74JDm5FkTSc alnaihX67FdoQeEJPb8zR9H6krAT9lDs8CwysnzMJYd3+yk7Nkf99+qFnYHYiGx720RU z5BPLeurEmsfvnIwXFRQr4FdvbaA2VJUxsmF8UJNmVjaf7E0hLlvKMQUBRhQzLJOHhLU 4QGlDLX1IpfPjLLVZKbWbNkyk1VGwjxqb5r23yNzgTjBC9NworXQkDbnLl1qmPy84TTJ 9Cc+0IeOrv9/gIn4vn9s/WHSedoITzb/jMvV3ECTjD/z3puyNbDEzMrqZVcqXTt7R43q jR1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=txV/NfQNrP1uyaZw5luTkUIuG9UIe6T8laPnVtE+ou4=; b=7b1KFVs3/3rytzngtw+pqyI+9VMT4y0uGLQFp+PMcABpel5r2WbJNK19UZGwC7yS3C 8zZqyBY2UKT0+NM3athdECqkwYRkYTJqDf+OZElvEcpSA0L9joC0B6yrbdZw6oYTBKz1 47BhRx0NWC1PmY2QSIe4pZsZjNNfl7Pc6LzRxSbvi+kq1r/AOPAffQBxUbZfupmzcHOJ IUbsn1WHbIBEASM+4l6eP8LuGO4WTaa+J0v4kz7NEz3Dstm0KI34tybXwDGHSAST9Zcm U2eC7VjHiaWHYB7Of83wn+Mn3BecTGRWMKmXphgH2fgvZr7aA6VoXuqlT1W0QRe1LZwb cCOg== X-Gm-Message-State: AOAM533PSGpCHgm4IKwZL8rUjT6Pq6ZKYa/62qyM+fsaLTQSscD/gySI hOOdZcz5RxZwTo7guzpphKhmNg== X-Google-Smtp-Source: ABdhPJwZqu/QbjMioxqrbCZrGYiCjtPl8hsIJUcyjWkxJCYybU12PCpgfeASpt7aoTgJqVxtALQkVg== X-Received: by 2002:a17:907:160a:b0:6e8:3c5d:9ce5 with SMTP id hb10-20020a170907160a00b006e83c5d9ce5mr6389834ejc.606.1649406757678; Fri, 08 Apr 2022 01:32:37 -0700 (PDT) Received: from [192.168.0.187] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id 22-20020a17090600d600b006dfbc46efabsm8494563eji.126.2022.04.08.01.32.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Apr 2022 01:32:37 -0700 (PDT) Message-ID: Date: Fri, 8 Apr 2022 10:32:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] dt-bindings: timer: Update TI timer to yaml and add compatible for am6 Content-Language: en-US To: Tony Lindgren , Rob Herring , Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Daniel Lezcano , Keerthy , Nishanth Menon , Vignesh Raghavendra References: <20220408081258.57213-1-tony@atomide.com> From: Krzysztof Kozlowski In-Reply-To: <20220408081258.57213-1-tony@atomide.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_013241_637863_64B30CEB X-CRM114-Status: GOOD ( 30.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/04/2022 10:12, Tony Lindgren wrote: > Let's update the TI timer binding to use yaml. And add compatible for > ti,am654-timer for TI am64, am65 and j72 SoCs. As the timer hardware is > the same between am64, am65 and j72 we use the compatible name for the > earliest SoC with this timer. > > As this binding is specific to the TI dual-mode timers also known > as dm-timers, let's use ti,timer-dm.yaml naming for the new file. Thank you for your patch. There is something to discuss/improve. > --- > .../bindings/timer/ti,timer-dm.yaml | 105 ++++++++++++++++++ > .../devicetree/bindings/timer/ti,timer.txt | 44 -------- pwm-omap-dmtimer.txt references old path. > 2 files changed, 105 insertions(+), 44 deletions(-) > create mode 100644 Documentation/devicetree/bindings/timer/ti,timer-dm.yaml > delete mode 100644 Documentation/devicetree/bindings/timer/ti,timer.txt > > diff --git a/Documentation/devicetree/bindings/timer/ti,timer-dm.yaml b/Documentation/devicetree/bindings/timer/ti,timer-dm.yaml > new file mode 100644 > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/ti,timer-dm.yaml > @@ -0,0 +1,105 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/timer/ti,timer-dm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Binding for TI dual-mode timer "TI dual-mode timer" > + > +maintainers: > + - Tony Lindgren > + > +description: | > + The TI dual-mode timer is a general purpose timer with PWM capabilities. > + > +properties: > + compatible: > + enum: > + - ti,omap2420-timer > + - ti,omap3430-timer > + - ti,omap4430-timer > + - ti,omap5430-timer > + - ti,am335x-timer > + - ti,am335x-timer-1ms > + - ti,am654-timer How about ordering the entries by name (so amxxx before omapxxx)? > + > + reg: > + minItems: 1 > + maxItems: 2 > + description: Timer IO register range This was maxItems:1 in old binding, so please mention briefly in commit msg why the change is needed. If only some versions need it, then add allOf:if:then: constraints. > + > + '#address-cells': > + enum: [ 1, 2 ] > + > + '#size-cells': > + enum: [ 1, 2 ] The same. Are these changes to the binding an effect of new compatible? If yes, better to split it into two patches. One for old binding (passing dtbs_check on old compatibles) and one for new compatible with new properties. > + > + clocks: > + description: > + The functional clock for the timer. Some SoCs like omap24xx also have a > + separate interface clock, and some clocks may be only defined for the > + interconnect target module parent. > + minItems: 1 > + maxItems: 2 The same - not mentioned in commit msg. > + > + clock-names: > + description: > + Timer clock names like "fck", "timer_sys_ck". > + oneOf: > + - enum: [ ick, fck ] > + - items: > + - const: fck > + - enum: [ ick, timer_sys_ck ] Are the combinations depending on compatible? If so, you need allOf:if:then: > + > + interrupts: > + description: > + Interrupt if available. The timer PWM features may be usable > + in a limited way even without interrupts. > + maxItems: 1 > + > + ti,timer-alwon: > + description: > + Timer is always enabled when the SoC is powered. Note that some SoCs like > + am335x can suspend to PM coprocessor RTC only mode and in that case the > + SoC power is cut including timers. > + type: boolean > + > + ti,timer-dsp: > + description: > + Timer is routable to the DSP in addition to the operating system. > + type: boolean > + > + ti,timer-pwm: > + description: > + Timer has been wired for PWM capability. > + type: boolean > + > + ti,timer-secure: > + description: > + Timer access has been limited to secure mode only. > + type: boolean > + > + ti,hwmods: > + description: > + Name of the HWMOD associated with timer. This is for legacy > + omap2/3 platforms only. > + $ref: /schemas/types.yaml#/definitions/string > + deprecated: true > + > +required: > + - compatible > + - reg Missing interrupts - they were required. Aren't anymore? > + > +additionalProperties: false > + Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel