From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 219D9C54E94 for ; Wed, 25 Jan 2023 13:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m/y+K8AECAjwOenPwC4OAKDNSFjlD1/F4QwD/0TMP+A=; b=qROnVujN+7VZC1 b3447+mmMcScNiZbGXnmAJN3HhfK0XJazyW0HyVmiB53RFC/z6w8JxlJm1l2Q/ifrrQHniylo3+xH haklbYPa8ygHhtHHb39u4fu4Qzd5DJpSbK9ApSbdwwDa7QTZilbGwLMlUS8pJ5gzMZb1BmDV+DkBy pKnGE00qwgJaGpzgZtd6UbCyul4lotWx2xqM6NVjFmUJzhA/cky8lxV0/BuCP3DOIfar5lTzKXT5T hP/TrDow8ipBgdCbVL4XObWrYHfc0NbvSlCtbyZXyEultJloKUx0my6hqEB0DL+aeYAUG4wlFigNc HD3+9oDHuNhjhvXTb80g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKgDu-007R3Q-Cb; Wed, 25 Jan 2023 13:53:58 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKgDq-007R2Z-G0 for linux-arm-kernel@lists.infradead.org; Wed, 25 Jan 2023 13:53:56 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C6613851A8; Wed, 25 Jan 2023 14:53:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1674654828; bh=uEaUp4riWCv7pn9QdMjebBrffleNL6j6TZrtCY1PtqY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=btzHJ8bKbmH8X1h1M0PUY3cyA5jslvFSwes1bdTKsT9rTYouM5Ca63kTY+UAUjoUf lpbk8BrRPBJ44O54hV9T310hBCBJ5ngTRUGQoxuNTPshIMWBwNsr341d2/hXn5B8l1 G7KkonfOp2KWPwuaEi8wvdqEvHVUjMx5PVOMfl8BgEZGLk0/KpEwSNK/4SNeBqs54N 8haEAgd+MpuqJXPz5tdxoKaABgzZyUjbjooH+2Y1wKdb4zk6TOAPt5hmAmw+b+XtW3 F+Cyo/8STxSIMqH2zHUA4iT77lw1OQb1WDo+s5W6vekx5ndnj8TAZh5xKrBg5timnR NlUshHgjuYSfA== Message-ID: Date: Wed, 25 Jan 2023 14:53:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RESEND PATCH v11 13/18] drm: exynos: dsi: Add Exynos based host irq hooks Content-Language: en-US To: Jagan Teki Cc: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula References: <20230123151212.269082-1-jagan@amarulasolutions.com> <20230123151212.269082-14-jagan@amarulasolutions.com> <43f4a7dc-a4cc-7552-1a6d-a2a49fae6020@denx.de> From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_055354_943626_8E14CD8D X-CRM114-Status: GOOD ( 19.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/25/23 07:54, Jagan Teki wrote: > On Wed, Jan 25, 2023 at 2:54 AM Jagan Teki wrote: >> >> On Wed, Jan 25, 2023 at 2:54 AM Jagan Teki wrote: >>> >>> On Wed, Jan 25, 2023 at 2:42 AM Marek Vasut wrote: >>>> >>>> On 1/24/23 22:01, Jagan Teki wrote: >>>>> On Wed, Jan 25, 2023 at 2:18 AM Marek Vasut wrote: >>>>>> >>>>>> On 1/23/23 16:12, Jagan Teki wrote: >>>>>>> Enable and disable of te_gpio's are Exynos platform specific >>>>>>> irq handling, so add the exynos based irq operations and hook >>>>>>> them for exynos plat_data. >>>>>> >>>>>> If this is just an optional generic GPIO IRQ, why not keep it in the >>>>>> core code ? TE (tearing enable?) should be available on MX8M too. >>>>> >>>>> So far the discussion (since from initial versions) with Marek >>>>> Szyprowski, seems to be available in Exynos. So, I keep it separate >>>>> from the DSIM core. >>>> >>>> Isn't TE a generic GPIO IRQ ? If so, it is available also on i.MX8M . >> >> I will check this. > > In order to use TE_GPIO we need te handler implementation, right now > Exynos CRTC DRM drivers have implementation for this. That is the main > reason to keep the TE_GPIO handling in exynos, maybe if we handle that > generically then it is a viable option to move TE_GPIO to the DSIM > core. I think you can do this exactly the same way exynos does it -- check whether te_handler() callback is implemented by the glue code (the one you already have for various exynos and imx8mm/imx8mm SoCs) and if so, call it. If it is not implemented, do not call anything in the TE IRQ handler. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel