From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEC01C52D7C for ; Thu, 15 Aug 2024 16:15:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HeTP7S2rIUac5fX7M9yp4ebR2GONiulcRqWXqP31ZvU=; b=HH8N3QBjRIoh2PKCIjst/Eh36b s0SkqeiZ/9y26M1qyupP26GiZqKCTx1c9AgTRSHMDYcUZ79OnOxQezMfT/KaSRAizyW8F/sjfWo4a Wa1NlX0XlxelMdPb4NNkOB24Ycj8b43qDfNforyDeTaJVIKKR1FFvQtZ/34V2LEHU4AItm/k87Uty 0CFOZL2THYJcLYq4DUt1X7ax93/u0SPcmlP17M89EjlfAE90nST3zBxgiiRp0urYXC60Nwc8ozmJs VJK2uGTwNHx9rle1YAIUp0twQmw7vMf8Wgmi9Gazvf1f/TekPeTcECjJ7H20LgQNMIu2BHbbX7GIr Mq+GVk0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sed8E-0000000AU2M-0P66; Thu, 15 Aug 2024 16:15:22 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sed7R-0000000ATtw-3Iot for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2024 16:14:40 +0000 Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Wl9BT73g2z1xvH2; Fri, 16 Aug 2024 00:12:33 +0800 (CST) Received: from dggpemf500001.china.huawei.com (unknown [7.185.36.173]) by mail.maildlp.com (Postfix) with ESMTPS id E8CDB1A0188; Fri, 16 Aug 2024 00:14:25 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by dggpemf500001.china.huawei.com (7.185.36.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 16 Aug 2024 00:14:25 +0800 Received: from lhrpeml500005.china.huawei.com ([7.191.163.240]) by lhrpeml500005.china.huawei.com ([7.191.163.240]) with mapi id 15.01.2507.039; Thu, 15 Aug 2024 17:14:23 +0100 From: Shameerali Kolothum Thodi To: Jason Gunthorpe CC: "acpica-devel@lists.linux.dev" , "Alex Williamson" , "Guohanjun (Hanjun Guo)" , "iommu@lists.linux.dev" , Joerg Roedel , Kevin Tian , "kvm@vger.kernel.org" , Len Brown , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Lorenzo Pieralisi , "Rafael J. Wysocki" , "Robert Moore" , Robin Murphy , "Sudeep Holla" , Will Deacon , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , "Nicolin Chen" , "patches@lists.linux.dev" , Linuxarm Subject: RE: [PATCH 2/8] iommu/arm-smmu-v3: Use S2FWB when available Thread-Topic: [PATCH 2/8] iommu/arm-smmu-v3: Use S2FWB when available Thread-Index: AQHa6FotZjxW0m4zQk+YUXvVQrNfTbIe/kcw///9ToCACYxdcA== Date: Thu, 15 Aug 2024 16:14:22 +0000 Message-ID: References: <0-v1-54e734311a7f+14f72-smmuv3_nesting_jgg@nvidia.com> <2-v1-54e734311a7f+14f72-smmuv3_nesting_jgg@nvidia.com> <5af45a0c060c487fb41983c434de0ec6@huawei.com> <20240809151219.GI8378@nvidia.com> In-Reply-To: <20240809151219.GI8378@nvidia.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.177.241] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_091434_360311_257D8114 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Jason Gunthorpe > Sent: Friday, August 9, 2024 4:12 PM > To: Shameerali Kolothum Thodi > Cc: acpica-devel@lists.linux.dev; Alex Williamson > ; Guohanjun (Hanjun Guo) > ; iommu@lists.linux.dev; Joerg Roedel > ; Kevin Tian ; kvm@vger.kernel.org= ; > Len Brown ; linux-acpi@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; Lorenzo Pieralisi ; Ra= fael J. > Wysocki ; Robert Moore ; Robin > Murphy ; Sudeep Holla ; > Will Deacon ; Eric Auger ; Jean- > Philippe Brucker ; Moritz Fischer ; > Michael Shavit ; Nicolin Chen ; > patches@lists.linux.dev > Subject: Re: [PATCH 2/8] iommu/arm-smmu-v3: Use S2FWB when available >=20 > On Fri, Aug 09, 2024 at 02:26:13PM +0000, Shameerali Kolothum Thodi wrote= : > > > + if (smmu->features & ARM_SMMU_FEAT_S2FWB) > > > + pgtbl_cfg.quirks |=3D IO_PGTABLE_QUIRK_ARM_S2FWB; > > > > This probably requires an update in arm_64_lpae_alloc_pgtable_s2() quir= ks > check. >=20 > Yep, fixed I was hoping you had HW to test this.. Let me see if I can get hold of a test setup that supports S2FWB. I do have another concern with respect to the hardware we have which doesn'= t support S2FWB, but those can claim CANWBS. The problem is, BIOS update is n= ot a very liked/feasible solution to already deployed ones. But we can probabl= y add=20 an option/quirk in SMMUv3 driver for those platforms(based on=20 ACPI_IORT_SMMU_V3_HISILICON_HI161X). I hope this is fine. Thanks, Shameer