* [PATCH v2 1/5] dt-bindings: vendor-prefixes: Add Hynetek Semiconductor Co., Ltd.
2026-03-17 18:07 [PATCH v2 0/5] Add HUSB311 Type-C controller Alexey Charkov
@ 2026-03-17 18:07 ` Alexey Charkov
2026-03-17 18:07 ` [PATCH v2 2/5] dt-bindings: usb: richtek,rt1711h: Switch ETEK ET7304 to use a fallback compatible Alexey Charkov
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Alexey Charkov @ 2026-03-17 18:07 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heikki Krogerus,
Greg Kroah-Hartman, Gene Chen, Heiko Stuebner, Yuanshen Cao
Cc: Sebastian Reichel, devicetree, linux-kernel, linux-usb,
linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski,
Alexey Charkov, Conor Dooley
Hynetek Semiconductor Co., Ltd. focuses on intelligent energy control
technology, mainly for the intelligent fast charging and digital energy
fields.
Link: https://en.hynetek.com/
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 5a806faf7170..3ffb1a8e24af 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -747,6 +747,8 @@ patternProperties:
description: Hycon Technology Corp.
"^hydis,.*":
description: Hydis Technologies
+ "^hynetek,.*":
+ description: Hynetek Semiconductor Co., Ltd.
"^hynitron,.*":
description: Shanghai Hynitron Microelectronics Co. Ltd.
"^hynix,.*":
--
2.52.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 2/5] dt-bindings: usb: richtek,rt1711h: Switch ETEK ET7304 to use a fallback compatible
2026-03-17 18:07 [PATCH v2 0/5] Add HUSB311 Type-C controller Alexey Charkov
2026-03-17 18:07 ` [PATCH v2 1/5] dt-bindings: vendor-prefixes: Add Hynetek Semiconductor Co., Ltd Alexey Charkov
@ 2026-03-17 18:07 ` Alexey Charkov
2026-03-17 18:08 ` [PATCH v2 3/5] dt-bindings: usb: richtek,rt1711h: Add Hynetek HUSB311 Alexey Charkov
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Alexey Charkov @ 2026-03-17 18:07 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heikki Krogerus,
Greg Kroah-Hartman, Gene Chen, Heiko Stuebner, Yuanshen Cao
Cc: Sebastian Reichel, devicetree, linux-kernel, linux-usb,
linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski,
Alexey Charkov
As stated in the commit message of commit ec53fe37a560 ("usb: typec: tcpm:
Add vid and chip info for Etek ET7304"), the ETEK ET7304 is functionally
identical to the RT1715, so reflect it in the bindings via a fallback
compatible.
As there are various TCPCI chips by different vendors reimplementing the
registers and behavior of the RT1711H/RT1715, fallback compatibles will
scale better.
Fixes: cd763789d31a ("dt-bindings: usb: document the Etek ET7304 USB Type-C Port Controller")
Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
index 1eb611f35998..62169daddb4c 100644
--- a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
+++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
@@ -18,10 +18,13 @@ description: |
properties:
compatible:
- enum:
- - etekmicro,et7304
- - richtek,rt1711h
- - richtek,rt1715
+ oneOf:
+ - const: richtek,rt1711h
+ - const: richtek,rt1715
+ - items:
+ - enum:
+ - etekmicro,et7304
+ - const: richtek,rt1715
description:
RT1711H support PD20, ET7304 and RT1715 support PD30 except Fast Role Swap.
--
2.52.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 3/5] dt-bindings: usb: richtek,rt1711h: Add Hynetek HUSB311
2026-03-17 18:07 [PATCH v2 0/5] Add HUSB311 Type-C controller Alexey Charkov
2026-03-17 18:07 ` [PATCH v2 1/5] dt-bindings: vendor-prefixes: Add Hynetek Semiconductor Co., Ltd Alexey Charkov
2026-03-17 18:07 ` [PATCH v2 2/5] dt-bindings: usb: richtek,rt1711h: Switch ETEK ET7304 to use a fallback compatible Alexey Charkov
@ 2026-03-17 18:08 ` Alexey Charkov
2026-03-17 18:08 ` [PATCH v2 4/5] usb: typec: tcpci_rt1711h: Drop unnecessary VID/PID/DID checks Alexey Charkov
2026-03-17 18:08 ` [PATCH v2 5/5] arm64: dts: rockchip: Add HUSB311 Type-C controller on RK3576 EVB1 Alexey Charkov
4 siblings, 0 replies; 11+ messages in thread
From: Alexey Charkov @ 2026-03-17 18:08 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heikki Krogerus,
Greg Kroah-Hartman, Gene Chen, Heiko Stuebner, Yuanshen Cao
Cc: Sebastian Reichel, devicetree, linux-kernel, linux-usb,
linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski,
Alexey Charkov
HUSB311 is a pin-compatible and register-compatible drop-in replacement
for RT1711H, so add its compatible string to the existing binding.
Link: https://www.hynetek.com/uploadfiles/site/219/news/0863c0c7-f535-4f09-bacd-0440d2c21088.pdf
Link: https://dl.xkwy2018.com/downloads/RK3588S/03_Product%20Line%20Branch_Tablet/02_Key%20Device%20Specifications/HUSB311%20introduction%2020210526.pdf
Link: https://www.richtek.com/assets/product_file/RT1711H/DS1711H-04.pdf
Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
index 62169daddb4c..f818d07d39c6 100644
--- a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
+++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
@@ -21,12 +21,17 @@ properties:
oneOf:
- const: richtek,rt1711h
- const: richtek,rt1715
+ - items:
+ - enum:
+ - hynetek,husb311
+ - const: richtek,rt1711h
- items:
- enum:
- etekmicro,et7304
- const: richtek,rt1715
description:
RT1711H support PD20, ET7304 and RT1715 support PD30 except Fast Role Swap.
+ HUSB311 is a rebrand of RT1711H which is pin and register compatible.
reg:
maxItems: 1
--
2.52.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 4/5] usb: typec: tcpci_rt1711h: Drop unnecessary VID/PID/DID checks
2026-03-17 18:07 [PATCH v2 0/5] Add HUSB311 Type-C controller Alexey Charkov
` (2 preceding siblings ...)
2026-03-17 18:08 ` [PATCH v2 3/5] dt-bindings: usb: richtek,rt1711h: Add Hynetek HUSB311 Alexey Charkov
@ 2026-03-17 18:08 ` Alexey Charkov
2026-03-17 18:08 ` [PATCH v2 5/5] arm64: dts: rockchip: Add HUSB311 Type-C controller on RK3576 EVB1 Alexey Charkov
4 siblings, 0 replies; 11+ messages in thread
From: Alexey Charkov @ 2026-03-17 18:08 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heikki Krogerus,
Greg Kroah-Hartman, Gene Chen, Heiko Stuebner, Yuanshen Cao
Cc: Sebastian Reichel, devicetree, linux-kernel, linux-usb,
linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski,
Alexey Charkov
Existing checks for VID/PID/DID in the driver are redundant since the
driver is already matched to the device via I2C device ID and OF
compatible strings, and they preclude the use of fallback compatibles.
Remove them to make the driver slimmer and adding new clones easier.
Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
drivers/usb/typec/tcpm/tcpci_rt1711h.c | 59 ++--------------------------------
1 file changed, 2 insertions(+), 57 deletions(-)
diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
index 37cf55ad74f8..4b3e4e22a82e 100644
--- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
+++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
@@ -18,13 +18,6 @@
#include <linux/regmap.h>
#include <linux/regulator/consumer.h>
-#define RT1711H_VID 0x29CF
-#define ET7304_VID 0x6DCF
-#define RT1711H_PID 0x1711
-#define RT1711H_DID 0x2171
-#define RT1715_DID 0x2173
-#define ET7304_DID 0x2173
-
#define RT1711H_PHYCTRL1 0x80
#define RT1711H_PHYCTRL2 0x81
@@ -57,8 +50,6 @@
struct rt1711h_chip_info {
u32 rxdz_sel;
- u16 vid;
- u16 did;
bool enable_pd30_extended_message;
};
@@ -304,35 +295,6 @@ static int rt1711h_sw_reset(struct rt1711h_chip *chip)
return 0;
}
-static int rt1711h_check_revision(struct i2c_client *i2c, struct rt1711h_chip *chip)
-{
- int ret;
-
- ret = i2c_smbus_read_word_data(i2c, TCPC_VENDOR_ID);
- if (ret < 0)
- return ret;
- if (ret != chip->info->vid) {
- dev_err(&i2c->dev, "vid is not correct, 0x%04x\n", ret);
- return -ENODEV;
- }
- ret = i2c_smbus_read_word_data(i2c, TCPC_PRODUCT_ID);
- if (ret < 0)
- return ret;
- if (ret != RT1711H_PID) {
- dev_err(&i2c->dev, "pid is not correct, 0x%04x\n", ret);
- return -ENODEV;
- }
- ret = i2c_smbus_read_word_data(i2c, TCPC_BCD_DEV);
- if (ret < 0)
- return ret;
- if (ret != chip->info->did) {
- dev_err(&i2c->dev, "did is not correct, 0x%04x\n", ret);
- return -ENODEV;
- }
- dev_dbg(&i2c->dev, "did is 0x%04x\n", ret);
- return ret;
-}
-
static int rt1711h_probe(struct i2c_client *client)
{
int ret;
@@ -349,12 +311,6 @@ static int rt1711h_probe(struct i2c_client *client)
chip->info = i2c_get_match_data(client);
- ret = rt1711h_check_revision(client, chip);
- if (ret < 0) {
- dev_err(&client->dev, "check vid/pid fail\n");
- return ret;
- }
-
chip->data.regmap = devm_regmap_init_i2c(client,
&rt1711h_regmap_config);
if (IS_ERR(chip->data.regmap))
@@ -408,27 +364,16 @@ static void rt1711h_remove(struct i2c_client *client)
tcpci_unregister_port(chip->tcpci);
}
-static const struct rt1711h_chip_info et7304 = {
- .rxdz_sel = RT1711H_BMCIO_RXDZSEL,
- .vid = ET7304_VID,
- .did = ET7304_DID,
- .enable_pd30_extended_message = true,
-};
-
static const struct rt1711h_chip_info rt1711h = {
- .vid = RT1711H_VID,
- .did = RT1711H_DID,
};
static const struct rt1711h_chip_info rt1715 = {
.rxdz_sel = RT1711H_BMCIO_RXDZSEL,
- .vid = RT1711H_VID,
- .did = RT1715_DID,
.enable_pd30_extended_message = true,
};
static const struct i2c_device_id rt1711h_id[] = {
- { "et7304", (kernel_ulong_t)&et7304 },
+ { "et7304", (kernel_ulong_t)&rt1715 },
{ "rt1711h", (kernel_ulong_t)&rt1711h },
{ "rt1715", (kernel_ulong_t)&rt1715 },
{}
@@ -436,7 +381,7 @@ static const struct i2c_device_id rt1711h_id[] = {
MODULE_DEVICE_TABLE(i2c, rt1711h_id);
static const struct of_device_id rt1711h_of_match[] = {
- { .compatible = "etekmicro,et7304", .data = &et7304 },
+ { .compatible = "etekmicro,et7304", .data = &rt1715 },
{ .compatible = "richtek,rt1711h", .data = &rt1711h },
{ .compatible = "richtek,rt1715", .data = &rt1715 },
{}
--
2.52.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 5/5] arm64: dts: rockchip: Add HUSB311 Type-C controller on RK3576 EVB1
2026-03-17 18:07 [PATCH v2 0/5] Add HUSB311 Type-C controller Alexey Charkov
` (3 preceding siblings ...)
2026-03-17 18:08 ` [PATCH v2 4/5] usb: typec: tcpci_rt1711h: Drop unnecessary VID/PID/DID checks Alexey Charkov
@ 2026-03-17 18:08 ` Alexey Charkov
2026-03-18 8:17 ` Krzysztof Kozlowski
4 siblings, 1 reply; 11+ messages in thread
From: Alexey Charkov @ 2026-03-17 18:08 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heikki Krogerus,
Greg Kroah-Hartman, Gene Chen, Heiko Stuebner, Yuanshen Cao
Cc: Sebastian Reichel, devicetree, linux-kernel, linux-usb,
linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski,
Alexey Charkov
Rockchip RK3576 EVB1 board has a Hynetek HUSB311 USB Type-C controller on
its Type-C OTG port, which also supports DisplayPort Alternate Mode.
Add the required DT nodes to enable basic HUSB311 operation.
Note that for full support of mode and orientation switching, the USBDP
PHY schema may need to be expanded, such as in [1]. This is left out for
now until the respective schema is finalized and merged.
[1] https://lore.kernel.org/linux-rockchip/20260313-rockchip-usbdp-cleanup-v3-1-3e8fe89a35b5@collabora.com/
Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts
index fb0dd1bc5148..df6c4b4b05f6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts
@@ -11,6 +11,7 @@
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/rockchip.h>
#include <dt-bindings/soc/rockchip,vop2.h>
+#include <dt-bindings/usb/pd.h>
#include "rk3576.dtsi"
/ {
@@ -769,6 +770,25 @@ regulator-state-mem {
&i2c2 {
status = "okay";
+ usbc0: typec-portc@4e {
+ compatible = "hynetek,husb311", "richtek,rt1711h";
+ reg = <0x4e>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PA5 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usbc0_int>;
+ vbus-supply = <&vbus5v0_typec>;
+
+ connector {
+ compatible = "usb-c-connector";
+ label = "USB-C";
+ data-role = "dual";
+ power-role = "source";
+ source-pdos = <PDO_FIXED(5000, 2000,
+ PDO_FIXED_USB_COMM | PDO_FIXED_DATA_SWAP)>;
+ };
+ };
+
hym8563: rtc@51 {
compatible = "haoyu,hym8563";
reg = <0x51>;
--
2.52.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 5/5] arm64: dts: rockchip: Add HUSB311 Type-C controller on RK3576 EVB1
2026-03-17 18:08 ` [PATCH v2 5/5] arm64: dts: rockchip: Add HUSB311 Type-C controller on RK3576 EVB1 Alexey Charkov
@ 2026-03-18 8:17 ` Krzysztof Kozlowski
2026-03-18 8:19 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-18 8:17 UTC (permalink / raw)
To: Alexey Charkov
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heikki Krogerus,
Greg Kroah-Hartman, Gene Chen, Heiko Stuebner, Yuanshen Cao,
Sebastian Reichel, devicetree, linux-kernel, linux-usb,
linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski
On Tue, Mar 17, 2026 at 10:08:02PM +0400, Alexey Charkov wrote:
> Rockchip RK3576 EVB1 board has a Hynetek HUSB311 USB Type-C controller on
> its Type-C OTG port, which also supports DisplayPort Alternate Mode.
>
> Add the required DT nodes to enable basic HUSB311 operation.
>
> Note that for full support of mode and orientation switching, the USBDP
> PHY schema may need to be expanded, such as in [1]. This is left out for
> now until the respective schema is finalized and merged.
>
> [1] https://lore.kernel.org/linux-rockchip/20260313-rockchip-usbdp-cleanup-v3-1-3e8fe89a35b5@collabora.com/
>
> Signed-off-by: Alexey Charkov <alchark@flipper.net>
> ---
> arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
DTS patch must not be in this patchset. Don't mix it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 5/5] arm64: dts: rockchip: Add HUSB311 Type-C controller on RK3576 EVB1
2026-03-18 8:17 ` Krzysztof Kozlowski
@ 2026-03-18 8:19 ` Krzysztof Kozlowski
2026-03-18 8:30 ` Alexey Charkov
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-18 8:19 UTC (permalink / raw)
To: Alexey Charkov
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heikki Krogerus,
Greg Kroah-Hartman, Gene Chen, Heiko Stuebner, Yuanshen Cao,
Sebastian Reichel, devicetree, linux-kernel, linux-usb,
linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski
On 18/03/2026 09:17, Krzysztof Kozlowski wrote:
> On Tue, Mar 17, 2026 at 10:08:02PM +0400, Alexey Charkov wrote:
>> Rockchip RK3576 EVB1 board has a Hynetek HUSB311 USB Type-C controller on
>> its Type-C OTG port, which also supports DisplayPort Alternate Mode.
>>
>> Add the required DT nodes to enable basic HUSB311 operation.
>>
>> Note that for full support of mode and orientation switching, the USBDP
>> PHY schema may need to be expanded, such as in [1]. This is left out for
>> now until the respective schema is finalized and merged.
>>
>> [1] https://lore.kernel.org/linux-rockchip/20260313-rockchip-usbdp-cleanup-v3-1-3e8fe89a35b5@collabora.com/
>>
>> Signed-off-by: Alexey Charkov <alchark@flipper.net>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>
> DTS patch must not be in this patchset. Don't mix it.
In case I am too vague: by don't mix it, I mean - separate DTS changes
to independent patchset. They cannot be combined into USB posting.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 5/5] arm64: dts: rockchip: Add HUSB311 Type-C controller on RK3576 EVB1
2026-03-18 8:19 ` Krzysztof Kozlowski
@ 2026-03-18 8:30 ` Alexey Charkov
2026-03-18 8:39 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Alexey Charkov @ 2026-03-18 8:30 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heikki Krogerus,
Greg Kroah-Hartman, Gene Chen, Heiko Stuebner, Yuanshen Cao,
Sebastian Reichel, devicetree, linux-kernel, linux-usb,
linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski
On Wed, Mar 18, 2026 at 12:19 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 18/03/2026 09:17, Krzysztof Kozlowski wrote:
> > On Tue, Mar 17, 2026 at 10:08:02PM +0400, Alexey Charkov wrote:
> >> Rockchip RK3576 EVB1 board has a Hynetek HUSB311 USB Type-C controller on
> >> its Type-C OTG port, which also supports DisplayPort Alternate Mode.
> >>
> >> Add the required DT nodes to enable basic HUSB311 operation.
> >>
> >> Note that for full support of mode and orientation switching, the USBDP
> >> PHY schema may need to be expanded, such as in [1]. This is left out for
> >> now until the respective schema is finalized and merged.
> >>
> >> [1] https://lore.kernel.org/linux-rockchip/20260313-rockchip-usbdp-cleanup-v3-1-3e8fe89a35b5@collabora.com/
> >>
> >> Signed-off-by: Alexey Charkov <alchark@flipper.net>
> >> ---
> >> arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 20 ++++++++++++++++++++
> >> 1 file changed, 20 insertions(+)
> >
> > DTS patch must not be in this patchset. Don't mix it.
>
> In case I am too vague: by don't mix it, I mean - separate DTS changes
> to independent patchset. They cannot be combined into USB posting.
Thanks Krzysztof. I will split them out in the next submission. I
think it's important to first agree on the use of fallback compatibles
and the best way to handle the (already queued up in next) ET7304
patches this cycle before their bindings hit mainline. Then, I can
rebase and squash/split everything as required.
Best regards,
Alexey
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 5/5] arm64: dts: rockchip: Add HUSB311 Type-C controller on RK3576 EVB1
2026-03-18 8:30 ` Alexey Charkov
@ 2026-03-18 8:39 ` Krzysztof Kozlowski
2026-03-18 8:56 ` Alexey Charkov
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-18 8:39 UTC (permalink / raw)
To: Alexey Charkov
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heikki Krogerus,
Greg Kroah-Hartman, Gene Chen, Heiko Stuebner, Yuanshen Cao,
Sebastian Reichel, devicetree, linux-kernel, linux-usb,
linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski
On 18/03/2026 09:30, Alexey Charkov wrote:
> On Wed, Mar 18, 2026 at 12:19 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 18/03/2026 09:17, Krzysztof Kozlowski wrote:
>>> On Tue, Mar 17, 2026 at 10:08:02PM +0400, Alexey Charkov wrote:
>>>> Rockchip RK3576 EVB1 board has a Hynetek HUSB311 USB Type-C controller on
>>>> its Type-C OTG port, which also supports DisplayPort Alternate Mode.
>>>>
>>>> Add the required DT nodes to enable basic HUSB311 operation.
>>>>
>>>> Note that for full support of mode and orientation switching, the USBDP
>>>> PHY schema may need to be expanded, such as in [1]. This is left out for
>>>> now until the respective schema is finalized and merged.
>>>>
>>>> [1] https://lore.kernel.org/linux-rockchip/20260313-rockchip-usbdp-cleanup-v3-1-3e8fe89a35b5@collabora.com/
>>>>
>>>> Signed-off-by: Alexey Charkov <alchark@flipper.net>
>>>> ---
>>>> arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 20 ++++++++++++++++++++
>>>> 1 file changed, 20 insertions(+)
>>>
>>> DTS patch must not be in this patchset. Don't mix it.
>>
>> In case I am too vague: by don't mix it, I mean - separate DTS changes
>> to independent patchset. They cannot be combined into USB posting.
>
> Thanks Krzysztof. I will split them out in the next submission. I
> think it's important to first agree on the use of fallback compatibles
> and the best way to handle the (already queued up in next) ET7304
> patches this cycle before their bindings hit mainline. Then, I can
> rebase and squash/split everything as required.
These are independent problems. But if you want to connect them, then
here you have:
If I review the patch, Greg will take everything, defeating the purpose
of my comment. So as you can see, I should rather not review them to
achieve one of my goals.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 5/5] arm64: dts: rockchip: Add HUSB311 Type-C controller on RK3576 EVB1
2026-03-18 8:39 ` Krzysztof Kozlowski
@ 2026-03-18 8:56 ` Alexey Charkov
0 siblings, 0 replies; 11+ messages in thread
From: Alexey Charkov @ 2026-03-18 8:56 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heikki Krogerus,
Greg Kroah-Hartman, Gene Chen, Heiko Stuebner, Yuanshen Cao,
Sebastian Reichel, devicetree, linux-kernel, linux-usb,
linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski
On Wed, Mar 18, 2026 at 12:39 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 18/03/2026 09:30, Alexey Charkov wrote:
> > On Wed, Mar 18, 2026 at 12:19 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>
> >> On 18/03/2026 09:17, Krzysztof Kozlowski wrote:
> >>> On Tue, Mar 17, 2026 at 10:08:02PM +0400, Alexey Charkov wrote:
> >>>> Rockchip RK3576 EVB1 board has a Hynetek HUSB311 USB Type-C controller on
> >>>> its Type-C OTG port, which also supports DisplayPort Alternate Mode.
> >>>>
> >>>> Add the required DT nodes to enable basic HUSB311 operation.
> >>>>
> >>>> Note that for full support of mode and orientation switching, the USBDP
> >>>> PHY schema may need to be expanded, such as in [1]. This is left out for
> >>>> now until the respective schema is finalized and merged.
> >>>>
> >>>> [1] https://lore.kernel.org/linux-rockchip/20260313-rockchip-usbdp-cleanup-v3-1-3e8fe89a35b5@collabora.com/
> >>>>
> >>>> Signed-off-by: Alexey Charkov <alchark@flipper.net>
> >>>> ---
> >>>> arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 20 ++++++++++++++++++++
> >>>> 1 file changed, 20 insertions(+)
> >>>
> >>> DTS patch must not be in this patchset. Don't mix it.
> >>
> >> In case I am too vague: by don't mix it, I mean - separate DTS changes
> >> to independent patchset. They cannot be combined into USB posting.
> >
> > Thanks Krzysztof. I will split them out in the next submission. I
> > think it's important to first agree on the use of fallback compatibles
> > and the best way to handle the (already queued up in next) ET7304
> > patches this cycle before their bindings hit mainline. Then, I can
> > rebase and squash/split everything as required.
>
> These are independent problems. But if you want to connect them, then
> here you have:
> If I review the patch, Greg will take everything, defeating the purpose
> of my comment. So as you can see, I should rather not review them to
> achieve one of my goals.
I thought that having the DTS user with the binding that introduces
its existence helps the initial discussion. With the DTS change being
as minimal as it is here, it's definitely no biggie though.
I appreciate your guidance on the fact that Greg applies a series as a
whole. Will split up.
Best regards,
Alexey
^ permalink raw reply [flat|nested] 11+ messages in thread