From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sasha Finkelstein <fnkl.kernel@gmail.com>
Cc: Nick Chan <towinchenmi@gmail.com>,
Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] gpu: drm: adp: Add a backlight driver for the Summit LCD
Date: Tue, 26 Nov 2024 17:52:17 +0100 [thread overview]
Message-ID: <d966732c-94d1-478c-94d3-6565285192eb@kernel.org> (raw)
In-Reply-To: <CAMT+MTSetzODw-cbteQOgEYmEgpiFBVP5eDgjvyHGqofCU=VXg@mail.gmail.com>
On 26/11/2024 17:34, Sasha Finkelstein wrote:
> On Mon, 25 Nov 2024 at 16:07, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> BTW, max-brightness is a property of backlight, not panel, I think.
> This is an oled panel, so no separate backlight device, the mipi commands
> just change the pixel brightness. There is prior art in other bindings on having
> the max-brightness property attached to the panel itself.
Where? git grep gave me only one result for bindings - old Samsung panel
from 15 years ago. If you refer to this one, then use it as example for
the bindings with similar explanation as the commit introducing brightness?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-26 16:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-24 22:29 [PATCH 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay
2024-11-24 22:29 ` [PATCH 1/5] dt-bindgins: display: Add Apple pre-DCP display controller bindings Sasha Finkelstein via B4 Relay
2024-11-25 2:06 ` Rob Herring (Arm)
2024-11-25 7:45 ` Krzysztof Kozlowski
2024-11-25 14:14 ` Hector Martin
2024-11-25 14:53 ` Krzysztof Kozlowski
2024-11-25 15:29 ` Hector Martin
2024-11-24 22:29 ` [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver Sasha Finkelstein via B4 Relay
2024-11-25 8:50 ` Neil Armstrong
2024-11-25 11:24 ` Sasha Finkelstein
2024-11-25 12:57 ` neil.armstrong
2024-11-25 13:14 ` Sasha Finkelstein
2024-11-25 13:16 ` neil.armstrong
2024-11-25 14:24 ` Hector Martin
2024-11-25 15:28 ` Maxime Ripard
2024-11-25 15:55 ` Hector Martin
2024-11-25 15:37 ` neil.armstrong
2024-11-25 9:04 ` Jani Nikula
2024-11-25 10:59 ` Alyssa Ross
2024-11-24 22:29 ` [PATCH 3/5] gpu: drm: adp: Add a backlight driver for the Summit LCD Sasha Finkelstein via B4 Relay
2024-11-25 8:45 ` Neil Armstrong
2024-11-25 11:28 ` Sasha Finkelstein
2024-11-25 14:49 ` Krzysztof Kozlowski
2024-11-25 15:03 ` Nick Chan
2024-11-25 15:06 ` Krzysztof Kozlowski
2024-11-26 16:34 ` Sasha Finkelstein
2024-11-26 16:52 ` Krzysztof Kozlowski [this message]
2024-11-24 22:29 ` [PATCH 4/5] arm64: dts: apple: Add touchbar screen nodes Sasha Finkelstein via B4 Relay
2024-11-25 8:39 ` Nick Chan
2024-11-25 8:43 ` Nick Chan
2024-11-24 22:29 ` [PATCH 5/5] MAINTAINERS: Add entries for touchbar display driver Sasha Finkelstein via B4 Relay
2024-11-25 9:24 ` Nick Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d966732c-94d1-478c-94d3-6565285192eb@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fnkl.kernel@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcan@marcan.st \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=sven@svenpeter.dev \
--cc=towinchenmi@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).