From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Arnd Bergmann" <arnd@arndb.de>,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>
Cc: kernel@collabora.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Bjorn Andersson <andersson@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Mark Brown <broonie@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Vinod Koul <vkoul@kernel.org>, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/13] arm64: defconfig: Enable missing kconfigs for mt8183-kukui-jacuzzi-juniper
Date: Wed, 9 Nov 2022 10:08:27 +0100 [thread overview]
Message-ID: <d9690b4e-30a7-75be-5492-98206c3ccd99@linaro.org> (raw)
In-Reply-To: <06c4f370-715d-4c66-ad43-143b652af5ff@app.fastmail.com>
On 09/11/2022 08:28, Arnd Bergmann wrote:
> On Wed, Nov 9, 2022, at 00:22, Nícolas F. R. A. Prado wrote:
>> mt8183-kukui-jacuzzi-juniper is one of the devices set up to run tests
>> on KernelCI, but several of its drivers are currently disabled in the
>> defconfig. This series enables all the missing kconfigs on the defconfig
>> to get everything probing on that machine so that it can be fully tested
>> by KernelCI.
>
> The changes all look fine, but I would recommend not separating it
> out into 13 patches when you are doing just one thing here.
>
> As a general rule, if you keep saying the same things in each
> patch description, it is usually an indication that they should
> be combined. Similarly, if you find describing unrelated changes
> ("also, ..."), that would be an indication that patches should
> be split up.
I agree. Descriptions you wrote are useful - they explain why you are
doing it - but it got all really too detailed, just for defconfigs. One
commit per one symbol is a bit too much...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-09 9:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 23:22 [PATCH 00/13] arm64: defconfig: Enable missing kconfigs for mt8183-kukui-jacuzzi-juniper Nícolas F. R. A. Prado
2022-11-08 23:22 ` [PATCH 01/13] arm64: defconfig: Enable SPI_MT65XX Nícolas F. R. A. Prado
2022-11-08 23:22 ` [PATCH 02/13] arm64: defconfig: Enable ATH10K_SDIO Nícolas F. R. A. Prado
2022-11-09 9:06 ` Krzysztof Kozlowski
2022-11-08 23:22 ` [PATCH 03/13] arm64: defconfig: Enable TOUCHSCREEN_ELAN Nícolas F. R. A. Prado
2022-11-08 23:22 ` [PATCH 04/13] arm64: defconfig: Enable sound support for MT8183 based machines Nícolas F. R. A. Prado
2022-11-08 23:22 ` [PATCH 05/13] arm64: defconfig: Enable DRM_ANALOGIX_ANX7625 Nícolas F. R. A. Prado
2022-11-08 23:22 ` [PATCH 06/13] arm64: defconfig: Enable MTK_CMDQ Nícolas F. R. A. Prado
2022-11-08 23:22 ` [PATCH 07/13] arm64: defconfig: Enable MTK_SVS Nícolas F. R. A. Prado
2022-11-08 23:22 ` [PATCH 08/13] arm64: defconfig: Enable CR50 TPMs Nícolas F. R. A. Prado
2022-11-08 23:22 ` [PATCH 09/13] arm64: defconfig: Enable MTK_SCP Nícolas F. R. A. Prado
2022-11-08 23:22 ` [PATCH 10/13] arm64: defconfig: Enable VIDEO_MEDIATEK_JPEG Nícolas F. R. A. Prado
2022-11-08 23:22 ` [PATCH 11/13] arm64: defconfig: Enable ARM_MEDIATEK_CCI_DEVFREQ Nícolas F. R. A. Prado
2022-11-08 23:22 ` [PATCH 12/13] arm64: defconfig: Enable GENERIC_ADC_THERMAL Nícolas F. R. A. Prado
2022-11-08 23:22 ` [PATCH 13/13] arm64: defconfig: Enable MEDIATEK_MT6577_AUXADC Nícolas F. R. A. Prado
2022-11-09 7:28 ` [PATCH 00/13] arm64: defconfig: Enable missing kconfigs for mt8183-kukui-jacuzzi-juniper Arnd Bergmann
2022-11-09 9:08 ` Krzysztof Kozlowski [this message]
2022-11-09 14:53 ` Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9690b4e-30a7-75be-5492-98206c3ccd99@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox