From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56D41CD128A for ; Mon, 8 Apr 2024 09:15:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nq+JDQ7xYJFnFfJb5J0c6ellYchxmjSejKhCEd2FiCc=; b=dSyEStnXMdbWz+ FswiziRoeGRV2pHFkWzZJJY/ODmUhcEQ2m0b8YxrNhpuobfXAGSvIybr1Jw64ZV0Gv63dtdMFxvKC m3N/9UlDU3nyrPj+zf1aJfJuD8A1O8ZogCofqMSaSTqU/eLsot+LqsZwxWPilmhPD6YM+9A/Jl04E 8Ke3PDE4YGFlA9nlU0siiWaHgwa6vjFSvGlw2WJX+R+mlRNje4WY7aRJymeZxCLVK1b2OXpN3g5UQ Vu6Ym9C12rP+sDiHOt9kXMU/gneqHL6RsfusHL3Ke9WdeYz5Ah3fVgv5cZ7RWdN7E553/bhu7SJ95 68d6XOiZl+Y5en2ll9cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtl6O-0000000F3Q2-0hlj; Mon, 08 Apr 2024 09:15:44 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtk4n-0000000Epw4-12R4 for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2024 08:10:05 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a4702457ccbso538184066b.3 for ; Mon, 08 Apr 2024 01:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712563797; x=1713168597; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OzIHovojG3644yJzi7Rp4zPvS+LnsKi9BT3OOCmERoA=; b=bEmUmqPXOJudKzeTMbMFH5K8qcm13HOekw0yJU2OLz/2PEYE6eXQw3+hCAjZEY2KKM oriCytPhbZLywNvteSzZ9CYkvblAVtGByGIRZvLdHSr1tAvJuZNDspqhNRG8ztvVM/lz e3OIpyV1IlY8/70lMm+uDHwa4jaL4bh9EO10brCDrrkinCU3EdTsGnPznx/0CkAf0SP0 Fuv6SP/ggAXnUYswMtLIXWfNXzh0N15sqraLEgShwOHPoTqyJv2xjJbbEjuV4fvEJNve bmT9KIqunTxr74Dstq5bUkUP2Qc9sQZ5B1THFiXaM6Y/y5UUe3riX/NSsUgIqGUsvxZs gmrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712563797; x=1713168597; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OzIHovojG3644yJzi7Rp4zPvS+LnsKi9BT3OOCmERoA=; b=JaZ2NyLJQiNK2qQnKsHNKzkEqSzq4ifyQFpTRyRFVDAlSqDTimr8+mXiuFhEN6tuZ3 i/Q14nh8cxGYDrbwrsIv9x7twCm/p0G7aiRuCNCB8jHjm2zYcur/3sPK3/+HL3z0pXh3 +Op80NvIbfPLqSxQWtR5FS9tz8CqtNgsO0TmiVYxgJTDP5Ntjleha0lFA3sDoX3HWltn C39c5+RSxTwP9nC1e8M89GSebrOBILBJITFXc2dPuBpxKqdImyi9/EsDHcq5RUU3VXPF PQKqe3Y3+XBccRjF0vls7ktQAY+oiyuwbZZH2PunXPcZFaNuN7G44a9tPEKXp09SX/uU fPGg== X-Forwarded-Encrypted: i=1; AJvYcCXqe/ixfHSDbSfErezN3Wl8w6/pT7RuatKrm7F7nLdrtVQW+gRWa1v8KtagoDWjCmBMJU2aqqt+K5k8yNuPlBDWbyJjbX+HFGcpj2QZkWijQvOO9nE= X-Gm-Message-State: AOJu0Yy/NM6OYY1TkIvwfJ3VvlhEHUwEL4K6RatIBYC+i9qv0i5gABy0 6Zza4fFcGSz9gCld1+xNRETKn2yc7+O37P5QxWTNLq1yDTVXW9/GixhveS3Uakw= X-Google-Smtp-Source: AGHT+IHtvCDCPVlkweFZtEXFJMtCJqeKZm0fgLqDOmu+n81huoTOcfZOWzp5QNMYK38WJkLMK2XiTQ== X-Received: by 2002:a17:906:3391:b0:a4e:768a:144f with SMTP id v17-20020a170906339100b00a4e768a144fmr4666050eja.36.1712563797196; Mon, 08 Apr 2024 01:09:57 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id gt17-20020a1709072d9100b00a51b3d4bb39sm3081020ejc.59.2024.04.08.01.09.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 01:09:56 -0700 (PDT) Date: Mon, 8 Apr 2024 11:09:51 +0300 From: Dan Carpenter To: Christophe JAILLET Cc: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 2/2] thermal/drivers/mediatek/lvts_thermal: Improve some memory allocation Message-ID: References: <42a87fb9837f1760d1ad4eb7162a7536785dc6f5.1712520052.git.christophe.jaillet@wanadoo.fr> <8cb69f245311a348164b0b5ca3dbc59386746035.1712520052.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8cb69f245311a348164b0b5ca3dbc59386746035.1712520052.git.christophe.jaillet@wanadoo.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_011002_049845_867B2E9A X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Apr 07, 2024 at 10:01:49PM +0200, Christophe JAILLET wrote: > diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c > index 3003dc350766..b133f731c5ba 100644 > --- a/drivers/thermal/mediatek/lvts_thermal.c > +++ b/drivers/thermal/mediatek/lvts_thermal.c > @@ -204,7 +204,7 @@ static const struct debugfs_reg32 lvts_regs[] = { > > static int lvts_debugfs_init(struct device *dev, struct lvts_domain *lvts_td) > { > - struct debugfs_regset32 *regset; > + struct debugfs_regset32 *regsets; > struct lvts_ctrl *lvts_ctrl; > struct dentry *dentry; > char name[64]; > @@ -214,8 +214,14 @@ static int lvts_debugfs_init(struct device *dev, struct lvts_domain *lvts_td) > if (IS_ERR(lvts_td->dom_dentry)) > return 0; > > + regsets = devm_kcalloc(dev, lvts_td->num_lvts_ctrl, > + sizeof(*regsets), GFP_KERNEL); > + if (!regsets) > + return 0; I understand that this preserved the behavior from the original code, but the original code was wrong. This should return -ENOMEM. > + > for (i = 0; i < lvts_td->num_lvts_ctrl; i++) { > > + struct debugfs_regset32 *regset = ®sets[i]; > lvts_ctrl = &lvts_td->lvts_ctrl[i]; The blank line should come after the declaration. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel