From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5600FC43458 for ; Sat, 11 Jul 2026 15:14:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JYTpe4x+dOHQj3AHgqKsfEUdPZqevLMqDGNIxz3LBqs=; b=E+N2C3268cNkfoVvzWRCf/+9xL yu1LLdgoVvFFLER3ML7TO7IcpSLHY2cMTEGOVgRwwkRx+MZJHcv2zIhbi9fL9pufqeepWUytGJm/x MECA5CRwsYRUDGARYEavDjyRlSfxvTMHoO0M7X0dwRGzHBhMPjK+ZPA7b0GVWcXZJWvYlAd2sFwyk kIMcWk8PetpRYgQytJJsw5S1Gqpk5F4XKOcmu+uH/behQdgRwXZDt1CYrfxk8F4ASWEBmVgJof1ja crgnaqB+8S7JR3ONhcFZg6bDom7IfzViXh3o2Kzq0lEieKfh0VNxmuzXGcozsgM31hzTUFAl+1Vl+ P34YYxWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiZOw-00000006dkP-2hqd; Sat, 11 Jul 2026 15:13:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiZOt-00000006diu-0Eo1 for linux-arm-kernel@lists.infradead.org; Sat, 11 Jul 2026 15:13:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E0B9A1477; Sat, 11 Jul 2026 08:13:47 -0700 (PDT) Received: from [10.20.1.47] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3A7053F85F; Sat, 11 Jul 2026 08:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1783782832; bh=sDXWQS6dOHId7445+Y/ZGN5y9lFGKjA7sUnzyFygZdE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FFX7kGTD7Dm5jT3f9oQBpF2GinvIozz2BLkJfOevHZOF93dKmhapKSP2oBd4ZVKKT ZNaed3qMVh0NXCsAclQ1gL3SyjgeomTEQYirlFPsIEb7dirRj2/bXiFYKpYPqkqTBU CBdySDNvnKzcgYTsdhpziU87bFo90FMy5BWgVBys= Message-ID: Date: Sat, 11 Jul 2026 17:13:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] arm64: dts: allwinner: sun50i-h616: Add video engine To: Chen-Yu Tsai , Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Jernej Skrabec , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260711135959.3616919-1-wens@kernel.org> <20260711135959.3616919-8-wens@kernel.org> Content-Language: en-GB From: Andre Przywara In-Reply-To: <20260711135959.3616919-8-wens@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260711_081355_227706_79F2469F X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 7/11/26 15:59, Chen-Yu Tsai wrote: > From: Jernej Skrabec > > The H616 SoC has a video engine, and two SRAM regions needed by it. > > Add the video engine to the dtsi file. > > Signed-off-by: Jernej Skrabec > [wens@kernel.org: Add VE SRAM region and commit message] > Signed-off-by: Chen-Yu Tsai Checked against the binding and the manual: clocks, regs, interrupts and reset matches. Also test-built the DTB: that worked fine, not sure what Sashiko was complaining about. Reviewed-by: Andre Przywara Thanks, Andre > --- > Changes since v1: > - Corrected second IOMMU port > --- > arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > index 1598e86259ab..c6b3a3f8359a 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > @@ -175,6 +175,18 @@ crypto: crypto@1904000 { > resets = <&ccu RST_BUS_CE>; > }; > > + video-codec@1c0e000 { > + compatible = "allwinner,sun50i-h616-video-engine"; > + reg = <0x01c0e000 0x2000>; > + clocks = <&ccu CLK_BUS_VE>, <&ccu CLK_VE>, > + <&ccu CLK_MBUS_VE>; > + clock-names = "ahb", "mod", "ram"; > + resets = <&ccu RST_BUS_VE>; > + interrupts = ; > + iommus = <&iommu 3>, <&iommu 2>; > + allwinner,sram = <&ve_sram 1>, <&sram_c 1>; > + }; > + > syscon: syscon@3000000 { > compatible = "allwinner,sun50i-h616-system-control"; > reg = <0x03000000 0x1000>;