From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A7B6C55822 for ; Wed, 5 Aug 2026 07:14:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+WwkS9i7GNpI0kimuglDAwrHsAV6ybfyNHVpUwpH78Q=; b=xDEYwFDkaBQZZknPhJrveCJ3LO DTfR9ubUXTkeJo7dXAlddCoVSbvHtAa3sj5bvnfM040yI9Q5ATxfYo4MAR3lFYQtl7911HvrVak5s nDnl2o5zEVvNx90ivKJv4GDb3zxAxB1dAQNkcParC7ySnayarmOMGlnjxZpBZd39Tr/oRjvmQre/A +OQPhkac2EdOH0cl2ee5Q8NTVPyMiYtXIV0X7s7NsVLIJdmDbFyKv/dxi7WMoHkxb5ymhTcqXRo2s JdQbDR92PuU+d9U0u8+HkWmAAzKrYBTK5YDQTYEQ9mPRfs5Tv34YkUfIfHoiI+Cgfe2Agi7gCF5l3 Gpi+7UIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrVpx-00000003Ntw-3xrd; Wed, 05 Aug 2026 07:14:50 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrVpu-00000003Ns4-2fn4 for linux-arm-kernel@lists.infradead.org; Wed, 05 Aug 2026 07:14:48 +0000 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-39c8e65e3f5so6133231fa.0 for ; Wed, 05 Aug 2026 00:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785914084; x=1786518884; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+WwkS9i7GNpI0kimuglDAwrHsAV6ybfyNHVpUwpH78Q=; b=k+hilvPhQfNrbV2ULrYoOeCE95C1lutVsCNndao4L0pP/9sqSI/c11py6eMfX/PJAr QYr7U3qagaY9Wq8M/fB+sj8mUh9TQGO+tnJjyzBPgcEjkllUyJUOY2qxthR5pJ36FQI9 tCpUnuWe25zfCZW8vbbVxRIaVP2U3vRhy2mGM1TBXqIuwLw6uPlRiIbGSrzPXGb/AO5d rKVxFjjbIgahKSfqSsEw8EJcVzvcIJ+hsrnQsbi0IHk3tuj4ha+uWBRKUibDRF8vleES sRHdeuaSje3vOk2jeXhEkVnRQ7eEui94Uo+U70yUMuOpzNlzCLCtlo0V+fh2CfEYuJ2n PNjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785914084; x=1786518884; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+WwkS9i7GNpI0kimuglDAwrHsAV6ybfyNHVpUwpH78Q=; b=S/ffj/8WvcPbvulbVm48Lx93khPmOkiWBp7etNOrX4ylZSj/MqKNwGjVZAsd7P7mGA k23vSAL1Lj4myrH2rEQHt44q5d8Z7meHm4eekp2Nc9KFXdVi8IR56YPTMvj+mnRnDHyV npdpvthlBtsp0D4sx7HzNhhu2Zi2vcFniEZaklKxhO1KzQiIRZeeaXYmc2PuTby66msz 0OyJnXXVppYZgIHQmC2HcLD06UMi3Uf3EbMB0Iv58n9EKTDRtcVH+5kjVNP4D5T3BK93 9h4grn+Z7/9z5NI7M9yMligqm6fGohizD18oL7AbVVJ9gYakssru+Pi42hRPYgYeSJmV ZK/g== X-Forwarded-Encrypted: i=1; AHgh+RoA69cZ/f/9vUIuL9OiawAylO2E+S7vdvMU6Qo/gyQquFPrSgPis/DRl1XOYO5g0sU0rjVlD8R4J9aflUxZ5M0C@lists.infradead.org X-Gm-Message-State: AOJu0YzzTsynSC8I87CTsyk8skeMRDqJi7K/wHZwnp4ejxTTKCL7Yfi5 arzDMzLARtE/0/1ULeVR9p0AeyyGS2YOuZ5dSYnA8dPpZtz/v3Rr0dq7 X-Gm-Gg: AR+sD13AGeR61fw9qCHAGDfSjg6DBRhPxNz2TYGHq7M4RX2rS60WYo+xJy7/zxFDIrD Y0zdSW2DnDvVYueA/jQN048CRLghxngAtC9s7Xu+2J1phuvtbXa6Dq+7a1QtkAAf2eBPr9vfQ7C ekEROrcs+Fb6setSwCmSPx5kWaHalHZTFtYDyQYzqQ5AGB/2sG01AtlSMpvVeP0LchZ8aUBv1s8 NmX9aeJzmZTX2bugTRQQMcREtbPg9jXQ4UYyDBKQ3Uy9U9e2V3on8oxt5vdLflj2a6YhDSG24tr 8QPwLcmViU3fwyutLAc9RPA12KyaAMdKXTTyQP+pE2hfhmeDY05Bbo0hDHwL9AeUMTQifw2RGU0 QeV/GBwcrSUE6oNSKKvp4jnqCGK44Slz3BYIdtZKzVYkOQCg2c0Hp3Th1IT5BCLeM/GZSIBiMwC voSK1J95texN44ilo3UDj8vxqm08l6Jus/1+k7CrIn9m/j0d9P/SoS6WhBQ6nrjkDtlZTmdQ== X-Received: by 2002:a05:651c:19aa:b0:393:d6dd:e8a1 with SMTP id 38308e7fff4ca-39fbb1ed3demr5005791fa.2.1785914083978; Wed, 05 Aug 2026 00:14:43 -0700 (PDT) Received: from [10.38.18.54] ([213.255.186.37]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39fb9a33c88sm6775331fa.30.2026.08.05.00.14.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 00:14:43 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 10:14:41 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/10] dt-bindings: mfd: rohm,bd71828-pmic: Use generic power-controller schema To: "Peng Fan (OSS)" , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lubomir Rintel , Dmitry Osipenko , Shree Ramamoorthy , Heiko Stuebner , Joseph Chen , Chris Zhong , Zhang Qing , Sebastian Reichel , Andreas Kemnade , =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Julien Panis , Alexander Kurz , =?UTF-8?Q?Andr=C3=A9_Draszik?= Cc: mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Peng Fan References: <20260804-mfd-syspower-v1-0-a440783c2e78@nxp.com> <20260804-mfd-syspower-v1-8-a440783c2e78@nxp.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <20260804-mfd-syspower-v1-8-a440783c2e78@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260805_001446_718642_B51EE9D7 X-CRM114-Status: GOOD ( 25.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peng, On 04/08/2026 17:16, Peng Fan (OSS) wrote: > From: Peng Fan > > Switch the binding to use the generic power-controller schema instead by > referencing power-controller.yaml and removing the local > `system-power-controller` property definition. > > Signed-off-by: Peng Fan > --- > Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml > index 09e7d68e92bf..9818102e02c7 100644 > --- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml > @@ -15,6 +15,9 @@ description: | > single-cell linear charger. Also included is a Coulomb counter, a real-time > clock (RTC), and a 32.768 kHz clock gate. > > +allOf: > + - $ref: /schemas/power/power-controller.yaml# > + > properties: > compatible: > oneOf: > @@ -79,8 +82,6 @@ properties: > used to mark the pins which should not be configured for GPIO. Please see > the ../gpio/gpio.txt for more information. > > - system-power-controller: true > - > required: > - compatible > - reg > @@ -91,7 +92,7 @@ required: > - gpio-controller > - "#gpio-cells" > > -additionalProperties: false > +unevaluatedProperties: false If I am not mistaken, this allows all bindings from referenced common binding files, whether or not they are declared in this binding? If so, then this is probably not aligned with what I am hoping to do with the ROHM PMIC bindings [1] [2]. I hope to collect the commonly used ROHM PMIC bindings in one common file, and reference it from those PMIC files, which use some of those common properties. I would like to collect all of the commonly used ROHM MFD bindings in the same file because scattering them around in tiny files feels like a bad idea to me. This means that not all of the PMICs referencing this file, use all of the bindings from that file. Hence I would prefer not to just allow everything from the common file - but to limit allowed properties to those that are explicitly mentioned for the specific PMIC. For example, my proposed change [1] moves: rohm,clkout-open-drain, rohm,pin-clkout, rohm,pin-fault_b, "^rohm,pin-dvs[0-1]$" and "^rohm,pin-exten([0-1])?$" to rohm,pmic-pins.yaml. Only the rohm,clkout-open-drain should be supported allowed with the bd71828. Keeping: additionalProperties: false disallows the properties which aren't explicitly mentioned for the bd71828, while making it possible to keep the description, type and other common stuff in the common rohm,pmic-pins.yaml. Also, keeping the single explicit line: system-power-controller: true to denote this specific PMIC can act as a system power controller feels (to me) more descriptive than "hiding" it in $ref: /schemas/power/power-controller.yaml# - which is also a single line. As a summary - would it work if you added the reference (for description), but also kept the explicit system-power-controller: true and also the additionalProperties: false? [1] https://lore.kernel.org/all/838486b443af9188410d8b802a818dc0af20ea9d.1785838585.git.mazziesaccount@gmail.com/ [2] https://lore.kernel.org/all/d419dcf8776f7ea88e4a66b9a0f0087f11e6622c.1785838585.git.mazziesaccount@gmail.com/ Yours, -- Matti > examples: > - | > -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~