From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
To: Conor Dooley <conor@kernel.org>,
Farouk Bouabid <farouk.bouabid@theobroma-systems.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v4 3/6] dt-bindings: serial: add binding for rs485 rx-enable state when rs485 is disabled
Date: Mon, 29 Jan 2024 13:26:51 +0100 [thread overview]
Message-ID: <da864300-ae0a-43fc-84bd-94e985d8ac73@theobroma-systems.com> (raw)
In-Reply-To: <20240128-vagabond-mutilator-cf8dc6ac8a41@spud>
Hi Conor,
On 1/28/24 18:38, Conor Dooley wrote:
> On Fri, Jan 26, 2024 at 03:55:12PM +0100, Farouk Bouabid wrote:
>> RS485 can have a receiver-enable gpio (rx-enable-gpios). When rs485 is
>> enabled, this gpio, if provided, must be driven active while receiving.
>> However when RS485 is disabled this gpio should not have an undefined
>> state. In that case, as DE and RE pins can be connected both to this gpio,
>> if its state is not properly defined, can cause unexpected transceiver
>> behavior.
>> This binding depend on rx-enable-gpios to be implemented.
>
> Why do you need a dedicated property for this when there exists a device
> specific compatible for the uart on both of the affected rockchip
> systems?
>
This has nothing to do with Rockchip's IP but the HW design of our
carrierboard, so using the "rockchip,px30-uart" for that (which I assume
is what was suggested here?) is incorrect since it'll also apply to
PX30, RK3399 and RK3588-based Q7 SoCs we manufacture.
Did I understand the suggestion correctly?
Cheers,
Quentin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-29 12:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 14:55 [PATCH v4 0/6] serial: 8250: Add support for rs485 half/full duplex on puma/ringneck-haikou Farouk Bouabid
2024-01-26 14:55 ` [PATCH v4 1/6] dt-bindings: serial: Add binding for rs485 receiver enable GPIO Farouk Bouabid
2024-01-26 14:55 ` [PATCH v4 2/6] serial: 8250: Support separate rs485 rx-enable GPIO Farouk Bouabid
2024-01-26 14:55 ` [PATCH v4 3/6] dt-bindings: serial: add binding for rs485 rx-enable state when rs485 is disabled Farouk Bouabid
2024-01-28 17:38 ` Conor Dooley
2024-01-29 12:26 ` Quentin Schulz [this message]
2024-01-29 17:22 ` Conor Dooley
2024-01-26 14:55 ` [PATCH v4 4/6] serial: 8250: set rx-enable gpio " Farouk Bouabid
2024-01-26 14:55 ` [PATCH v4 5/6] arm64: dts: rockchip: rk3399-puma-haikou: add rs485 support on uart2 Farouk Bouabid
2024-01-26 14:55 ` [PATCH v4 6/6] arm64: dts: rockchip: px30-ringneck-haikou: add rs485 support on uart5 Farouk Bouabid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da864300-ae0a-43fc-84bd-94e985d8ac73@theobroma-systems.com \
--to=quentin.schulz@theobroma-systems.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=farouk.bouabid@theobroma-systems.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox