From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1A0BCD582A for ; Wed, 7 Jan 2026 10:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vfngUEu+5lUJU0zdatrZqi6JxVQ6DnTxJ3QXwkR4q8g=; b=1orNoEfhj2yKk4jp58Qbl3xZvI eb7EihjEHkmrWbuliZgEMgrgCd7uKhuG/xPSR6DOMkhfzLflTaWpEuxsHysricFAekagSLrAgLy8d wDPiualCl9bSDW4HNKFvos3rctPkl9jV6CmUlg0sg4ACJiR259Eo+h0oapxitcqy+smDQ41yawkL1 G5eimmJLf0UNSZ2ChXJV2TcgnJkd9QQOIQUsDYWFGh6GuPYeSjNno5VEgwz5yJ8KSujYhLq91+ITl J9d2HRhMzktZY5AFa5DAsybRf8ca5ICRVeOTFXXDI2ARJ1BXEX0gwVlD3x64tvdXt+SG4PDwtC+05 JaJzWesg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdQPN-0000000Edqp-0U0I; Wed, 07 Jan 2026 10:04:53 +0000 Received: from mail-m1973188.qiye.163.com ([220.197.31.88]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdQPK-0000000Edpr-0urD; Wed, 07 Jan 2026 10:04:51 +0000 Received: from [172.16.12.51] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 2fcfe245c; Wed, 7 Jan 2026 18:04:43 +0800 (GMT+08:00) Message-ID: Date: Wed, 7 Jan 2026 18:04:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add rk3576 evb2 board To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Chaoyi Chen , Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Quentin Schulz , Kever Yang , Jonas Karlman , John Clark , FUKAUMI Naoki , Jimmy Hon , Dragan Simic , Michael Riesch , Peter Robinson , Shawn Lin , Sebastian Reichel , Andy Yan , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260107070322.323-1-kernel@airkyi.com> <20260107070322.323-3-kernel@airkyi.com> <2437891.BjyWNHgNrj@diego> <881548f1-7dd9-40bb-9267-e5a03fb97820@rock-chips.com> Content-Language: en-US From: Chaoyi Chen In-Reply-To: <881548f1-7dd9-40bb-9267-e5a03fb97820@rock-chips.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9b97ea758003abkunmda7f342cdcde1e X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGR4YH1ZCS0seSUodHk4dSBlWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=Csu+8ZE0U7sudqThazPqJ8qMKRTtF2M9R7Hmzm4Mr6Lw+8GhdhviTKYJo4Fs0F6WMWa/wMp4HBDl5Y9fOd75QotUsQ5FM2aCbH0edvtdUPH9i3y91mzTdKKUvVcZ3/8KWOhpx7e4cmi5ZJ7GbEsJEMybXJ8M/HS2hGcXlf5Bwv0=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=vfngUEu+5lUJU0zdatrZqi6JxVQ6DnTxJ3QXwkR4q8g=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260107_020450_497179_6D68E276 X-CRM114-Status: GOOD ( 16.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/7/2026 5:57 PM, Chaoyi Chen wrote: > Hi Heiko, > > On 1/7/2026 4:21 PM, Heiko Stübner wrote: >> Am Mittwoch, 7. Januar 2026, 08:56:04 Mitteleuropäische Normalzeit schrieb Alexey Charkov: >>> Hi Chaoyi, >>> >>> On Wed, Jan 7, 2026 at 11:04 AM Chaoyi Chen wrote: >>>> >>>> From: Chaoyi Chen >>>> >>>> General features for rk3576 evb2 board: >>>> - Rockchip RK3576 >>>> - LPDDR4/4X >>>> - eMMC5.1 >>>> - RK806-2x2pcs + DiscretePower >>>> - 1x HDMI2.1 TX / HDMI2.0 RX >>>> - 1x full size DP1.4 TX (Only 2 Lanes) >>>> - 2x 10/100/1000M Ethernet >>>> - 5x SATA3.0 7Pin Slot >>>> - 2x USB3.2 Gen1 Host >>>> - 3x USB2.0 Host >>>> - WIFI/BT >>>> - ... >>>> >>>> Tested with eMMC/SDMMC/HDMI/USB/Ethernet/WIFI/BT module. >>>> >>>> Signed-off-by: Chaoyi Chen >> >> [...] >> >>>> + vbus5v0_typec: regulator-vbus5v0-typec { >>>> + compatible = "regulator-fixed"; >>>> + regulator-name = "vbus5v0_typec"; >>> >>> This might better be renamed, given that last time you mentioned this >>> board doesn't have a Type-C connector. Perhaps regulator-vbus5v0-otg? >> >> Alternatively a comment above it. >> >> I.e. regulator-naming should always follow the naming used in the >> schematics, so that it gets easier to reference between schematics >> and devicetree. >> > > Thanks for the explanation. I will fix this in v3. > >> >>>> + regulator-min-microvolt = <5000000>; >>>> + regulator-max-microvolt = <5000000>; >>>> + enable-active-high; >>>> + gpio = <&gpio0 RK_PD1 GPIO_ACTIVE_HIGH>; >>>> + vin-supply = <&vcc5v0_device>; >>>> + pinctrl-names = "default"; >>>> + pinctrl-0 = <&usb_otg0_pwren>; >>>> + }; >>>> + >>>> + vcc12v_dcin: regulator-vcc12v-dcin { >>>> + compatible = "regulator-fixed"; >>>> + regulator-name = "vcc12v_dcin"; >>>> + regulator-always-on; >>>> + regulator-boot-on; >>>> + regulator-min-microvolt = <12000000>; >>>> + regulator-max-microvolt = <12000000>; >>>> + }; >>>> + >>>> + vcc1v2_ufs_vccq_s0: regulator-vcc1v2-ufs-vccq-s0 { >>>> + compatible = "regulator-fixed"; >>>> + regulator-name = "vcc1v2_ufs_vccq_s0"; >>>> + regulator-boot-on; >>>> + regulator-always-on; >>>> + regulator-min-microvolt = <1200000>; >>>> + regulator-max-microvolt = <1200000>; >>>> + vin-supply = <&vcc_sys>; >>>> + }; >>>> + >>>> + vcc1v8_ufs_vccq2_s0: regulator-vcc1v8-ufs-vccq2-s0 { >>>> + compatible = "regulator-fixed"; >>>> + regulator-name = "vcc1v8_ufs_vccq2_s0"; >>>> + regulator-boot-on; >>>> + regulator-always-on; >>>> + regulator-min-microvolt = <1800000>; >>>> + regulator-max-microvolt = <1800000>; >>>> + vin-supply = <&vcc_1v8_s3>; >>>> + }; >>>> + >>>> + vcc3v3_hubreset: vcc3v3-hubreset { >>>> + compatible = "regulator-fixed"; >>>> + regulator-name = "vcc3v3_hubreset"; >>>> + regulator-boot-on; >>>> + regulator-always-on; >>> >>> If this regulator supplies a soldered-on discrete hub and is required >>> to power it up, won't it be better to describe the hub in the device >>> tree (see binding at [1]), make the regulator its supply, and perhaps >>> drop the "regulator-boot-on/regulator-always-on" annotation here, >>> letting the regulator core deal with its enabling instead? >>> >>> [1] https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/usb/usb-device.yaml >> >> Yep, it would be nicer to it this way. >> A live example can be found in the Rock 5 ITX [2] >> >> [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts#n1266 > > Thank you for the great example. BTW the hub used here is CH344. It > looks like we need to add a new binding :) > Typo... It is WCH CH334. >> >> >> Heiko >> >> >>> [snip] >>> >>> Other than these, LGTM - thanks for addressing my comments from v1! >>> Feel free to include my: >>> >>> Reviewed-by: Alexey Charkov >>> >>> Best regards, >>> Alexey >>> >> >> >> >> >> >> > -- Best, Chaoyi