From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36D4BC61D97 for ; Fri, 24 Nov 2023 14:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8GvXD6sGthVcYz1s+b4EfRPOnfHHRl8d/4PnpTsistw=; b=U/O9WllQP0qEJE mmgdMxJO5H+UYNqTMRM2yE0EJIoQ2+HZWaDDkk+3qHDwvkVXK81GA3nU5LpKvbkre8qB7KKn/G6Q8 j16S4ITXfkLJIWM0kl2orHK2TUvz7EEqBMLur2x/UWLi5xghsm0McAdlfvxy2VQV6sP6bl9UOGYp9 t5orOTjNcvQpLqZTS/fhRg/JroROCBu+akoRyfb1RuYSXx4QTxIpw0TgqY4mmqxYg6TEW05yo1jOB bcjCIQ066JZvbuR+vBvAGQpedSqeZVijRHmXa1/eGDDkD8eP30SJ4GmPs1YQp/iwxTcybjzqVYdc5 55c/Oqx3ATOI9Smivq/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6XaO-007TU3-35; Fri, 24 Nov 2023 14:55:16 +0000 Received: from mout.gmx.net ([212.227.17.22]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6XaL-007TRV-1M; Fri, 24 Nov 2023 14:55:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1700837675; x=1701442475; i=wahrenst@gmx.net; bh=MGJoLdIJ4b3gS02fNyae9jTdxCk07HvijAvt2pTRhQ4=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=QG3pg+mDJJ0hhMk/UZ/jr73ct86jleYBys0UoOtGR7/xQlFmGat8nFEHKxf0x4gU g9U/3K7fWZbo32IEOcqeaAoJ6byPn1kGfNiMc1jXg291cHUNblWt/oapim4PwYfug M8AA0ZFOAMsCfTD+nKiTDRt9snwwPPMD/O2imJhHAR8ttlrVoR8oShC9RgQurwBHb VgEEemMrQ9GhdfkvHaqANL48IMiE0xxq2gIeAvyuFuLfG1H4zHW+quMcxYqdi0u93 Qyk+Scc5VHff0RnWglhL4kMJYem2MkBOaD4Pno0RN7hTZhjnNEx6tP2/cTNYNEft/ 5wfCJhIcfiKIQLqOOg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.129] ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1ML9uU-1qpYxF1cyg-00IBn6; Fri, 24 Nov 2023 15:54:35 +0100 Message-ID: Date: Fri, 24 Nov 2023 15:54:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/2] Add waveshare 7inch touchscreen panel support Content-Language: en-US To: Shengyang Chen , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: neil.armstrong@linaro.org, quic_jesszhan@quicinc.com, sam@ravnborg.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, emma@anholt.net, thierry.reding@gmail.com, changhuang.liang@starfivetech.com, keith.zhao@starfivetech.com, jack.zhu@starfivetech.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231124104451.44271-1-shengyang.chen@starfivetech.com> From: Stefan Wahren In-Reply-To: <20231124104451.44271-1-shengyang.chen@starfivetech.com> X-Provags-ID: V03:K1:XPJgdC3RB9K5a7xfMbmwhaguntSiG+JsdR8ThSlBVnEdHH7OlZ6 GzgaDPFE6LuPGjCIfCnR7UC1WzYCxsice4aPbTwtl4G03axlVTqyJzMMi8gxsFKB93KKgOp RX3V7WhFXT1fnfBg/V8IOqPDWlcXnEbOQFOa2tNHhyyr6Za9Phr9eMsq8k7eBK1btzjz+Xb XG0HXHVFeOUMidjfTSswA== UI-OutboundReport: notjunk:1;M01:P0:LI0QlHMq6gM=;oyJjU91oOyd7xgd5qFErx8TshFT ztHgVOIYU1vKyGT3iwOQeRs7HJ3sKMkQ73MI20LG5PbQnm6G3YxiT6kbcebUyaFmxNDdPJ0+W VgaAgYGh4c1xzC61nk9wnyQQz6sJCuR4ngabq93YBibu/BxZMjbeB14VJ4Lt5aLRrUxuRA8ss mEnF/on9k5HKX6ujWOg7tjBHt1pDnwxKEBg6NCkE117lrpTruB+3zEf2XXM2oyg3VKwdCdqgh GENA3RCUAGgeV83dE+Skb2DczjdfpAjrZpAw9puoiJk5i0wQ6zV21TtViOq9s+9m9YPRaCtnx kixBm65R3gH5+/8Fe5J5OjLcBiwVdWnJ9Z9KtIzLw7J9Ub2HCqiSshq4fM3g9fe0VdqdOgwYJ lrbbeT2GfHwu/CvzBX30S8xxRYkCTTY/6EoCEVNfNe49XUVIzcSHjayjiMctFyx8TRP8YCJGX Pq8pv/Yg2AXhHOhsDQc8QnU4Y48z+nRskdJljEQy+SMu5Kl4Di2ROFOo7mNW67XZ7l7XK4SxI 1Pm0YIrfFJtW8LbfCooqU3YTEJpCwhAGO5MWgWHCNkX5Hpw6ZDjYoFCrvon52PzbUdYBuMDdk rJYmrmsXMFEagU3rrLRf8lcTLuvAB5x/eh7BNjH/hoXH8t/x9HAn8H10QAGwlHystVdMc13xf q/QzpNszQk26xt3Mm5lEKmq8DVlLpU9250UVSgJT3f/fYKaGqhgx82pFAw5n1SR9puPgqJ99K UZ7n8ixP0SOEgEXkNfLJ1LEHSfFuZUfcBoF5srTvrhlhqnSjYGlDvUeM3mIio8RAXbrAiwrTW hdmGl5zSjwyBuiC1AP+HSmiB6nJqkNoxni9dWrDQtR5eezTmpcBss63BQJBR5kDOo4oyUEDbH 0zWMgk9AlQOXpa4ZVM6TC/xtchjD3/HyenYj9H2YedeBxmXEaxPI+68T0MES7ufIY3gCsKj9Q v9UL6A== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231124_065513_766048_7E82ABD2 X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shengyang, [fix address of Emma] Am 24.11.23 um 11:44 schrieb Shengyang Chen: > This patchset adds waveshare 7inch touchscreen panel support > for the StarFive JH7110 SoC. > > Patch 1 add new compatible for the raspberrypi panel driver and its dt-binding. > Patch 2 add new display mode and new probing process for raspberrypi panel driver. > > Waveshare 7inch touchscreen panel is a kind of raspberrypi panel > which can be drived by raspberrypi panel driver. > > The series has been tested on the VisionFive 2 board. surprisingly i was recently working on the official Raspberry Pi touchscreen and was able to get it running the new way. What do i mean with the new way. There is almost nothing special to the Raspberry Pi touchscreen, so we should try to use/extend existing components like: CONFIG_DRM_PANEL_SIMPLE CONFIG_TOUCHSCREEN_EDT_FT5X06 CONFIG_DRM_TOSHIBA_TC358762 The only special part is the Attiny on the connector PCB which requires: CONFIG_REGULATOR_RASPBERRYPI_TOUCHSCREEN_ATTINY So the whole point is to avoid writing monolitic drivers for simple panel like that. There is a WIP branch based on top of Linux 6.7-rcX, which should demonstrate this approach [1]. Unfortunately it is not ready for upstreaming, but it has been tested on a Raspberry Pi 3 B Plus. Maybe this is helpful for your case. Actually i consider panel-raspberrypi-touchscreen.c as a dead end, which shouldn't be extended. Btw there are already DT overlays in mainline which seems to use the Raspberry Pi 7inch panel (without touch function yet) [2]. [1] - https://github.com/lategoodbye/rpi-zero/commits/v6.7-7inch-ts [2] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso?h=v6.6.2&id=6b4da1354fd81adace0cda448c77d8f2a47d8474 > > Shengyang Chen (2): > dt-bindings: display: panel: raspberrypi: Add compatible property for > waveshare 7inch touchscreen panel > gpu: drm: panel: raspberrypi: add new display mode and new probing > process > > .../panel/raspberrypi,7inch-touchscreen.yaml | 4 +- > .../drm/panel/panel-raspberrypi-touchscreen.c | 99 ++++++++++++++++--- > 2 files changed, 91 insertions(+), 12 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel