From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB091C3DA6E for ; Wed, 20 Dec 2023 07:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bwZu/i1L6hoC3IU2GnjDbXM0N0mWUimfhvNHFadL/7k=; b=YQ5Qy2dJOqh+YO moFY4CJIWninM/CHX/Naw785q7CjmcdBJILd9XO+oS8u4Ep0nyWBDOwaN0Kl2cG+ndqUhJjeRcoYN PYljgqraVWpM0e2wT4FVYVZ9VuRLEcamAkUJ6Cvni7Q+faA3A4ZvX05keIjTj7uvxBmqbDbZKBva1 YFw4+zdMzYniCosjlGnZ77ZWwih1DHJ3byNzvC1hMgLJW+xdazM+QdYYoFelHl6QsSq/niFr6CD90 5r/ZeTnE/xRZ9J6lEQEyfCjAonmEPnI3vpFxo8PFPQhnnrGKSoOhITtnRs09dnDhBw4uG2pB0CEVs am4YBquokJm3FMO/2dHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFqlk-00GNDf-37; Wed, 20 Dec 2023 07:13:28 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFqlh-00GND3-2O; Wed, 20 Dec 2023 07:13:27 +0000 X-UUID: 3efa5bf29f0711ee958cff29c719f35b-20231220 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=uPcbDGJ8RYuYMpb8HrZXm5WeuRzf88t/taomuztoQMU=; b=cdXtlo4mC6QlaTt/0ivUgv15pmGjIU8CcKzpmErXLEHoKhvK5Nx2pS2O8julViSltuD7Z40Vw7vMidl8U4+SI6KhvqYzbk/YVuwhfpHKCdfBd4vW2z9j0iNt+qXbu9RULmM3HdSHMO4/gnn9pyiL+Lvm9pI5GTtGh34pcdnu2Jw=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:f846254c-3ee8-4083-a706-07864e27d5e8,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:5d391d7,CLOUDID:b901e417-1474-414b-9c9f-6d23a122e796,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 3efa5bf29f0711ee958cff29c719f35b-20231220 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1114212021; Wed, 20 Dec 2023 00:13:16 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 20 Dec 2023 15:03:12 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 20 Dec 2023 15:03:12 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b2x/RgOdrwmZg2v0vd0flmbALUsXI0DQYzUYaFwBoILs6CkMKXCjpwFoZxUCdT2eFG6REFqMmooNUjWuccTgJ8Isl7LqXXhKZSLGY6DwnToF+E6Yxp8p5D1z2NpxPWQBD63sD9SIP1wyWKUfN74zqJece2t+ELoilknUJ+x8pVnaISveK7GvBtxHGLDfsloSR6Qg9C/D+RtppknNStglY8eIwsp07OtCq/NS/+W8BIr7AY6So6eM+UcgLS6oF2RNlt+NcjjXVlMq5QnmUubgcYtDvOvqJ2w01IcbWou47ma8aDOX1xsdKaXE09qiWyooaXfh43FK3kAOeWGj0v1LYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uPcbDGJ8RYuYMpb8HrZXm5WeuRzf88t/taomuztoQMU=; b=oCULOMpWbuwY5sQNh05cVLx6nNg4afnUAjV2N2AGens67sbczZWN4MmrGWOf9xm67pd2QvqReH0YMwvMHZQByrkl/RPSSPeAF5vxq8qEhh8wz8YLrlOdcAvTJ/CfcAX3Ms/W5DKrVi5YxpsCnbD+ozm557P9Pjn+6algNLPPdTTkY/1xnjYKwygEBglvoHma75D2KcodFHRbwGyiniqrqoupDNmuUkJz+PxYHAYKRYjyQMmXSuXjgdX+vmsKDlbyVibkfMPunh9aIR7Kd7dTTf320Xz7kHI3WwYi+iiSiLOjdSOm85xzXU2Fh/BicG7Mpb6TzHWMt04c7QZKirNfqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uPcbDGJ8RYuYMpb8HrZXm5WeuRzf88t/taomuztoQMU=; b=tm+S7rBXxPQ9oaxTJKpawbRsJSo0pMl1zvuYkVergYNjdBOEF4n59CdjIU9lPzqp8HUEl1TVH7yv+6ZfWHAfKXvKd+f1PTP6OeYEVPgHV6Q4xOqiuowuXSZKotv26GcLluN4DM+AHWsoQQswGqqA0bxDRaPMxyVqr0gCUPlw2hc= Received: from PSAPR03MB5605.apcprd03.prod.outlook.com (2603:1096:301:66::6) by TYZPR03MB5213.apcprd03.prod.outlook.com (2603:1096:405:6::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Wed, 20 Dec 2023 07:03:11 +0000 Received: from PSAPR03MB5605.apcprd03.prod.outlook.com ([fe80::4cdf:58fb:79dd:4b7f]) by PSAPR03MB5605.apcprd03.prod.outlook.com ([fe80::4cdf:58fb:79dd:4b7f%4]) with mapi id 15.20.7113.016; Wed, 20 Dec 2023 07:03:10 +0000 From: =?utf-8?B?UGV0ZXIgV2FuZyAo546L5L+h5Y+LKQ==?= To: "ebiggers@google.com" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "quic_nguyenb@quicinc.com" , "jejb@linux.ibm.com" , "beanhuo@micron.com" , "avri.altman@wdc.com" , "bvanassche@acm.org" , "cw9316.lee@samsung.com" , "martin.petersen@oracle.com" , "quic_asutoshd@quicinc.com" , "alim.akhtar@samsung.com" , "chu.stanley@gmail.com" , "linux-scsi@vger.kernel.org" , =?utf-8?B?UG93ZW4gS2FvICjpq5jkvK/mlocp?= , "Arthur.Simchaev@wdc.com" , "mani@kernel.org" , =?utf-8?B?U3RhbmxleSBDaHUgKOacseWOn+mZnik=?= , "matthias.bgg@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "quic_cang@quicinc.com" , "angelogioacchino.delregno@collabora.com" , "yang.lee@linux.alibaba.com" CC: "jt77.jang@samsung.com" , "sh043.lee@samsung.com" , "grant.jung@samsung.com" , "dh0421.hwang@samsung.com" Subject: Re: [PATCH] ufs: mcq: Adding a function for MCQ enable Thread-Topic: [PATCH] ufs: mcq: Adding a function for MCQ enable Thread-Index: AQHaMwYy+/NXuE2dq0eEgRehSQFm3rCxvyCA Date: Wed, 20 Dec 2023 07:03:10 +0000 Message-ID: References: <20231220052737.19857-1-cw9316.lee@samsung.com> In-Reply-To: <20231220052737.19857-1-cw9316.lee@samsung.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PSAPR03MB5605:EE_|TYZPR03MB5213:EE_ x-ms-office365-filtering-correlation-id: 8f65736f-2c2a-496f-8f3b-08dc0129ba29 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J/6MqgT6bA304yZYdLAPb/KYfrW/Jr+nUfVZUc1dJ0AFNGL1PhoRDF7oZc/oNrMDjlCIot8fuQcZgHze6GGpRadQW8PYGyr7+Uaxbdfrrv71lrs+EFKZycxuVhL86oL/P3fHuxcfNOGrCZidVw2u0aE7r/lkSwaIOoH0bipzVTtOmhtmfxqHXHtdpP0910p0fDTAg6jhWx81hat0V8TIgVNBsjrOeIg/j1u3CR61KGVci8XotYeTc8jjho2/dgec32hfhVwKsAAhGmXdebTq90uJ8ytONn3nB9nBrl8hZcDTg0DFEh5liEmtMi1vPDx1vEhX6mRsjJZbKeCX4wsrRjmOtyjPAnMV1NqSDYZjQdS6w9usajCTyNr+y5W+/49ypBGVY0NsMWY6X0G5enpru1E4HvyJfwwwnlgYPLRFCfChu4oVKOs4lrNeWJ1nqKhHdLzo/yVTr2D7ZeXqESBdT9Y2FtbTBB9oszUVAWg19GeJPWDhBSlwAmurJSycocfUx/gj5kyrPPniT5+JIhupY8xXYaiGJNY9Joo6W+AmWALXItzF3YPFI/Eoe7i2rjzvrlQX7posoloDyUIxxakslqbUoLn3sW/z3ul2BBn2+tUhCVEnpzJ/vfYCDGZZE1FTJg2RQ5ZouNbTAqq6Ome7VGHNbd5aEW0v5cBo/MAlcubZpXhXoFLSFvirG51tGzrFIPQY3vBGurD1a/PR+MH7onl25hgPS1qf5jZ1XX+NbUsoF+hB8gGrTSiaOxyqARdR x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PSAPR03MB5605.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(39860400002)(396003)(346002)(366004)(136003)(230273577357003)(230922051799003)(230173577357003)(64100799003)(186009)(1800799012)(451199024)(26005)(6512007)(86362001)(83380400001)(6506007)(2616005)(110136005)(54906003)(316002)(4326008)(8676002)(8936002)(66446008)(6486002)(71200400001)(478600001)(66556008)(91956017)(64756008)(66946007)(38100700002)(66476007)(76116006)(122000001)(38070700009)(41300700001)(7416002)(4001150100001)(2906002)(36756003)(85182001)(5660300002)(921008)(99106002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NjIxSGRGQ0R4dkpVVWRoM3d3bGpSajgrSnlIcjJNRGVoSzg1YUpNN3Z3RVRF?= =?utf-8?B?RVRwLzVnSTh2TVJVSWdUZDFCSERSOTlGWlh1dEl6SmdETHZpdkNJYUFqTWkz?= =?utf-8?B?U0pEYU5vY1B2LzV3akxHVVhQUk56SnVtYWNMSDBvUUM4MTV6S1c4TzFMcDlI?= =?utf-8?B?K3ZaNWlaMzJRdWxJZDA2cnllZFU0ay9Wb1QrNHBTMjhDdFFvWERrZTMxYUto?= =?utf-8?B?dGZzZ2NxVEJvV2tuQ1k1czA1WWZFcllBcVFMODBzYkRjOUFrNUlNNXFVSXMr?= =?utf-8?B?TkhISnhpSW5UbCsxcktRZ3hpZDhRckRiQVY3OXc0SUVrbWwzWVV6VFZLZVQ5?= =?utf-8?B?clYxSjl1U0srTDFRMlFPZTNXalU2cDBXUTdSblhuMHhRZDFra2p2dkpnakpE?= =?utf-8?B?TXQxVktzOFkrKzhDSXZSL2had1pqSzkveEFtSEJkT1p4cUNIT1lyOVBIaEpa?= =?utf-8?B?MWxSbHpYQXV6SS93alRESDNrdUl4eGFsaS9mNE05ODBkK0t4UkZ0S28zMXpj?= =?utf-8?B?dy9DZmNIVVBNYjJKL2tJK281MzRaVGo1Z2x3RmN5U2xtaDJibzFQODc1bE43?= =?utf-8?B?SjJrajRncCtUNHJBVGxNZVUwdGVqOG4rQkFiQ0Q3Q3M5dE5mWldsMG4vYXRS?= =?utf-8?B?WFNYZDcwd1FMK2NBNkFHYU1ZajR0cjZ1alg3akN2VSszVDBjbHI2ZmdQYkEz?= =?utf-8?B?RE5kYXBDWjBZNVl2cWNDUVZmQlVETVNvcEhZaVpyM1JGS1d1bFFsTEtRSG42?= =?utf-8?B?OERKb0k0SWpzOVRGMGVSQmRzZXM1c2EwM2U5SCs3c0czUWpDQmNkZnR1OVVJ?= =?utf-8?B?aS9JUG40eEJZOFIwYnhKYndmWFRPanJFa0dpdTl1bnRhUm8rOE0xamM2dFlh?= =?utf-8?B?TFJ3K2cxWTFvUFVUR2pBWGJQMWJnM0RFQzJuNWtTQ1dIU3R6TnNjeS8vSGsx?= =?utf-8?B?VmlTKy9CTm10TDQ2d1VadVg5UDVOSXllRHhVeHl5bzJTSjdlTENVd1YxRllr?= =?utf-8?B?bW9ZUFhCeVliK1lSTVhobnNaNE1ieCtuWC9jRHpDb29MeHZqaTlFeHBnTlNs?= =?utf-8?B?SUJINDdDRE01MUx5QjY0NzMwMjd0Sys1WXV5S1ZTWEFlNHRLQ1ZxSUxWaHds?= =?utf-8?B?eVdxOXZHUXVUdVlYQ2JpS201dTkzVVFlSkRaZ3ZoWmJrTjlPdW1IUTg4R2xn?= =?utf-8?B?RlU5TjdWbTljL0NtRG5HR2c0WnBKMzczWHZKV2RKOVNWY3hob0ttVVdQd0Q5?= =?utf-8?B?Y2FjdjhQWStQQkdFdjg0aHMrUGhHM1ExNkcvbk5QT21vd2s3dlZSQWZVcVJj?= =?utf-8?B?eTdhK3NYVkVkdEV3RmM1SG5KZ1ZCdXZSbW5WTXdzSjJLZ0VJV3BJRG9nV3pL?= =?utf-8?B?MytNbkViMVY0c1lFSGVXNU1jdFR6aE42VHpEbUNMdjJyRkc1eTA2aUszdk1y?= =?utf-8?B?Vm5iMkRnbm8xdnlOdVRZS0Qwdm5scmFkeXhuMTdtdjVIZmhvNGg2YmxkeXla?= =?utf-8?B?ekpPVE80MHZEeWRwT1NndmJlV0lyWS9ITEZIWWp5QkJYQWJwVXlwdkMyeWN2?= =?utf-8?B?V2tUZ2VlWFpua0hFNDdMN2hQS3JabDVtdklBTFlhaExiQnJkQUVSNnFFa0hU?= =?utf-8?B?bDRzRkxiQkhHUWJmM1FkQVR1VjA3aU9BaGxQSHQwTDNJNzZkSTBTNkxVQnVM?= =?utf-8?B?RkQ2T3l2dEpDUXgvK1pFWE5yeWFHTFBIWGZ5MHRrMlkycjNEeUZIa0dWNVZu?= =?utf-8?B?U2YySW9KV1VYQVd5eG5JdjlPYTA4QUxuLzY0dWY1VFVoNWJHZy9kalpoOEhR?= =?utf-8?B?OUxMNFcxcU9meEZoL2F1c0hZRWVIekNHSzdxZUx4SUFYTlJaNXRicEExbzd4?= =?utf-8?B?NWFIdXRRbHpVRzg2b2JCbU4wTlEzYnFCWFpJRTdXZWxIc0lQZ0RUZmY5THJm?= =?utf-8?B?R2JUejdPaGk0UDZOaDIramYrQzdQNVZqK3lmaVFleUN5eFNzM3lpaVFPeHRh?= =?utf-8?B?QWoyNlE2R29vOWZPbnllZndhN1oyeTVxMG9lT0dNMytNck9hL0VQeFhGekNX?= =?utf-8?B?akZMOTEvZDBZSXJyYmFQeVlWTG1xVFMrclphbGJFalUxeCtTSEVoMk0zZ0li?= =?utf-8?B?clZGcXZNZ1ZkeUo4NFN6UmNac3lZRzFpQ255dGUyWEkzOFJoQzFnNDIzZ3dj?= =?utf-8?B?dlE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PSAPR03MB5605.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f65736f-2c2a-496f-8f3b-08dc0129ba29 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2023 07:03:10.7950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rptF84E3xsEHs8PYgWpCXNfzAcDQy8qXVUZ4pgLajWDW4n08s8YqraZq8t3LSK+a8L/cbqHdoqDFvcbbWu+RRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB5213 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231219_231325_798040_E1842E00 X-CRM114-Status: GOOD ( 18.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2023-12-20 at 14:27 +0900, Chanwoo Lee wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > From: ChanWoo Lee > > The REG_UFS_MEM_CFG register is too general(broad) > and it is difficult to know the meaning of only values of 0x1 and > 0x2. > So far, comments were required. > > Therefore, I have added new functions and defines > to improve code readability/reusability. > > Signed-off-by: ChanWoo Lee > --- > drivers/ufs/core/ufs-mcq.c | 10 +++++++++- > drivers/ufs/core/ufshcd.c | 5 +---- > drivers/ufs/host/ufs-mediatek.c | 4 +--- > include/ufs/ufshcd.h | 1 + > include/ufs/ufshci.h | 4 ++++ > 5 files changed, 16 insertions(+), 8 deletions(-) > > diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c > index 0787456c2b89..a34ef3aac540 100644 > --- a/drivers/ufs/core/ufs-mcq.c > +++ b/drivers/ufs/core/ufs-mcq.c > @@ -394,11 +394,19 @@ > EXPORT_SYMBOL_GPL(ufshcd_mcq_make_queues_operational); > > void ufshcd_mcq_enable_esi(struct ufs_hba *hba) > { > -ufshcd_writel(hba, ufshcd_readl(hba, REG_UFS_MEM_CFG) | 0x2, > +ufshcd_writel(hba, ufshcd_readl(hba, REG_UFS_MEM_CFG) | ESI_ENABLE, > REG_UFS_MEM_CFG); > } > EXPORT_SYMBOL_GPL(ufshcd_mcq_enable_esi); > > +void ufshcd_mcq_enable(struct ufs_hba *hba) > +{ > +ufshcd_writel(hba, ufshcd_readl(hba, REG_UFS_MEM_CFG) | > MCQ_MODE_SELECT, > + REG_UFS_MEM_CFG); > +hba->mcq_enabled = true; > +} > +EXPORT_SYMBOL_GPL(ufshcd_mcq_enable); > + > void ufshcd_mcq_config_esi(struct ufs_hba *hba, struct msi_msg *msg) > { > ufshcd_writel(hba, msg->address_lo, REG_UFS_ESILBA); > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c > index ae9936fc6ffb..8195e01e7a3f 100644 > --- a/drivers/ufs/core/ufshcd.c > +++ b/drivers/ufs/core/ufshcd.c > @@ -8723,10 +8723,7 @@ static void ufshcd_config_mcq(struct ufs_hba > *hba) > hba->host->can_queue = hba->nutrs - UFSHCD_NUM_RESERVED; > hba->reserved_slot = hba->nutrs - UFSHCD_NUM_RESERVED; > > -/* Select MCQ mode */ > -ufshcd_writel(hba, ufshcd_readl(hba, REG_UFS_MEM_CFG) | 0x1, > - REG_UFS_MEM_CFG); > -hba->mcq_enabled = true; > +ufshcd_mcq_enable(hba); > > dev_info(hba->dev, "MCQ configured, nr_queues=%d, io_queues=%d, > read_queue=%d, poll_queues=%d, queue_depth=%d\n", > hba->nr_hw_queues, hba->nr_queues[HCTX_TYPE_DEFAULT], > diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs- > mediatek.c > index fc61790d289b..1048add66419 100644 > --- a/drivers/ufs/host/ufs-mediatek.c > +++ b/drivers/ufs/host/ufs-mediatek.c > @@ -1219,9 +1219,7 @@ static int ufs_mtk_link_set_hpm(struct ufs_hba > *hba) > ufs_mtk_config_mcq(hba, false); > ufshcd_mcq_make_queues_operational(hba); > ufshcd_mcq_config_mac(hba, hba->nutrs); > -/* Enable MCQ mode */ > -ufshcd_writel(hba, ufshcd_readl(hba, REG_UFS_MEM_CFG) | 0x1, > - REG_UFS_MEM_CFG); > +ufshcd_mcq_enable(hba); Hi Chanwoo, It is better change 0x1 to MCQ_MODE_SELECT only. And do not change hba->mcq_enabled value because we enable mcq by check hba->mcq_enabled is true. Thanks. Peter > } > > if (err) > diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h > index d862c8ddce03..a96c45fa4b4b 100644 > --- a/include/ufs/ufshcd.h > +++ b/include/ufs/ufshcd.h > @@ -1257,6 +1257,7 @@ unsigned long ufshcd_mcq_poll_cqe_lock(struct > ufs_hba *hba, > struct ufs_hw_queue *hwq); > void ufshcd_mcq_make_queues_operational(struct ufs_hba *hba); > void ufshcd_mcq_enable_esi(struct ufs_hba *hba); > +void ufshcd_mcq_enable(struct ufs_hba *hba); > void ufshcd_mcq_config_esi(struct ufs_hba *hba, struct msi_msg > *msg); > > int ufshcd_opp_config_clks(struct device *dev, struct opp_table > *opp_table, > diff --git a/include/ufs/ufshci.h b/include/ufs/ufshci.h > index d5accacae6bc..e669fad11fd4 100644 > --- a/include/ufs/ufshci.h > +++ b/include/ufs/ufshci.h > @@ -282,6 +282,10 @@ enum { > /* UTMRLRSR - UTP Task Management Request Run-Stop Register 80h */ > #define UTP_TASK_REQ_LIST_RUN_STOP_BIT0x1 > > +/* REG_UFS_MEM_CFG - Global Config Registers 300h */ > +#define MCQ_MODE_SELECT 0x1 > +#define ESI_ENABLE0x2 > + > /* CQISy - CQ y Interrupt Status Register */ > #define UFSHCD_MCQ_CQIS_TAIL_ENT_PUSH_STS0x1 > > -- > 2.29.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel