From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.
Date: Sat, 2 Sep 2017 09:25:33 -0700 [thread overview]
Message-ID: <dadebea9-1a8b-9634-dc8e-34c9c99cb2d7@gmail.com> (raw)
In-Reply-To: <CA+JzhdK9feJzk-TJe5HkHfqZOfDm9gOkDQmSSEHYhcuPu0wX5g@mail.gmail.com>
On 09/02/2017 08:48 AM, Scott Branden wrote:
> Looks good
>
> On Sep 1, 2017 7:10 PM, "Florian Fainelli" <f.fainelli@gmail.com
> <mailto:f.fainelli@gmail.com>> wrote:
>
>
>
> On 08/31/2017 01:16 PM, Scott Branden wrote:
> > Hi Eric,
> >
> > mode is correct, location in file needs to be moved.
> >
> >
> > On 17-08-31 11:54 AM, Eric Anholt wrote:
> >> This doesn't yet enable it on any particular platform, as we still
> >> need a panel driver for bcm911360_entphn.
> >>
> >> Signed-off-by: Eric Anholt <eric at anholt.net <mailto:eric@anholt.net>>
> >> ---
> >>
> >> These bits are just carving off a little bit of my 911360_entphn
> panel
> >> series, to reduce conflicts when rebasing (which I just did for
> >> testing pl111 changes for cygnus regressions). I'm waiting to get my
> >> current RPi panel driver in before working on the 911360 panel again.
> >>
> >> arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++
> >> 1 file changed, 10 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> b/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> index 7c957ea06c66..74f73ff24aec 100644
> >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> @@ -575,6 +575,16 @@
> >> status = "disabled";
> >> };
> >> + clcd: clcd at 180a0000 {
> > please place in correct address ordered location in file
>
> I moved it right above the v3d node to keep the nodes ordered by unit
> address, please check the result here:
>
> https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75
> <https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75>
>
>
> With Moved location
> Acked-by: Scott Branden <scott.branden@broadcom.com
> <mailto:scott.branden@broadcom.com>>
Pushed in place with your tag added, thanks!
--
Florian
prev parent reply other threads:[~2017-09-02 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 18:54 [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus Eric Anholt
2017-08-31 18:54 ` [PATCH 2/2] ARM: dts: Add the PWM node " Eric Anholt
2017-08-31 20:10 ` Scott Branden
2017-09-02 2:11 ` Florian Fainelli
2017-08-31 20:16 ` [PATCH 1/2] ARM: dts: Add the CLCD controller " Scott Branden
2017-09-02 2:10 ` Florian Fainelli
[not found] ` <CA+Jzhd+cX6MW9O+BzSU0NDTEgBet=wbgMdwW9A+fi7HVvxAArA@mail.gmail.com>
[not found] ` <CA+JzhdK9feJzk-TJe5HkHfqZOfDm9gOkDQmSSEHYhcuPu0wX5g@mail.gmail.com>
2017-09-02 16:25 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dadebea9-1a8b-9634-dc8e-34c9c99cb2d7@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).