From: Matthias Brugger <matthias.bgg@gmail.com>
To: Derong Liu <derong.liu@mediatek.com>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
wsp_upstream@mediatek.com, Peng Zhou <peng.zhou@mediatek.com>
Subject: Re: [PATCH] mmc: mediatek: add wait dma stop done flow
Date: Fri, 6 Aug 2021 12:42:31 +0200 [thread overview]
Message-ID: <dae1e028-d817-aba3-cc11-546a07865cda@gmail.com> (raw)
In-Reply-To: <20210806023055.29524-1-derong.liu@mediatek.com>
Thanks for your patch.
On 06/08/2021 04:30, Derong Liu wrote:
> From: mtk13858 <derong.liu@mediatek.com>
>
> it needs to wait for dma stop done after set dma stop.
>
Please provide a better commit message. Which bug do you see on which SoC? Are
you sure you can apply that to all SoC without breaking stuff?
> Signed-off-by: mtk13858 <derong.liu@mediatek.com>
Full name please.
Regards,
Matthias
> ---
> drivers/mmc/host/mtk-sd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 4dfc246c5f95..1dfd2842471b 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2339,6 +2339,8 @@ static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> if (recovery) {
> sdr_set_field(host->base + MSDC_DMA_CTRL,
> MSDC_DMA_CTRL_STOP, 1);
> + while (readl(host->base + MSDC_DMA_CFG) & MSDC_DMA_CFG_STS)
> + cpu_relax();
> msdc_reset_hw(host);
> }
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
parent reply other threads:[~2021-08-06 10:44 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210806023055.29524-1-derong.liu@mediatek.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dae1e028-d817-aba3-cc11-546a07865cda@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=chaotian.jing@mediatek.com \
--cc=derong.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=peng.zhou@mediatek.com \
--cc=ulf.hansson@linaro.org \
--cc=wsp_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).