linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marek Vasut <marex@denx.de>,
	Christoph Niedermaier <cniedermaier@dh-electronics.com>,
	linux-arm-kernel@lists.infradead.org
Cc: Shawn Guo <shawnguo@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	kernel@dh-electronics.com
Subject: Re: [PATCH] ARM: dts: imx6qdl-dhcom: Move IPU iomux node from PDK2 to SoM file
Date: Fri, 12 Aug 2022 20:40:39 +0300	[thread overview]
Message-ID: <db2abc19-9e35-9280-e495-b3cc51a149d3@linaro.org> (raw)
In-Reply-To: <143da4b5-56b8-4752-2716-7df0720bf88d@denx.de>

On 12/08/2022 20:27, Marek Vasut wrote:
> On 8/12/22 15:25, Krzysztof Kozlowski wrote:
>> On 12/08/2022 15:03, Christoph Niedermaier wrote:
>>> To have a variant (imx6dl/imx6q) independent access to the IPU
>>> iomux node move them to the SoM file.
>>
>> There is no such variant using them, so the "possibility" is not a
>> reason for such change. The change by itself, without proper users, does
>> not make any sense.
> 
> I think it does make sense to move the IPUv3 RGB/DPI interface pinmux 
> description from PDK2 carrier board DT into the common SoM DTSI, but for 
> a different reason entirely.
> 
> The SoM specification states there is such an interface on the SoM pins:
> 
> "
> https://wiki.dh-electronics.com/images/2/2e/DOC_DHCOM-Standard-Specification_R01_2016-11-17.pdf
> 
> Page 20
> 
> 5.1.14 RGB Display
> The DHCOM standard provides a parallel 24-bit RGB interface for driving 
> displays.
> "
> 
> And from what I can tell, for a carrier board to be compatible with the 
> SoM standard above, those pins have to be used as the RGB/DPI interface 
> or not used at all.
> 
> So rather than duplicate the pinmux settings in every carrier board DT, 
> better move/deduplicate them into the SoM DTSI.
> 
> But it seems the commit message should be updated to reflect that.
> 
> btw. there are also downstream DTOs which do reference that pinmux 
> settings label, but maybe those DTOs are not really interesting with 
> regards to this specific change.

That's much better reasoning and it makes sense.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-08-12 17:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12 12:03 [PATCH] ARM: dts: imx6qdl-dhcom: Move IPU iomux node from PDK2 to SoM file Christoph Niedermaier
2022-08-12 13:25 ` Krzysztof Kozlowski
2022-08-12 17:27   ` Marek Vasut
2022-08-12 17:40     ` Krzysztof Kozlowski [this message]
2022-08-16 12:33       ` Christoph Niedermaier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db2abc19-9e35-9280-e495-b3cc51a149d3@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=cniedermaier@dh-electronics.com \
    --cc=festevam@gmail.com \
    --cc=kernel@dh-electronics.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=marex@denx.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).