From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0E8BCA0FED for ; Wed, 10 Sep 2025 19:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TEnyrlEfdGgRxrqi2QT7MVPm9abxfPd1Mywal3srRpk=; b=qmly1jsrZEyMw5xlP/FBrkAPID lS94LWJMYGh2FGycjtcI7ZHaOTtKStSa6uJwOAXFRZ88YDdY1gbtn6YduhyOGSQM4/UlyLHPWcRlr mojLtC6l/SidY9oV6ZJNxD5QgDyWEa7x1jgerHqQUSX16azpq5RTmagvCZbfrcID9VhVJ/+8wVbIc bXA7GA1VyiOLpNDzl5by7DwfAeC5VbeY8eTwftweP+rnKdWbwTg/4bcEbmuhksdIcZTTp+WOdAcPA /TdpOoL2Kg7m4acLA09YuDuDUBoWcHjoXe+Ksx9dVaT4kVFCxySrg9ZfZzzAwM61/IFo6BNGkZK1g 119vBKfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwQXi-0000000GJ9o-21eo; Wed, 10 Sep 2025 19:31:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwQXf-0000000GJ6E-15z3 for linux-arm-kernel@lists.infradead.org; Wed, 10 Sep 2025 19:31:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 74A1D328E; Wed, 10 Sep 2025 12:31:34 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 113163F694; Wed, 10 Sep 2025 12:31:36 -0700 (PDT) Message-ID: Date: Wed, 10 Sep 2025 20:31:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/33] arm_mpam: Add MPAM MSC register layout definitions To: "Shaopeng Tan (Fujitsu)" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "devicetree@vger.kernel.org" Cc: "shameerali.kolothum.thodi@huawei.com" , D Scott Phillips OS , "carl@os.amperecomputing.com" , "lcherian@marvell.com" , "bobo.shaobowang@huawei.com" , "baolin.wang@linux.alibaba.com" , Jamie Iles , Xin Hao , "peternewman@google.com" , "dfustini@baylibre.com" , "amitsinght@marvell.com" , David Hildenbrand , Rex Nie , Dave Martin , Koba Ko , Shanker Donthineni , "fenghuay@nvidia.com" , "baisheng.gao@unisoc.com" , Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250822153048.2287-1-james.morse@arm.com> <20250822153048.2287-14-james.morse@arm.com> Content-Language: en-GB From: James Morse In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250910_123143_373386_B89FFF0C X-CRM114-Status: UNSURE ( 9.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shaopeng, On 09/09/2025 12:36, Shaopeng Tan (Fujitsu) wrote: >> Memory Partitioning and Monitoring (MPAM) has memory mapped devices >> (MSCs) with an identity/configuration page. >> >> Add the definitions for these registers as offset within the page(s). >> diff --git a/drivers/resctrl/mpam_internal.h b/drivers/resctrl/mpam_internal.h >> index d49bb884b433..6e0982a1a9ac 100644 >> --- a/drivers/resctrl/mpam_internal.h >> +++ b/drivers/resctrl/mpam_internal.h >> @@ -150,4 +150,270 @@ extern struct list_head mpam_classes; int >> +#define MSMON_CFG_MBWU_CTL_TYPE_MBWU >> 0x42 >> +#define MSMON_CFG_CSU_CTL_TYPE_CSU 0 > > +#define MSMON_CFG_CSU_CTL_TYPE_CSU 0x43? Yes, that looks like the line got truncated. This would have caused the counter type to be mismatched and reprogrammed each time. Thanks for spotting it! James