From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3A4CC43381 for ; Wed, 27 Mar 2019 11:50:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2DDF2070D for ; Wed, 27 Mar 2019 11:50:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J/cdD/SX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2DDF2070D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pWMEBTZR5Uxpo7DrRLE0125x11cKjAm+frIrD3YokUQ=; b=J/cdD/SXiVBWf2rBRMFX7vlLj SN3U1vo05hIa0kDYIhdAxTSGIAmxQT1jpTeUzhQeHZVOilQeHRYd+tFmLIP4yz0aUjdvYJteoqgFj TGc6BUjoR8ZrUACKBkBW87Z8BxQXFfecqnzrhGhAJDOBbaZO9cAYE2Zw/a7LDodWL1gYdBPWdAq6a XmTY/nWbMMaEH9Cjpji8q8cg1Y/qzgIdN98a639aT8+h1zo4BgR51ct8RbakUOq8zeR3++NN0Znlp yM2YzNp0dIGDw6GdOnTENhu6huBEELqKq1fRDNDXasuW2sMSJTKlcZuz3Mhj5nKtiS3+wwbevUtSR 4bmY+yucg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h974x-0000OE-GQ; Wed, 27 Mar 2019 11:50:47 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h974u-0000NI-1n for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 11:50:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D4DBA374; Wed, 27 Mar 2019 04:50:42 -0700 (PDT) Received: from [192.168.0.21] (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0E8A93F557; Wed, 27 Mar 2019 04:50:40 -0700 (PDT) Subject: Re: [PATCH 10/25] coresight: tpiu: Clean up device specific data To: mathieu.poirier@linaro.org References: <1553107783-3340-1-git-send-email-suzuki.poulose@arm.com> <1553107783-3340-11-git-send-email-suzuki.poulose@arm.com> <20190326215440.GB1658@xps15> From: Suzuki K Poulose Message-ID: Date: Wed, 27 Mar 2019 11:52:54 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20190326215440.GB1658@xps15> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_045044_099905_19E28CA7 X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/26/2019 09:54 PM, Mathieu Poirier wrote: > On Wed, Mar 20, 2019 at 06:49:27PM +0000, Suzuki K Poulose wrote: >> Switch to using the coresight device instead of the parent >> amba device. >> >> Cc: Mathieu Poirier >> Signed-off-by: Suzuki K Poulose >> --- >> drivers/hwtracing/coresight/coresight-tpiu.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c >> index b2f72a1..9763721 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpiu.c >> +++ b/drivers/hwtracing/coresight/coresight-tpiu.c >> @@ -48,15 +48,13 @@ >> >> /** >> * @base: memory mapped base address for this component. >> - * @dev: the device entity associated to this component. >> + * @dev: the coresight device entity associated to this component. >> * @atclk: optional clock for the core parts of the TPIU. >> - * @csdev: component vitals needed by the framework. >> */ >> struct tpiu_drvdata { >> void __iomem *base; >> struct device *dev; >> struct clk *atclk; >> - struct coresight_device *csdev; > > Here again I would get rid of @dev rather than @csdev to be consistent with what > was done previously. Sure, will do. Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel