From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 117CDC2D0A3 for ; Thu, 12 Nov 2020 09:43:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CAFC21D40 for ; Thu, 12 Nov 2020 09:43:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hZEhMA4i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CAFC21D40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qgL6wWyS13vSdlbg4jNVoX4FpgXECRRVWsvZQ/Siflo=; b=hZEhMA4ibSlTiP4iDgLSGQoN1 ml4xuUi3wKSjRqAASDWGI/i3q5GTSGOe3zrjRBip2aSGphhReNnkCu3u5EjvZJc/2Clf7XQeSroHV 29QkqwBndiW6lO6/r3Y/UPV6oqK6vLGKcExHb0OuF44HQtjyOfw+HfteR7uqF+9a6o6FicnjogEd+ P2fHGMKIdehqxyYyz0BdJwXNZY3KwZjbe4z5vEWlfG8IL0WrnhAzXY73g7LoWFTz6j8LMMslZ0NpC fGrcycrZ72SOVS1oXRfdrobVEJAZoE1p7JSeLFWAljfBULh8s1gkqJMDT1777suER6NeSPTjMH0BK pHCo0rdRw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd97z-0005Wj-4a; Thu, 12 Nov 2020 09:42:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd97u-0005VI-TS for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 09:42:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B1806139F; Thu, 12 Nov 2020 01:42:44 -0800 (PST) Received: from [10.37.12.33] (unknown [10.37.12.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6C7CC3F73C; Thu, 12 Nov 2020 01:42:40 -0800 (PST) Subject: Re: [PATCH v9 32/44] arm64: mte: Switch GCR_EL1 in kernel entry and exit To: Catalin Marinas , Andrey Konovalov References: <25401c15dc19c7b672771f5b49a208d6e77bfeb5.1605046192.git.andreyknvl@google.com> <20201112093908.GE29613@gaia> From: Vincenzo Frascino Message-ID: Date: Thu, 12 Nov 2020 09:45:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201112093908.GE29613@gaia> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_044247_219626_DBDE3093 X-CRM114-Status: GOOD ( 18.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/12/20 9:39 AM, Catalin Marinas wrote: > On Tue, Nov 10, 2020 at 11:10:29PM +0100, Andrey Konovalov wrote: >> diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c >> index 664c968dc43c..dbda6598c19d 100644 >> --- a/arch/arm64/kernel/mte.c >> +++ b/arch/arm64/kernel/mte.c >> @@ -129,6 +131,26 @@ void *mte_set_mem_tag_range(void *addr, size_t size, u8 tag) >> return ptr; >> } >> >> +void mte_init_tags(u64 max_tag) >> +{ >> + static bool gcr_kernel_excl_initialized = false; >> + >> + if (!gcr_kernel_excl_initialized) { >> + /* >> + * The format of the tags in KASAN is 0xFF and in MTE is 0xF. >> + * This conversion extracts an MTE tag from a KASAN tag. >> + */ >> + u64 incl = GENMASK(FIELD_GET(MTE_TAG_MASK >> MTE_TAG_SHIFT, >> + max_tag), 0); >> + >> + gcr_kernel_excl = ~incl & SYS_GCR_EL1_EXCL_MASK; >> + gcr_kernel_excl_initialized = true; >> + } >> + >> + /* Enable the kernel exclude mask for random tags generation. */ >> + write_sysreg_s(SYS_GCR_EL1_RRND | gcr_kernel_excl, SYS_GCR_EL1); >> +} > > I don't think this function belongs to this patch. There is an earlier > patch that talks about mte_init_tags() but no trace of it until this > patch. > Could you please point out to which patch are you referring to? -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel