linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/3] Add support for BCM7271 style interrupt controller
Date: Tue, 19 Sep 2017 11:05:35 -0700	[thread overview]
Message-ID: <db82458e-5656-1eb2-b4b8-051cc12e7095@gmail.com> (raw)
In-Reply-To: <20170919010000.32072-1-opendmb@gmail.com>

On 09/18/2017 05:59 PM, Doug Berger wrote:
> This patch set extends the functionality of the irq-brcmstb-l2 interrupt
> controller driver to cover a hardware variant first introduced in the
> BCM7271 SoC.  The main difference between this variant and the block
> found in earlier brcmstb SoCs is that this variant only supports level
> sensitive interrupts and therefore does not latch the interrupt state
> based on edges.  Since there is no longer a need to ack interrupts with
> a register write to clear the latch the register map has been changed.
> 
> Therefore the change to add support for the new hardware block is to
> abstract the register accesses to accommodate different maps and to
> identify the block with a new device-tree compatible string.
> 
> I also took the opportunity to make some small efficiency enhancements
> to the driver.  One of these was to make use of the slightly more
> efficient irq_mask_ack method.  However, I discovered that the defined
> irq_gc_mask_disable_reg_and_ack() generic irq function was insufficient
> for my needs.  Previous submissions offered candidate solutions to
> address my needs within the generic irqchip library, but since those
> submissions appear to have stalled I am submitting this version that
> includes the function in the driver to prevent controversy and allow
> the new functionality to be included. 

For this entire series:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks Doug.

> 
> Changes in v4:
> 
> - The first three commits were removed from the patch set to remove any
>   dependencies on changing the generic irqchip or irqchip-tango imple-
>   mentations. If there is a will to make those changes in the future
>   they can be applied at that time, but they needn't hold up the accept-
>   ance of this patch set.
>   
> Changes in v3:
> 
> - I did not submit a v3 patch set, but Marc Gonzalez included a PATCH v3
>   in a response to the v2 patch so I am skipping ahead to v4 to avoid
>   confusion.
>   
> Changes in v2:
> 
> - removed unused permutations of irq_mask_ack methods
> - added Reviewed-by and Acked-by responses from first submission
> 
> Doug Berger (3):
>   irqchip: brcmstb-l2: Remove some processing from the handler
>   irqchip: brcmstb-l2: Abstract register accesses
>   irqchip: brcmstb-l2: Add support for the BCM7271 L2 controller
> 
>  .../bindings/interrupt-controller/brcm,l2-intc.txt |   3 +-
>  drivers/irqchip/irq-brcmstb-l2.c                   | 171 +++++++++++++++------
>  2 files changed, 126 insertions(+), 48 deletions(-)
> 


-- 
Florian

      parent reply	other threads:[~2017-09-19 18:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19  0:59 [PATCH v4 0/3] Add support for BCM7271 style interrupt controller Doug Berger
2017-09-19  0:59 ` [PATCH v4 1/3] irqchip: brcmstb-l2: Remove some processing from the handler Doug Berger
2017-09-19  0:59 ` [PATCH v4 2/3] irqchip: brcmstb-l2: Abstract register accesses Doug Berger
2017-09-19  1:00 ` [PATCH v4 3/3] irqchip: brcmstb-l2: Add support for the BCM7271 L2 controller Doug Berger
2017-09-19 18:05 ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db82458e-5656-1eb2-b4b8-051cc12e7095@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).