From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27532C433EF for ; Mon, 4 Jul 2022 06:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gy0G9fvNkqOVy4fKgjVp/pLtuyDK/+ka6WvRueFHkvA=; b=kIklGasxHOEJFG O0xofWD1jZ/PVHCjP2XTUu6UjMYCw+BPkUc6Zl+rxb9C4Y1gpLiZlQpDbK6ojkr1jnaXCVDwSReNc W8LkBGN1ihhJEyLvLSyyApgaOLHD/J6FTPz1UvAj6j5EKkI+IoYEL5TnQkV7QZGiRPUPz6YatbrQn dSjkdX7cV0VzVQOL9iHNUQYnENyicBb+leCXxTItBeduNB39VzST18/G/pMARlEHlzNAxXN6pB1M0 DoOjbQFZb49zAzkkhSw7nJy/jo6Piu2Fqv7p9umPweLBlYlVVkIfHM8eClR99Z2ydoihIC5oK9U3E ThtcY/QfNNRpp7I+uTAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8FmP-005PbW-9n; Mon, 04 Jul 2022 06:41:57 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8FmM-005PZD-9X for linux-arm-kernel@lists.infradead.org; Mon, 04 Jul 2022 06:41:55 +0000 Received: by mail-lf1-x130.google.com with SMTP id z21so14064684lfb.12 for ; Sun, 03 Jul 2022 23:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=/xTCR3bPZhCA5sareIciLVpBb/bwWDoIGGe6Kd1Xv+w=; b=hgQHadGcMhoSH3Ca+juWM9mdx+9fCV75IphGlK+HJdtR/i4gx0B7DBiSaWAmruJgky D5xJhDtEImx0KCaWYul6S2UI0l56gLyu/L2gfxXpYyyLViA0B+BzCqsOb5LdW7yYxgRY zomyA/I6drlF9k3MnBfvnwDBxzhIVjqjRO/XpFuMZw3SfDzT/E9ae45pUSaVnnMeaQXX h1608xxX8865Hs5cUomfWii/90I/TKFVtzHZ7K4NCjn2m0G/NSVvh5eqOAthC8KKoqCj fAnkRgUlcScDN/VdI3HAbv8MD3ewJPL/5lcQOzqfbHsr/Xc36HS9JGw7ymJLRwY5TuKl +/Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/xTCR3bPZhCA5sareIciLVpBb/bwWDoIGGe6Kd1Xv+w=; b=L1JQf7vXwvyFa/DULmMV9zbt0mVEadNBvmkgcCnaWrwiYIIyJIExVkQ1gd9DYcOOLs LvThJYS7uFvG6Z2NuoP0HliaEFK+cQy52ACYexxN2XVuarSXnD7yhsvHXmaPl53yzZBE wtAJA92YdVwQgypw81Qq1NMNx5EWkOecEKGnkBQ4mkTAIbKyY+Q/ie+jxc0oeQ3jcdL4 xHRqDolwfAhCWevBiqetAkS2io/3Iz8o+1gO0DDyxtiYj2UnU9SxUiEntO/PaY5uHbGX qWX7jHIUUkFJ3b59esHd1TgfxZ4fwb8nxlKHEusRUrs7iExMsAojXnrLBGNVI6AcKlQk 2V/g== X-Gm-Message-State: AJIora8Ub/3Dk0UVU3RvjjfSsWhRU7CY6o9QUJoPmbYcyEhVV+3Yr9Wm +R7m2LKMufZXQb0kmYjZGdtD8g== X-Google-Smtp-Source: AGRyM1sSTc5DqVbACUPJW4eop8W1a9JW3DaH/3CvqzBZHFAkvYeJJp4gMOetKPepfi26QwqTyXrr/g== X-Received: by 2002:a05:6512:3085:b0:481:182e:a06c with SMTP id z5-20020a056512308500b00481182ea06cmr17866385lfd.374.1656916910911; Sun, 03 Jul 2022 23:41:50 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id k6-20020ac257c6000000b0047fa02cd96csm4994687lfo.162.2022.07.03.23.41.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Jul 2022 23:41:50 -0700 (PDT) Message-ID: Date: Mon, 4 Jul 2022 08:41:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 07/15] dt-bindings: reset: amd,pensando-elbasr-reset: Add AMD Pensando SR Reset Controller bindings Content-Language: en-US To: Brad Larson Cc: Linux ARM , Linux Kernel Mailing List , linux-mmc , Adrian Hunter , Al Cooper , Andy Shevchenko , Arnd Bergmann , blarson@amd.com, Catalin Marinas , Gabriel Somlo , gerg@linux-m68k.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Lee Jones , Mark Brown , Masahiro Yamada , Philipp Zabel , Pratyush Yadav , Randy Dunlap , Rob Herring , samuel@sholland.org, Serge Semin , suravee.suthikulpanit@amd.com, Tom Lendacky , Ulf Hansson , Will Deacon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20220613195658.5607-1-brad@pensando.io> <20220613195658.5607-8-brad@pensando.io> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220703_234154_424025_5B620021 X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/07/2022 01:50, Brad Larson wrote: >> Missing file: >> ls: cannot access 'include/dt-bindings/reset/amd,pensando-elba-reset.h': >> No such file or directory >> >> >> Send complete bindings, not parts of it. Did you test it? I am pretty >> sure that this did not happen. :( > > Its in patch v5-0015 with the driver Header is part of bindings, not driver. >. I'll check this, the correct > approach should be put all binding changes as individual patches up > front or there are exceptions for new driver. > > $ cat v5-0015-reset-elbasr-Add-AMD-Pensando-Elba-SR-Reset-Contr.patch > | grep diff > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile > diff --git a/drivers/reset/reset-elbasr.c b/drivers/reset/reset-elbasr.c > diff --git a/include/dt-bindings/reset/amd,pensando-elba-reset.h > b/include/dt-bindings/reset/amd,pensando-elba-reset.h > > Yes, tested it with the following and no warnings or errors > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/amd,pensando.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/syscon.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/amd,pensando.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/syscon.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml So how this test could pass if there is no header file included in the example here? Are you sure you tested each commit separately (like it will be included in the kernel)? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel