From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3ECDD10373 for ; Wed, 26 Nov 2025 02:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4tyc09Ao125oOeQ1/2CjusJ4Ro4JNAsugQFnuIaNAdI=; b=C8BiND6tBm9kz4rOchU74GWzzQ CwcUBlFWwNLRNJZRZV3esr9GuqTzQlyBsfid0eZ+PDqNyNIbDL3P4Oe87XoBooMLkizJ7xIyUCRae C2XWKIWxI4UbygEVVBveCozBBdVZuYs5RA17rWvRgnAoVgL8M5dwZRaFbmSyibHwEdBD7gIVCNpfI QZ81n7BKZ5wHgD5U2FZ8xI5VQxK+qe7FX1YNQyyH7h+q786IDNaXXlFxTSTSobUnhMUw4J2tPSiSp dYyRwi8N4/nJDRJr9Thd7VHiBxR4AAo5NOGq9JxJLjakvkT8yfu4Khk2uJTJFPAJ5YMi+zxla9HMU bQz3jPnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vO52v-0000000EEJg-2ADT; Wed, 26 Nov 2025 02:14:17 +0000 Received: from mail-m15593.qiye.163.com ([101.71.155.93]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vO52k-0000000EE5W-1hsB; Wed, 26 Nov 2025 02:14:13 +0000 Received: from [127.0.0.1] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 2ae76c0ea; Wed, 26 Nov 2025 10:14:00 +0800 (GMT+08:00) Message-ID: Date: Wed, 26 Nov 2025 10:13:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 03/11] drm/bridge: Implement generic USB Type-C DP HPD bridge To: Heikki Krogerus Cc: Chaoyi Chen , Greg Kroah-Hartman , Dmitry Baryshkov , Peter Chen , Luca Ceresoli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org References: <20251120022343.250-1-kernel@airkyi.com> <20251120022343.250-4-kernel@airkyi.com> Content-Language: en-US From: Chaoyi Chen In-Reply-To: <20251120022343.250-4-kernel@airkyi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9abdf0668a03abkunm24c9a3ad56c93f X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQ09JTFZLGEJDTxkZSU1DSElWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpPSE xVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=Hr6YCgnGlX5GNA/vTj8sVjGPdiIhmMPdJQnyYtxbw3hg6lfKvInidLdPWbW1zoY9j4+tpGlmkTBW1hQjwb4Z9gxpa0ZXKE9DBTBWfsQ5ypJKu7ENzb9BI6KSsu6oCgf8VWCri84W3Qg1rBhVR7tf4N1nKB/LQqKafx0ZEpr82tE=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=4tyc09Ao125oOeQ1/2CjusJ4Ro4JNAsugQFnuIaNAdI=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251125_181406_663892_40F57A34 X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Heikki, On 11/20/2025 10:23 AM, Chaoyi Chen wrote: > From: Chaoyi Chen > [...] > > drivers/gpu/drm/bridge/Kconfig | 10 ++++ > drivers/gpu/drm/bridge/Makefile | 1 + > .../gpu/drm/bridge/aux-hpd-typec-dp-bridge.c | 50 +++++++++++++++++++ > 3 files changed, 61 insertions(+) > create mode 100644 drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c > > + > +static int drm_typec_bus_event(struct notifier_block *nb, > + unsigned long action, void *data) > +{ > + struct typec_altmode *alt = (struct typec_altmode *)data; > + > + if (action != TYPEC_ALTMODE_REGISTERED) > + goto done; > + > + if (is_typec_partner(&alt->dev) || alt->svid != USB_TYPEC_DP_SID) > + goto done; It should be "is_typec_partner(alt->dev.parent)". Sorry, I didn't notice this earlier. I will fix this in v11. > + > + /* > + * alt->dev.parent->parent : USB-C controller device > + * alt->dev.parent : USB-C connector device > + */ > + drm_dp_hpd_bridge_register(alt->dev.parent->parent, > + to_of_node(alt->dev.parent->fwnode)); > + > +done: > + return NOTIFY_OK; > +} > + -- Best, Chaoyi