From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48914C43334 for ; Thu, 9 Jun 2022 07:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MdB+y4PMtFysGzx5m5WyaSSJEI1pUU05YmTs2D6TW+o=; b=EMaG4oOnQ4JTR4 WAXIY88gn0uHAsYx9Q2n16iSeSYaqBbxDmOQIUBAHDvwcrlXKw5PLXL5F8BNxBviZ3lMdIh88eM5l 3xJY2csV1STN3qz9H8EGNtjTtsC4ZQDzv5zs7kmfUwqJ5iIUDWhwyycZYLhdLLtbST/d0EWf4ZKGt V/7i4bF/vjW/WANS+duqHC8uxZokJD/PaRYhRI++ZhMRIdKXzJwINLfROhELwi470f02dVv3orJar 9hyKg1UbW1/OFDCLdm0gzncuntFwCP8EbGrmZ/HHXceLl0wc0v9mHRCcE15X4zbkktAHRpBxmVUNq aTD+w3x2hZgBTsOWMtoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzCXE-00HNDK-BH; Thu, 09 Jun 2022 07:24:52 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzCX6-00HN6h-Ri; Thu, 09 Jun 2022 07:24:46 +0000 X-UUID: 3ab6f51d233e4756a1e4712a4088ba66-20220609 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:c61161a3-604e-4b6c-b154-4d2a81e98915,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:f0dc38e5-2ba2-4dc1-b6c5-11feb6c769e0,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 3ab6f51d233e4756a1e4712a4088ba66-20220609 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1341199571; Thu, 09 Jun 2022 00:24:36 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 9 Jun 2022 00:24:34 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Thu, 9 Jun 2022 15:24:33 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 9 Jun 2022 15:24:33 +0800 Message-ID: Subject: Re: [PATCH v10 18/21] drm/mediatek: Add mt8195 Embedded DisplayPort driver From: Rex-BC Chen To: CK Hu , Guillaume Ranquet , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthias Brugger , Chunfeng Yun =?UTF-8?Q?=28=E4=BA=91=E6=98=A5=E5=B3=B0=29?= , Kishon Vijay Abraham I , Vinod Koul , "Helge Deller" , Jitao Shi =?UTF-8?Q?=28=E7=9F=B3=E8=AE=B0=E6=B6=9B=29?= CC: Markus Schneider-Pargmann , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-phy@lists.infradead.org" , "linux-fbdev@vger.kernel.org" Date: Thu, 9 Jun 2022 15:24:33 +0800 In-Reply-To: <49f4f8732eb1df31b0c8a82761e1c4dad9aef106.camel@mediatek.com> References: <20220523104758.29531-1-granquet@baylibre.com> <20220523104758.29531-19-granquet@baylibre.com> <75c00caca74b8366ca2c4594a8229b6de95c5f47.camel@mediatek.com> <49f4f8732eb1df31b0c8a82761e1c4dad9aef106.camel@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220609_002444_908917_BA4B8AE7 X-CRM114-Status: GOOD ( 40.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2022-06-09 at 10:30 +0800, CK Hu wrote: > Hi, Rex: > > On Wed, 2022-06-08 at 18:26 +0800, Rex-BC Chen wrote: > > On Tue, 2022-06-07 at 15:47 +0800, CK Hu wrote: > > > Hi, Rex: > > > > > > On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote: > > > > From: Markus Schneider-Pargmann > > > > > > > > This patch adds a DisplayPort driver for the Mediatek mt8195 > > > > SoC. > > > > > > > > It supports the mt8195, the embedded DisplayPort units. It > > > > offers > > > > DisplayPort 1.4 with up to 4 lanes. > > > > > > > > The driver creates a child device for the phy. The child device > > > > will > > > > never exist without the parent being active. As they are > > > > sharing > > > > a > > > > register range, the parent passes a regmap pointer to the child > > > > so > > > > that > > > > both can work with the same register range. The phy driver sets > > > > device > > > > data that is read by the parent to get the phy device that can > > > > be > > > > used > > > > to control the phy properties. > > > > > > > > This driver is based on an initial version by > > > > Jason-JH.Lin . > > > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > > Signed-off-by: Guillaume Ranquet > > > > --- > > > > > > [snip] > > > > > > > + > > > > +static int mtk_dp_hpd_sink_event(struct mtk_dp *mtk_dp) > > > > +{ > > > > + ssize_t ret; > > > > + u8 sink_count; > > > > + bool locked; > > > > + u8 link_status[DP_LINK_STATUS_SIZE] = {}; > > > > + u32 sink_count_reg = DP_SINK_COUNT_ESI; > > > > + u32 link_status_reg = DP_LANE0_1_STATUS; > > > > + > > > > + ret = drm_dp_dpcd_readb(&mtk_dp->aux, sink_count_reg, > > > > &sink_count); > > > > + if (ret < 0) { > > > > + drm_err(mtk_dp->drm_dev, "Read sink count > > > > failed: > > > > %ld\n", ret); > > > > + return ret; > > > > + } > > > > + > > > > + ret = drm_dp_dpcd_read(&mtk_dp->aux, link_status_reg, > > > > link_status, > > > > + sizeof(link_status)); > > > > + if (!ret) { > > > > + drm_err(mtk_dp->drm_dev, "Read link status > > > > failed: > > > > %ld\n", > > > > + ret); > > > > + return ret; > > > > + } > > > > + > > > > + locked = drm_dp_channel_eq_ok(link_status, > > > > + mtk_dp- > > > > >train_info.lane_count); > > > > + if (!locked && mtk_dp->train_state > > > > > MTK_DP_TRAIN_STATE_TRAINING_PRE) > > > > > > Before enter this function, mtk_dp->train_state is set to > > > MTK_DP_TRAIN_STATE_STARTUP, so this never happen, drop this. > > > > > > > The interrupt from sink device could come any time. Why it's > > impossible? > > I still ask this question: "For eDP, when does disconnect happened?" > If > it indeed happen, I still do not like to change state here. When > disconnect, the training flow would result in fail finally and need > not > to change state here, but the training flow would block for a while > when disconnect. You could add some check point to check train_info- > > cable_plugged_in to quickly break out the training flow. > > Regards, > CK > Hello CK, This function is to handle "sink interrupt" and we need to read the status from sink device via aux channel. edp spec is just add some extension rule from dp spec, this is define in dp spec. The basic spec is still "dp", and these are all define in dp spec. Therefore, I think we should keep this. BRs, Bo-Chen > > > > > > + mtk_dp->train_state = > > > > MTK_DP_TRAIN_STATE_TRAINING_PRE; > > > > + > > > > + if (link_status[1] & DP_REMOTE_CONTROL_COMMAND_PENDING) > > > > + drm_dp_dpcd_writeb(&mtk_dp->aux, > > > > DP_DEVICE_SERVICE_IRQ_VECTOR, > > > > + DP_REMOTE_CONTROL_COMMAND_PE > > > > NDING); > > > > + > > > > + if (DP_GET_SINK_COUNT(sink_count) && > > > > + (link_status[2] & > > > > DP_DOWNSTREAM_PORT_STATUS_CHANGED)) { > > > > + mtk_dp->train_info.check_cap_count = 0; > > > > + mtk_dp->train_state = > > > > MTK_DP_TRAIN_STATE_CHECKEDID; > > > > > > Why change state from MTK_DP_TRAIN_STATE_STARTUP to > > > MTK_DP_TRAIN_STATE_CHECKEDID? In mtk_dp_train_handler(), > > > mtk_dp_parse_capabilities() is true then change to > > > MTK_DP_TRAIN_STATE_CHECKEDID. Give a reason why these two are > > > different. > > > > > > Regards, > > > CK > > > > > > > I will drop this and drop state of MTK_DP_TRAIN_STATE_CHECKEDID. > > MTK_DP_TRAIN_STATE_CHECKEDID is only used for audio. > > We can check enable status in another place. > > > > BRs, > > Bo-Chen > > > > > > + msleep(20); > > > > + } > > > > + > > > > + return 0; > > > > +} > > > > + > > > > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel