From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 213E2EB64DA for ; Fri, 16 Jun 2023 19:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LKggk/NETckEBVVG3TyQjWbSpYSuC1aSLDboScQpVxM=; b=rdrBhoITrPYkV0 HlhMORRjQS/hzEXnLtfmZLtsR/0g4RrcFcSUL5Zm5Gee19yCvOxYi9lHBh5SUDQhpOJfYxn1SwEN6 +aL1sHnRobFHKAj3fOOPMYh27IbZJcYaG/PT91F8m18DROcxrAB7+pnE3pSdDmDyB/GdEXDT/g6Hn q91ZvPYBCfrrYWtZLPKmDjeCnN/FaBd/uZWYJ10f3iW0dqKcMrqKlgoEO5RydP8CgFizYIpkujkHH wMZDMXlS/VazaFWWSq1QPUy45FaFMoEf4NTE/ATNVOcEBDsm4Kccbnfebzn8jUtkwuq6P/WaCQMrU v3L1UKu0vFOadB+yYzPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qAF0k-001dEj-19; Fri, 16 Jun 2023 19:21:30 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qAF0i-001dDh-1u; Fri, 16 Jun 2023 19:21:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0068E60F9C; Fri, 16 Jun 2023 19:21:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54189C433C9; Fri, 16 Jun 2023 19:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686943287; bh=KNB1fklmcJeWJr9EZzOH1XKReRXdb2jMbZAPeqc4wB4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=uNVW9km0F4Grt39DBa/dNvvZ5gzp45V1z5yl/Q2Gs3UYsMvNMEod0j0IYmu4h5Ox5 IV0KwFZoJgLZtTYRf+uMZje/AgzkAwUAVyjUZPGUQmrzZ7ZIIBLO0qC5JJDTH4ffgU uSLXJyNMbpg63t9dSxKpo3u1d5r/WaAqWZ0M2U1LNJUorpTaRRFA3Il6JVNr+HZO2U BUePMoamTlgydhy/hZLYCbw3ojCuIj7lQgsgWC/NW0yRli1aDWt5o3Qz0EB26PwoWt vgHwFyy+v3jXM2SnGHIvLSENe6sohX2LE9mee3W2+dpix3xlt0jxw/the9/yaYMjBs 9ebausqYwtHFQ== Message-ID: MIME-Version: 1.0 In-Reply-To: <20230615122051.546985-3-angelogioacchino.delregno@collabora.com> References: <20230615122051.546985-1-angelogioacchino.delregno@collabora.com> <20230615122051.546985-3-angelogioacchino.delregno@collabora.com> Subject: Re: [PATCH 2/3] clk: mediatek: clk-mt8173-apmixedsys: Fix return value for of_iomap() error From: Stephen Boyd Cc: mturquette@baylibre.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, wenst@chromium.org, u.kleine-koenig@pengutronix.de, msp@baylibre.com, miles.chen@mediatek.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com To: AngeloGioacchino Del Regno Date: Fri, 16 Jun 2023 12:21:25 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_122128_664971_DF2B478E X-CRM114-Status: UNSURE ( 7.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting AngeloGioacchino Del Regno (2023-06-15 05:20:50) > The of_iomap() function returns NULL in case of error so usage of > PTR_ERR() is wrong! > Change that to return -ENOMEM in case of failure. > > Fixes: 41138fbf876c ("clk: mediatek: mt8173: Migrate to platform driver and common probe") > Signed-off-by: AngeloGioacchino Del Regno > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel