From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88161CDB475 for ; Mon, 22 Jun 2026 08:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FAbpiNhKVqoEfhFmUfUdlxgESW8QuGiY+lhl+lA+T60=; b=xQNUf9o5ek/mLcVU1yQkcEFxzf mUDNb0vKPjIBb+8UHCmlPDnUkcSusuk1Hj+NOSJ+35fT+LIX8cFzh/2yha5u9tfoBM43uiXO2rCTO CVpvbJqOg6xLTzpd1/NZhhMnHgo1ni1cWQaNedR3c1MCthh9PpLog0ouTwIBTbgYStzmyFTtzT0XE 5Jx8Wt6nQT9Pe5RXGE+wYxaJVmVa1O6sMXyQmIC6r8JMrlDrbYd+0K0DKn4IKkKDydVKGA+fhvJMJ 0bFQTdZdYZlMIqk4h7e2mMVogFKZVG04WopumXFBeMUvHPH2TNBDz27lQRxLOXXaJjXc/i6a1xgpP XGB3Alhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wbZek-00000004bX3-0vt1; Mon, 22 Jun 2026 08:05:22 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wbZej-00000004bVX-1ZFk for linux-arm-kernel@lists.infradead.org; Mon, 22 Jun 2026 08:05:21 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1913F6001A; Mon, 22 Jun 2026 08:05:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B84C1F000E9; Mon, 22 Jun 2026 08:05:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782115519; bh=FAbpiNhKVqoEfhFmUfUdlxgESW8QuGiY+lhl+lA+T60=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=WKhiDDUdL0KRgYXfe2WI9TPD1Fcz4Jm9ZEs4TCvppOjXgUFC4H1afMQFw+2v6sbYC wyKQOW94sIC2JrNxh5T1XMUYBWAlDKC18spHzcXcYSeSIENbdvnOdBeIFeCRHU0wcr GXhaSILwuzYrxIUKMomqoVtJ32rfzWA7jVghDLmfnz+BZrvg16SiSZpHTKMbep/4WK cTRFBl6B2TwAUd1X5OjJrSj8wdRtwPxWGGAsp+lGM7jfcHoi8eTosbKCizRmGWHd0+ cQFh5OCUybibOIb31BzksIWMYD20OkhiGIxmv8Z+opVm7KScIv+rhlWvQYzzdL9N23 S4BwD770Utgzw== Message-ID: Date: Mon, 22 Jun 2026 10:05:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] tracing: Move trace_printk.h out of kernel.h To: Steven Rostedt , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Linus Torvalds , Sebastian Andrzej Siewior , John Ogness , Thomas Gleixner , Peter Zijlstra , Julia Lawall , Yury Norov , linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org References: <20260621093430.264983361@kernel.org> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260621093430.264983361@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le 21/06/2026 à 11:34, Steven Rostedt a écrit : > There's been complaints about trace_printk() being defined in kernel.h as it > can increase the compilation time. As it is only used by some developers for > debugging purposes, it should not be in kernel.h causing lots of wasted CPU > cycles for those that do not ever care about it. Do we have a measurement of the increased compilation time ? Christophe > > Instead, add a CONFIG_TRACE_PRINTK_DEBUGGING option that developers that do > use it can set and not have to always remember to add #include > to the files they add trace_printk() while debugging. It also means that > those that do not have that config set will not have to worry about wasted > CPU cycles as it is only include in the CFLAGS when the option is set, and > its completely ignored otherwise. > > Steven Rostedt (2): > tracing: Move non-trace_printk prototypes back to kernel.h > tracing: Add CONFIG_TRACE_PRINTK_DEBUGGING to clean up kernel.h > > ---- > .../driver_development_debugging_guide.rst | 2 +- > Makefile | 5 +++++ > arch/powerpc/kvm/book3s_xics.c | 1 + > drivers/gpu/drm/i915/gt/intel_gtt.h | 1 + > drivers/gpu/drm/i915/i915_gem.h | 1 + > drivers/hwtracing/stm/dummy_stm.c | 4 ++++ > drivers/infiniband/hw/hfi1/trace_dbg.h | 1 + > drivers/usb/early/xhci-dbc.c | 1 + > fs/ext4/inline.c | 1 + > include/linux/kernel.h | 19 ++++++++++++++++++- > include/linux/sunrpc/debug.h | 1 + > include/linux/trace_printk.h | 22 +++------------------- > kernel/trace/Kconfig | 10 ++++++++++ > kernel/trace/ring_buffer_benchmark.c | 1 + > kernel/trace/trace.h | 1 + > samples/fprobe/fprobe_example.c | 1 + > samples/ftrace/ftrace-direct-modify.c | 1 + > samples/ftrace/ftrace-direct-multi-modify.c | 1 + > samples/ftrace/ftrace-direct-multi.c | 2 +- > samples/ftrace/ftrace-direct-too.c | 2 +- > samples/ftrace/ftrace-direct.c | 2 +- > 21 files changed, 56 insertions(+), 24 deletions(-) >