From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C87C43381 for ; Mon, 25 Mar 2019 16:18:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEF0120828 for ; Mon, 25 Mar 2019 16:18:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FOBYnnsH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEF0120828 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v4JLn4zyNKRvkepB2h08/CJUbuRg5KmfQhIf+OkEUwY=; b=FOBYnnsHgxomf5 PEsKE+RKv88FPKMAtX5B+GNCW/SjiQcU16+ANj7Lyw0wYljYNs2TlVj2A+iP7+sFyf+uWZl6uN9rD YxLvjJU+OzFXSlII0rzgH18nUjXkci82Vp5Eaky+ICE0REQ34SjJ0PNNhwHlvGOMKvTCwMBS9o089 /RE0orWwB4tGRYOBFnvBiUKHaVx0yNQUJjQTpFgzZOZFOHJKUn2BvrK3BO0Xb/ie2WoSwCHUJVSPb CJKvI3nnwa5BVNFpg4CrqcFiXnCZoMPDC086DL/+mK2dPEoCiD6T+moefkBD6l27HhKQR7/0Jp9af oNhxoHy9fGyzgfVzaqWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8SIZ-0004Nh-At; Mon, 25 Mar 2019 16:18:07 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8SIU-0004NL-7O for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2019 16:18:05 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2PGH3Vo000343; Mon, 25 Mar 2019 17:17:53 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2rddht4rpe-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 25 Mar 2019 17:17:53 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2CC7831; Mon, 25 Mar 2019 16:17:53 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 07394E7D; Mon, 25 Mar 2019 16:17:53 +0000 (GMT) Received: from [10.48.1.93] (10.75.127.47) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 25 Mar 2019 17:17:51 +0100 Subject: Re: [PATCH v1] Revert "dmaengine: stm32-mdma: Add a check on read_u32_array" To: Vinod Koul References: <1553525187-13533-1-git-send-email-pierre-yves.mordret@st.com> <20190325152552.GQ5348@vkoul-mobl> From: Pierre Yves MORDRET Message-ID: Date: Mon, 25 Mar 2019 17:17:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190325152552.GQ5348@vkoul-mobl> Content-Language: en-US X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG5NODE1.st.com (10.75.127.13) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-25_09:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_091802_553505_581737EF X-CRM114-Status: GOOD ( 15.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , linux-kernel@vger.kernel.org, Maxime Coquelin , dmaengine@vger.kernel.org, Dan Williams , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/25/19 4:25 PM, Vinod Koul wrote: > On 25-03-19, 15:46, Pierre-Yves MORDRET wrote: > > Please use the right subsystem name dmaengine, revert is not a subsystem > name! ok. sorry. I thought revert keyword was correct. > >> This reverts commit 906b40b246b0acb54c4dc97e815cf734761c9820. > > This should use the cannonical form for commits commit-sha1: ("title....") ok. >> >> As stated by bindings "st,ahb-addr-masks" is optional. >> The statement inserted by this commit makes this property >> mandatory and prevents MDMA to be probed in case property not present. >> >> Signed-off-by: Pierre-Yves MORDRET >> --- >> drivers/dma/stm32-mdma.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c >> index 4e0eede..ac0301b 100644 >> --- a/drivers/dma/stm32-mdma.c >> +++ b/drivers/dma/stm32-mdma.c >> @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev) >> >> dmadev->nr_channels = nr_channels; >> dmadev->nr_requests = nr_requests; >> - ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", >> + device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", >> dmadev->ahb_addr_masks, >> count); >> - if (ret) >> - return ret; >> dmadev->nr_ahb_addr_masks = count; > > so if st,ahb-addr-masks is not present what value does count contain? whether "st,ahb-addr-masks" present count will hold the number of mask. otherwise sets to "0" by driver. count = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", NULL, 0); if (count < 0) count = 0; > >> >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> -- >> 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel