From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1A94C3DA49 for ; Tue, 23 Jul 2024 08:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B9ZKbEKyzpmJy5L4s8/DgGAvSyGuTIEA/auCZAkq7tc=; b=aUarmaOH7qs/umWrncBvJ8n3Vu shbF7g5hob1uvOk/qdrSK0/o6IpokSr0xwnjNF0Z8LYATG3rFv3osbca9gv0pD4//OmsWHOV4Tgj5 UwfnJNvfrWXIypzMVEiYG49oFzsEiIxIykai4L0FQIHHPck+4Goiw5RGlZ5g49Ad6f5MqRCbzHLpz xJqg/8nCSjcYVLN+9aFKymh4GGILa4SO5jrZTmfghKDENqTVhMRQExLEKMTh11NgbSNsyc3Ve0A6J /IGkBMwJlCcfKJlg1Crm5bBHL6LMr19eaPR7ToAprP4xCWPBC1aHrQoTa2pfshScmXSQJBU82Iqrq CBq8wMNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWAro-0000000BqgU-1ioa; Tue, 23 Jul 2024 08:27:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWArR-0000000BqZs-0cDK for linux-arm-kernel@lists.infradead.org; Tue, 23 Jul 2024 08:27:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C319139F; Tue, 23 Jul 2024 01:27:28 -0700 (PDT) Received: from [10.1.37.20] (PF4Q20KV.arm.com [10.1.37.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C64503F766; Tue, 23 Jul 2024 01:26:59 -0700 (PDT) Message-ID: Date: Tue, 23 Jul 2024 09:26:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V9 06/13] perf tools: Enable evsel__is_aux_event() to work for S390_CPUMSF To: Adrian Hunter , Peter Zijlstra Cc: Ingo Molnar , Mark Rutland , Alexander Shishkin , Heiko Carstens , Thomas Richter , Hendrik Brueckner , Suzuki K Poulose , Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Yicong Yang , Jonathan Cameron , Will Deacon , Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Ian Rogers , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org References: <20240715160712.127117-1-adrian.hunter@intel.com> <20240715160712.127117-7-adrian.hunter@intel.com> Content-Language: en-US From: Leo Yan In-Reply-To: <20240715160712.127117-7-adrian.hunter@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240723_012705_469327_ABDA8DDF X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/15/2024 5:07 PM, Adrian Hunter wrote: > > evsel__is_aux_event() identifies AUX area tracing selected events. > > S390_CPUMSF uses a raw event type (PERF_TYPE_RAW - refer > s390_cpumsf_evsel_is_auxtrace()) not a PMU type value that could be checked > in evsel__is_aux_event(). However it sets needs_auxtrace_mmap (refer > auxtrace_record__init()), so check that first. > > Currently, the features that use evsel__is_aux_event() are used only by > Intel PT, but that may change in the future. > > Signed-off-by: Adrian Hunter > Acked-by: Ian Rogers > Reviewed-by: Andi Kleen Reviewed-by: Leo Yan > --- > tools/perf/util/pmu.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > index 986166bc7c78..0b38c51bd6eb 100644 > --- a/tools/perf/util/pmu.c > +++ b/tools/perf/util/pmu.c > @@ -1199,8 +1199,12 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu *pmu) > > bool evsel__is_aux_event(const struct evsel *evsel) > { > - struct perf_pmu *pmu = evsel__find_pmu(evsel); > + struct perf_pmu *pmu; > > + if (evsel->needs_auxtrace_mmap) > + return true; > + > + pmu = evsel__find_pmu(evsel); > return pmu && pmu->auxtrace; > } > > -- > 2.34.1 > >