From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D7C0C433DB for ; Fri, 26 Mar 2021 11:01:53 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B94D161A0F for ; Fri, 26 Mar 2021 11:01:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B94D161A0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XFln/Zp6Cucxoln6vqtOe5R3iSQovR9/2X95K2TDju8=; b=XkixgXChQ4n0X4BX+Mv5xoUGc /2UFsMTIikn7e4NeXXStVyUYt9t9g1T6nMyQtOoHLRF0pAfLgsqZ9sW2gigrfrhtD+ruz9N4ZkNF2 kCEXyOJnzpRe+M5GHLDk50jy4i68XjFFDz2wbbOx3VnhqvGG3X/yFbDtOfiUsikWAzg9qZjRXr5q4 OAQFyIdAWmgTEQJi68x3Ev7FU+j06G8rTSRz06q9ZD1NzLf6X/qmdX6i6fZUuc9CCZKMMxYK754/E zcK2Q2S5WuDR57x5DRZL3Q1hEGxHJ4j2ZjbD7Ol9wLHUHRGqQlkGCqsuXDCQXJ6v1cITn/gMCsi78 OXw9w3WuQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPkCL-003MvS-87; Fri, 26 Mar 2021 11:00:13 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPkCC-003MtO-65 for linux-arm-kernel@lists.infradead.org; Fri, 26 Mar 2021 11:00:09 +0000 Received: from fraeml743-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4F6Jfy0T8rz680jb; Fri, 26 Mar 2021 18:51:06 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml743-chm.china.huawei.com (10.206.15.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 26 Mar 2021 11:59:58 +0100 Received: from [10.210.170.125] (10.210.170.125) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 26 Mar 2021 10:59:57 +0000 Subject: Re: [PATCH v2 0/6] perf arm64 metricgroup support To: "Paul A. Clarke" CC: , , , , , , , , , , , , , , , , References: <1616668398-144648-1-git-send-email-john.garry@huawei.com> <20210325203944.GD8931@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> From: John Garry Message-ID: Date: Fri, 26 Mar 2021 10:57:40 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20210325203944.GD8931@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> Content-Language: en-US X-Originating-IP: [10.210.170.125] X-ClientProxiedBy: lhreml721-chm.china.huawei.com (10.201.108.72) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_110006_065165_9B4C23B6 X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/03/2021 20:39, Paul A. Clarke wrote: > On Thu, Mar 25, 2021 at 06:33:12PM +0800, John Garry wrote: >> Metric reuse support is added for pmu-events parse metric testcase. >> This had been broken on power9 recentlty: >> https://lore.kernel.org/lkml/20210324015418.GC8931@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com/ > > Much better. Before: > -- > $ perf test -v 10 2>&1 | grep -i error | wc -l > 112 > -- > After: > -- > $ perf test -v 10 2>&1 | grep -i error | wc -l > 17 > -- > > And these seem like different types of issues: > -- > $ perf test -v 10 2>&1 | grep -i error > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_powerbus0_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > -- > This looks suspicious. Firstly, does /sys/bus/event_source/devices/nest_mcs01_imc (or others, above) exist on your system? I guess not. Secondly, checking Documentation/powerpc/imc.rst, we have examples of: nest_mcs01/PM_MCS01_64B_R... So is the PMU name correct in the metric file for nest_mcs01_imc? Looking at the kernel driver file, arch/powerpc/perf/imc-pmu.c, it seems to be correct. Not sure. Thanks, John > (Added Kajol Jain to CC) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel