From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D917C2BA1A for ; Tue, 18 Jun 2024 12:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yaKJZwFY6wd1XllaZI8jJVrOqSqeE2cUrM2G+oq1sR8=; b=POm+sVsdP1STAYjDfM3zpsthZC 671RzT8HEJIrzfIxHr7pwHy3Q+sgDmcVUUUvimlJqbD6R5HrWmqMoPMICzoEhXm90zx0V3DqfAaKy qBfb4xdwQ9vgnW3dPAw/kF/KKQOs13Okp76RzT+Nu6oymEg9CGG7e3cRjZBd69lTdkjoW5ChcRyqS r7bTHVwUiZKonc5AlA2+Ah2STHrZHF/LOfpHcWIQrcOhhNJeKPG5VarrO37r0adCjMsqnz8Uj9Pgv kj3tu7m5QglsTWepIqYO60IGJrYEV10z7N7wW1y6FvzzOyQoExN0zC+ivJPUi61Z52D6NBLiayp1e MtN1w33Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJXdl-0000000EnOV-0Jfk; Tue, 18 Jun 2024 12:08:45 +0000 Received: from out-180.mta0.migadu.com ([2001:41d0:1004:224b::b4]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJXdh-0000000EnLP-3R5x for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2024 12:08:44 +0000 X-Envelope-To: angelogioacchino.delregno@collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718712516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yaKJZwFY6wd1XllaZI8jJVrOqSqeE2cUrM2G+oq1sR8=; b=j/rTMOoDPWYTSlPp2VdJOuT37Q5uAFN8Tsg2EsV4sQIiUaqK5GIq+iAvEYNMRfLEBFuDbP LlqVT/U0m+nFky/pdYKC+SbgxAKwWl3f41XmPGY67FTxWMB4Lu+6+7yUqjrK8WTXY4OUj3 UpgZf3YfifUlrEGqe1S6OLCQ/0McQeM= X-Envelope-To: chunkuang.hu@kernel.org X-Envelope-To: robh@kernel.org X-Envelope-To: krzysztof.kozlowski+dt@linaro.org X-Envelope-To: conor+dt@kernel.org X-Envelope-To: p.zabel@pengutronix.de X-Envelope-To: airlied@gmail.com X-Envelope-To: daniel@ffwll.ch X-Envelope-To: maarten.lankhorst@linux.intel.com X-Envelope-To: mripard@kernel.org X-Envelope-To: tzimmermann@suse.de X-Envelope-To: matthias.bgg@gmail.com X-Envelope-To: shawn.sung@mediatek.com X-Envelope-To: yu-chang.lee@mediatek.com X-Envelope-To: ck.hu@mediatek.com X-Envelope-To: jitao.shi@mediatek.com X-Envelope-To: devicetree@vger.kernel.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: dri-devel@lists.freedesktop.org X-Envelope-To: linux-mediatek@lists.infradead.org X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: wenst@chromium.org X-Envelope-To: kernel@collabora.com X-Envelope-To: michael@walle.cc X-Envelope-To: amergnat@baylibre.com Message-ID: Date: Tue, 18 Jun 2024 20:08:25 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v8 3/3] drm/mediatek: Implement OF graphs support for display paths To: AngeloGioacchino Del Regno , chunkuang.hu@kernel.org Cc: robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, matthias.bgg@gmail.com, shawn.sung@mediatek.com, yu-chang.lee@mediatek.com, ck.hu@mediatek.com, jitao.shi@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, wenst@chromium.org, kernel@collabora.com, michael@walle.cc, Alexandre Mergnat References: <20240618101726.110416-1-angelogioacchino.delregno@collabora.com> <20240618101726.110416-4-angelogioacchino.delregno@collabora.com> Content-Language: en-US, en-AU X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: <20240618101726.110416-4-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240618_050842_431136_285012A2 X-CRM114-Status: GOOD ( 12.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 6/18/24 18:17, AngeloGioacchino Del Regno wrote: > It is impossible to add each and every possible DDP path combination > for each and every possible combination of SoC and board: right now, > this driver hardcodes configuration for 10 SoCs and this is going to > grow larger and larger, and with new hacks like the introduction of > mtk_drm_route which is anyway not enough for all final routes as the > DSI cannot be connected to MERGE if it's not a dual-DSI, or enabling > DSC preventively doesn't work if the display doesn't support it, or > others. > > Since practically all display IPs in MediaTek SoCs support being > interconnected with different instances of other, or the same, IPs > or with different IPs and in different combinations, the final DDP > pipeline is effectively a board specific configuration. > > Implement OF graphs support to the mediatek-drm drivers, allowing to > stop hardcoding the paths, and preventing this driver to get a huge > amount of arrays for each board and SoC combination, also paving the > way to share the same mtk_mmsys_driver_data between multiple SoCs, > making it more straightforward to add support for new chips. > > Reviewed-by: Alexandre Mergnat > Tested-by: Alexandre Mergnat > Signed-off-by: AngeloGioacchino Del Regno Acked-by: Sui Jingfeng