From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC87CC61DA4 for ; Fri, 3 Feb 2023 03:28:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8ZCE/UOkWF7EvyQMjVNSVFVzWd+siN7KoF01ks9gGSM=; b=DZE8NoyCufgCGt CUP6vB7vxY3seNmhMVuUc+EvPAmSGDhJceNHK6jNWKCf9gqyVKHf5PTEBGxDqITN9kagkLI2+YgAf YoSC0WjyTV3e6OGRAfDBUXjWKJHndkqrRHdUyQUSzRJwsXUKDZieHnubYiQSgvB867KX3kGY3Qjp0 +kTBA1JUgugp8pYEtUiO6GiKV4+M6kvJN0Pq6H3ThESXjmlcfsKvdA7aEEYQa9cNHguwWI6NlltuQ osE0mi7hDd+VdZtRba9ssfxgAzRlUW3BFu0P85utqNSB5l8R47Oj0GabRKQ3yj27GMPCGlDDOxq5v xUguBpv7gNOSd+a112TA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNmjr-000AMT-E7; Fri, 03 Feb 2023 03:27:47 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNmjo-000ALb-8Z; Fri, 03 Feb 2023 03:27:46 +0000 X-UUID: b339581aa37211eda08d4d6090ec5a5c-20230202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=Jk8IynAdWUJxh3lugzXgEEeoFifSdjyRkWMBaUoSdWE=; b=aBZI66QtFPgb7oiQebPhQZ+HyZ+zh+L+vIWIeQhsxg6YyJhHoJcoP3RqWeVIh6dk2sDiKBbAlLfBLM4IX0VxXbJaSwT1foFk+C85GEj9DRFRgjkl0F5kEHNmGnSmZ0Ew3APhFnNwPYlZ5dJdALXc6CJA2ikMXxlTO9pUA33c4+I=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.18,REQID:7d1e8df0-865d-4b1a-a1e8-13b898890502,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:3ca2d6b,CLOUDID:3e5d53f7-ff42-4fb0-b929-626456a83c14,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0 X-CID-BVR: 0 X-UUID: b339581aa37211eda08d4d6090ec5a5c-20230202 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1496772024; Thu, 02 Feb 2023 20:27:34 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 3 Feb 2023 11:27:32 +0800 Received: from APC01-SG2-obe.outbound.protection.outlook.com (172.21.101.239) by mtkmbs10n1.mediatek.com (172.21.101.34) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 3 Feb 2023 11:27:32 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lH5Ds4RD9w/qWRCrcFbyKqqgw+vwkXyTJtc2WwNznpB4/OLjxhj4NOcng94PrJ66ODGGpt8PnXyDhXxnUmZJ0NG9fe6VgzKskkfezzyQFLTlKvmJYE+yiWPhogTgdkRLOe4oeR7aVyUnt05RZ9eHcUvikf9Y/w+42EEh3MC2AX1tx22eNZaHE46/whdQqlJPP4cZrobpTmWVCSWvK95AyuNMpwf/N6goInD65+Ccta4q0P4ptLfYdxOG1o5QbYoP9pY+oFUnCLJ7IpmKOh03vdW+bznYdDMlBVXPuKOoLT4IygECsTkuP0RLzGX1bmEb92VMvwDOWcMyD+lS/r/jQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jk8IynAdWUJxh3lugzXgEEeoFifSdjyRkWMBaUoSdWE=; b=ndkdM7MQb0c1NI2Rhx4Z+KGRMV27odke5uYBjMpwHz7NBK8mTV0IJ4BZ6snjg+UAe5JafU0ulSZm7kSkHA19UvZRqaqz769ikOVSi4MvAIGPgE0EwsIIQYcxPO6xOxn/c+hWBzbVpe5RyPUJd0iQIfO1F/4WXe4kEkZG4eYZmHVHG81bTcXkdqZdwXqYHvuFVJZZUlarY1VkB8j3/Nwg6buLwgo1trYYynJf5XEJnPh193giy3Xq5JO5r2hDlhuIcEfEwRN11kL19hYw2v0hBCLmcB/OEauMDPF62kcm/3cLCe/zTPJ+z5+o1vk1W0KdrtpNcFHJD8jybj04g9nlzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jk8IynAdWUJxh3lugzXgEEeoFifSdjyRkWMBaUoSdWE=; b=E+RkAOgPRGucbVFicqvPnos39yQen3NLnN8ibPa3G/Lp+rP3ndlWf+UvW0agy6rVJ9+PXidPDZjbBEacwHVTMpbH/+QWx/xckvFd/DaR14PIMZVC6Xhq5u2+h4TBKBR+ktq4lHPdyVTNQd5dnvsca5aRoIQB9t5NPVs3vNq3tc4= Received: from TYZPR03MB6021.apcprd03.prod.outlook.com (2603:1096:400:128::9) by KL1PR03MB5889.apcprd03.prod.outlook.com (2603:1096:820:93::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.28; Fri, 3 Feb 2023 03:27:30 +0000 Received: from TYZPR03MB6021.apcprd03.prod.outlook.com ([fe80::bf9d:c68b:dc9:3943]) by TYZPR03MB6021.apcprd03.prod.outlook.com ([fe80::bf9d:c68b:dc9:3943%6]) with mapi id 15.20.6064.027; Fri, 3 Feb 2023 03:27:29 +0000 From: =?utf-8?B?SmlhbiBZYW5nICjmnajmiKwp?= To: "helgaas@kernel.org" CC: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , =?utf-8?B?SmlleXkgWWFuZyAo5p2o5rSBKQ==?= , "devicetree@vger.kernel.org" , =?utf-8?B?Q2h1YW5qaWEgTGl1ICjmn7PkvKDlmIkp?= , =?utf-8?B?UWl6aG9uZyBDaGVuZyAo56iL5ZWf5b+gKQ==?= , Project_Global_Chrome_Upstream_Group , "robh@kernel.org" , "kw@linux.com" , "linux-arm-kernel@lists.infradead.org" , =?utf-8?B?Smlhbmp1biBXYW5nICjnjovlu7rlhpsp?= , "matthias.bgg@gmail.com" , "bhelgaas@google.com" , "lpieralisi@kernel.org" , "linux-pci@vger.kernel.org" , Ryder Lee , =?utf-8?B?RGF2aWQtWUggQ2hpdSAo6YKx6Yi657+UKQ==?= , =?utf-8?B?UmV4LUJDIENoZW4gKOmZs+afj+i+sCk=?= Subject: Re: [PATCH 1/2] PCI: mediatek-gen3: Add power and reset control feature for downstream component Thread-Topic: [PATCH 1/2] PCI: mediatek-gen3: Add power and reset control feature for downstream component Thread-Index: AQHZJWynh9pQotR/nESPofZxg5t/dq6ZyUCAgCLqyYA= Date: Fri, 3 Feb 2023 03:27:29 +0000 Message-ID: References: <20230111221419.GA1710905@bhelgaas> In-Reply-To: <20230111221419.GA1710905@bhelgaas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6021:EE_|KL1PR03MB5889:EE_ x-ms-office365-filtering-correlation-id: 055698a4-a67d-4e6d-ab62-08db05969491 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wvxjpuVaEHfNqeSFimxlemWIOHhSMd+nR22rMv2wtlfxOr9jweWVcwkVbf4Ll7l672+R/lVyZ3oAfPmE7xkMEl2m+cJ3pEm5m+fbeEDUW1ET5PFcRy/YWP5AJVJGWgq6kGcWIRdj/YCGUmfI/Fmjufg/+8nbQUNbA/p1koLexj4UNDxI8jFcmOqsfCvXb/4UztsdZrlPbXkq2okA33UIDkisr+7SpWhm/tdBhQDJuCLS2GSO3HbVYqpGojwIsp4zH7e1p8dCNieHq6bcQkWEmSjd26nK4iotZdMFVE5uuDiOls0WBsQbd+u2rO5gg8xqcIBrcRCMlZ4Run0sK8lARDstnsl2lcsQ4He2Qkh+FN+/em7A9Ar4C8ku9dZ9VYZy9NljL5a3rMWpO5fiUZKrTjFs8ersAJBtXHw752Kafx/uoo14YmSewsQtpuRSdoJiZAnVAiEOM1X/SUJUAF7ER8bgXee3b9hcAwVcGgOhckH3Xs314J87AD6IaR3bbN+h35mknZk7Xan+NIcR7/Ki8sPkcsUADxB/QqcAzQGTGZlaMfgE+nrduyjbs/EAtt5qkU8znbMeDJHujfD+lDJuy8SvEpG6nmtZv64cZtCNmvOuptV2R1WJaZ5W02FTlJEUuzbyDUPG/OFElIpvcMTk4EuhuQbj1XLixsUePoI/BFwz/27Vm7NfaO8Lzj0MSM9cqkO//gwyz8WCe6eEJ3uBBA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6021.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(39860400002)(366004)(376002)(396003)(451199018)(316002)(83380400001)(71200400001)(54906003)(107886003)(2616005)(36756003)(85182001)(2906002)(38100700002)(122000001)(6506007)(64756008)(66476007)(66446008)(76116006)(66556008)(66946007)(26005)(6486002)(186003)(6512007)(4326008)(478600001)(6916009)(41300700001)(8936002)(86362001)(8676002)(38070700005)(5660300002)(7416002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?M0k5dm14L2d2MzgycHZrSEZRcUQ1S21zQkg4Sm94cndQN0NUTjArVnlpUGNR?= =?utf-8?B?ckFRY3h6cFRyRHBlZWFsSU5jcklUZU1HV3hKcktuOURmSWdWUGJlWjRoRjMv?= =?utf-8?B?aW42VHhQb2ZBbjRpaHVOMXZYUWdnNzUrczVOVWJjNTB2Nm4wYjZhaURTcisw?= =?utf-8?B?VDFYd3FTbzJIUFhadml3UzJzaDNPenBqNStYRWFWVTJMYysxTTFkOGREQlJN?= =?utf-8?B?dzAzVnJWaVNCeGpwRDlpRnAvbGdjTXJwQnlJRWQ5NGJjb1JxVllLWlZMMjBt?= =?utf-8?B?bDgzV1MrZTVUUi9vNEkrYVBHNERidW1oNnRhSHkvcHdTTlVyNURBc21ESXpr?= =?utf-8?B?NEthY1BGZEFmMkt4NURZMkhCMERsM1BMTUxjSnFDN2dHRHFmNzJTU2dlb2o5?= =?utf-8?B?eGhKakprUHFxaVVNUzNpMy9MRURDc09jMFNyb1JyS1NzM0RQVWQ1WkplRDNx?= =?utf-8?B?QjExSVE2cGlYSXJhZjBuMktsNVZqanR3eFVkV1l4bDVhNHFDM3dUY2czS1Bl?= =?utf-8?B?SjJwWTd0ditmNFFqQWVHVEtIQndrU09NdGsvTU5XQWEvd1lnM2E0bldqZjRw?= =?utf-8?B?eWRtK0poSjAwaEUvcmNIVTJFcFo2bTA1c0RUeVZsWUw0U2VoejdIcGhBeHY4?= =?utf-8?B?M05Yd00wczUyT2tSWkJTNGZYYXlzcGRwOElVS3V0RFF6MTRBY1hhT2FYOHNL?= =?utf-8?B?WnNLTUQ1RDZGc3B5d2Q3Rm9KK1NrdVMveFMxamxmMTc3N0NUU2tGbXlUVHI2?= =?utf-8?B?azBBS3RScW5VdktsSzZmaEt5dzQxblN4VHdDYkZGTzZNbjZ3cDRvMDNDUlNO?= =?utf-8?B?ZEs4U1liZWREU2pMbEZ0b2JSOWVqNExHb1AwOGRxSXRVSmc2WUJaK3BUa1Rz?= =?utf-8?B?N2hGbS9ZcXU2Wk9FS2JGZ0xXMlo4TUNzL2dYbmhIYnk5Zy9QcmpidHJlQTRq?= =?utf-8?B?RnBidFNpN1VPM2ZSUkpYOEs3L0xndWNXOXR1SjU2L1ZkZ2NrTnZENXBhUlJj?= =?utf-8?B?VC9QUjczbUoyaHhmNEVxMjlod25TNVZBY2hVTm03cnRYdVhreU41RVlUYTUr?= =?utf-8?B?VFJVM0pGNE1EWVo3YlVYWW0xUjZvTmV2V0tnbGhHdXFxaEN5MjlrQ3dnZ1ps?= =?utf-8?B?ZHlvZ0d0cFlqKzRLcGN5STN0V1R3eEhNMmREM0ZFck1BT1JZemxkRE5ZSzJx?= =?utf-8?B?RmphWHBSZUJJci9jZTVRQStHblo3aFkveENQL2dSOHp0eVVvUlVTYkowVmIy?= =?utf-8?B?OWZZK3RDZWx2ejdLK1BlTTdkMDhTYndFU2lVM1lUaUhTclRFUmUreE1rbVZa?= =?utf-8?B?ZFVVa2hoZ3pUZFV4Z1hmcmFPZ3FNYlpqYWR0QlVUOWJZYXo4ME9vOE92T2l1?= =?utf-8?B?TzY4WmZCdkZkWG01cTFqRHFyVGY2U2FVMm0yTy81Sk5wbDZtUGZEWDdoTFlx?= =?utf-8?B?YXpwMGNCR0VtSFEyWkxwd2VFM3ZsSkxGZG9Lam11NkVHVHdIK3E4OGZPUHYz?= =?utf-8?B?Z3BKc2ZoTTlublB1WlV5MmY5TXFseVBYczcyV3hncEhBRkJTZDFHdzNUN3Q1?= =?utf-8?B?TERuUCtZS1hNcTAwTTcvbGFRRDU3YU9jSzdRMEYxRGVnSVlPUVdRV2lqMTZu?= =?utf-8?B?cmVWRXltNFZ6bWp2ckQ4aTVkQjhOaEx4NmE2ZXlHNmEzNGQ1dzRIeE9PNTg3?= =?utf-8?B?YlhWNHI3b2ludTdNc3RPQVdGZ1JIVlpnYnBXeTJJb0lyOW1QOUNJZUtGM2N0?= =?utf-8?B?ck9YSnNrT0xkcVEvVWlWVzdIZHlocjhIQTJHYlNFd3ZjbGREOWFTb2tmRkIx?= =?utf-8?B?S0g3OGFLNnJrLzNwTURDclY0Rkw5SkQwUEdSNnM5YXQ2dzFoMTBhdzI0VHh5?= =?utf-8?B?emxTNHgxZ2l1aXJwbFpJUXNBYWJqNUdoZ1RwYlN3YnZ2VVRDNnoxcFNaVjRP?= =?utf-8?B?MTZDeGhKT1hUZnNVbWJCdzllZzlrTFdrb21LK2U1NnpTTzU4b1VPTXc1ZWQr?= =?utf-8?B?QnZXNjhlUXUvRlRoYzYxSTBzSXZYTUMzUlB5cGcxY3dNaWZQMjZMbEhJL0No?= =?utf-8?B?VDBrOUY5MGUwT0NFR0g5SzBDZHQzZ3AxRzE5SjRRMGtJUHFSdHp5Q21SMzZ2?= =?utf-8?B?dkpzakVYQmpKQ00vYmtFV2tUUzZsRGwrazNZcG1zRndaK3ozMmJlNmRkYTVI?= =?utf-8?B?ZkE9PQ==?= Content-ID: <35D80A8FDE82BE4492B19AB51AE64143@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6021.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 055698a4-a67d-4e6d-ab62-08db05969491 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2023 03:27:29.8396 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uqPr1APVTHP6h7ErCADPsgiClVZM652jx5uhdJwjjeBFNsQKytX5No/IGuVt9bRtiwodR0vuc7XXXYMEIe1N0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR03MB5889 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_192744_726258_CA4D921F X-CRM114-Status: GOOD ( 19.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Bjorn, Sorry for the late response and thanks for your comment. On Wed, 2023-01-11 at 16:14 -0600, Bjorn Helgaas wrote: > Hi, > > On Wed, Jan 11, 2023 at 11:25:41AM +0800, Jian Yang wrote: > > From: "jian.yang" > > > > Make MediaTek's controller driver capable of controlling power > > supplies and reset pin of a downstream component in power-on and > > power-off flow. > > > > Some downstream components (e.g., a WIFI chip) may need an extra > > reset other than of PERST# and their power supplies, depending on > > the requirements of platform, may need to controlled by their > > parent's driver. To meet the requirements described above, I add > > this > > feature to MediaTek's PCIe controller driver as a optional feature. > > Is this delay (dsc-reset-msleep) specific to a device downstream from > the MediaTek controller, not to the MediaTek controller itself? If > so, it sounds like it should be a generic value that could be used by > other drivers, too. > > How do you determine the value? If there's some PCIe spec that > determines this, please include a citation to it. Yes. This delay was defined for a downstream device (e.g., a PCIe EP) which need an extra reset pin, not for Mediatek's PCIe controller itself. I suppose we need to add a property in devicetree to let user determine the delay time due to differences in requirements between various devices. Best regards, Jian Yang _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel