From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAE45EDE9A0 for ; Thu, 14 Sep 2023 09:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nxAVGAN5oGaqLzCOkYPTE0tMthKQEwrSsgQGRvi3baI=; b=YSSUdnZnnz6elV 5Gj6qdXlYpYpk9AGjzltrH0DGp69ySlW9rAmeoY0DIt+I+LBiWfgL8FAKbNx/SY7rym7C7vbAGtXv QS0DOMiFpvAG2St/KOM3bE63zpg+thQ6QdsV5l4N8K7jDKz/+fsI1kTYEyZ45sVXerK29/uJJb3An ND8npc1SMrOnmO6XE0fePgE88IWGugnKF8MJIM0XktvbzMMU9g1W53HZyNoNSsiGwDPFOfMuK9TQJ K1Ua4opVxRRuUKXUsV45SMJ/AwqTbHR3CJsrrLQUQu4TtqtHxhI+zpqjBZ/c0KXDxxoMkStayLW+i 0iCssx5MKaDtYgtAA/fA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qginN-007qg7-2Y; Thu, 14 Sep 2023 09:37:57 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qginL-007qfJ-14; Thu, 14 Sep 2023 09:37:56 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 69FA066072FF; Thu, 14 Sep 2023 10:37:52 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1694684272; bh=CTv2KXJMAq+hbSXUQVfEZKQZVTB0BrNwUz1wHsn45uM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=i5jNrMk2hXUFgOvbLKzaN5pw6W65Po/mspdrZQ0IBjbf5qXShn9cutfLwPky61b7R rUCSlyyWVSEm5wbWEhUeRf1Iq0Hk70ApfNJKnj6hIrO2G4IlJMBgG4fcPd9ZwU1cPl QFy8hK8yUba6HkqrDMGmXbWNf+GBXy+J4Ge2Ti9SXEoF4xGYnTCfNgsf+LAh71fFre DfuH690DOsHuJIbp2fCxaIF7Urjx1ZD19FmVMy7mcrHHQLbl3WriragUaxMSOc1/Lq TNfILGtbITRHPllCUklEDVnZWZBDkNMllJNlAqGgu2fRhAfgLZbELPMOAS2q9YucAF oeZMDdfMt6Nbw== Message-ID: Date: Thu, 14 Sep 2023 11:37:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH] i2c: mt65xx: allow optional pmic clock To: Daniel Golle Cc: Qii Wang , Andi Shyti , Matthias Brugger , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, =?UTF-8?B?6YOt5bCP5qGl?= References: <3bf827929a44c17bfb1bf1000b143c02ce26a929.1693102324.git.daniel@makrotopia.org> <0fd097fd-9fdb-9001-cddb-7a396fde28bb@collabora.com> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230914_023755_530270_78E6EE77 X-CRM114-Status: GOOD ( 22.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 14/09/23 11:07, Daniel Golle ha scritto: > On Wed, Sep 13, 2023 at 04:00:53PM +0200, AngeloGioacchino Del Regno wrote: >> Il 27/08/23 04:13, Daniel Golle ha scritto: >>> Using the I2C host controller on the MT7981 SoC requires 4 clocks to >>> be enabled. One of them, the pmic clk, is only enabled in case >>> 'mediatek,have-pmic' is also set which has other consequences which >>> are not desired in this case. >>> >>> Allow defining a pmic clk even in case the 'mediatek,have-pmic' propterty >>> is not present and the bus is not used to connect to a pmic, but may >>> still require to enable the pmic clock. >>> >>> Signed-off-by: Daniel Golle >>> --- >>> drivers/i2c/busses/i2c-mt65xx.c | 12 ++++++++---- >>> 1 file changed, 8 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c >>> index 1a9b5a068ef1b..a8b5719c33729 100644 >>> --- a/drivers/i2c/busses/i2c-mt65xx.c >>> +++ b/drivers/i2c/busses/i2c-mt65xx.c >>> @@ -1442,15 +1442,19 @@ static int mtk_i2c_probe(struct platform_device *pdev) >>> if (IS_ERR(i2c->clocks[I2C_MT65XX_CLK_ARB].clk)) >>> return PTR_ERR(i2c->clocks[I2C_MT65XX_CLK_ARB].clk); >>> + i2c->clocks[I2C_MT65XX_CLK_PMIC].clk = devm_clk_get_optional(&pdev->dev, "pmic"); >>> + if (IS_ERR(i2c->clocks[I2C_MT65XX_CLK_PMIC].clk)) { >>> + dev_err(&pdev->dev, "cannot get pmic clock\n"); >>> + return PTR_ERR(i2c->clocks[I2C_MT65XX_CLK_PMIC].clk); >>> + } >>> + >>> if (i2c->have_pmic) { >> >> ...but you're not changing speed_clk if !i2c->have_pmic, I'm not sure that >> this will work correctly. Perhaps you wanted to also set speed_clk if the >> clock is present? > > No, if I wanted that I could have used the existing 'mediatek,have-pmic' > property -- however, all needed e.g. on MT7981 is to make sure the > clock is enabled, but still use I2C_MT65XX_CLK_MAIN as speed_clk. > Sorry, I've misunderstood the intention and yes, I understand now. Reviewed-by: AngeloGioacchino Del Regno _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel