From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E95FC433E0 for ; Thu, 23 Jul 2020 13:20:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E041B2065D for ; Thu, 23 Jul 2020 13:20:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fuCq5BmX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="1lPxscfD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="jZDlk7Gu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E041B2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lCu+aWTOk9Ib0ZWpbV/G/A2yniDb3C6FnXugyxHmKrA=; b=fuCq5BmX3soiTsT6tGDqwFGUr TqWZQJz0QCRpCi4i+D8W+9w/gHd4LEQyZUtArsCVOfAhA2mMjeCjWFa5+ASYkjxdOK/TtNiBmApl8 u04J6mKUlbYNv4hfrSL38GX9I7E6hIMJHTq0YnUAJdkAD7Y+Gce8IriGEJtAeLJQK9M7Bmm2rSHHN +IrnM1xEBpGhYsEIyE9ywoulk/P5YlsWxTlz9ySLTMUk85qcEUMgVaorkGGFH9Xg4hi27wAK9S6dF z3oXtBxwlYb84by0VWlpEybLYoWzqn7MvFxbxoziP8n5xGuSvowk8jlnyLJ+LhgVoNrPwihOyhb6d OswqufaKQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyb7Y-0006i2-Cm; Thu, 23 Jul 2020 13:18:48 +0000 Received: from esa5.microchip.iphmx.com ([216.71.150.166]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyb7G-0006Ye-1O for linux-arm-kernel@lists.infradead.org; Thu, 23 Jul 2020 13:18:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1595510310; x=1627046310; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=SZ6B77O5/M4+OCP1S2wQpay9y1ccfSiO5darEm/SpL0=; b=1lPxscfDG+A45cljMUYOx3SjhaVmBVyCE+HB4kDkyMxD+JScqOZiPp3M YfG7mjefH9dzWOOtVQh+nqlL+PZcLCE8348ETJadz77FKE6u/TI6gbcwY zvQxzELvknptzC3xHX3i/BrqbTF78a6EcGupzIPMPDHKyBHP1U1fGd350 9xK5nv+dIAbf0Y2FCaemQ7aFTQV3D7GeuvuFcxQEjHlQgDb+ZePRxsIrL oGim4njbOa6gpY6spMzYDFgWbmYhJKbp1G+MsTSIVi/EY/Z/BL00ogx1z s4OgB5FxYK0S7UU7LL7mx5sua9Hqg9CH0DaUu+qyAgiHMdXMgtNnk+TNs w==; IronPort-SDR: I1lqsqKpwPbYgdKhG9/mLJEoqdUOPyzmYtuWyXtulaMscVQj1LY1d6vGHfopb+bcaOVhwC4IOM X5BYfEP+XjoYazfguAZnnCL2vkSlVATWJEeCipwsMV2E3m6tdXNJax5ttNHMjrBjIjw78aBqpO TWyhkf0ZDFP20u8STv9sSqnrIpz5UQRYOyhYpg6KEY8NBR9gGF0MI+ASzYWjZ8zIzgnbxrjpDe nibLgtFHm1K7y/weRMBYzMmbQtar98xbac2mVBuKWOw3h5BqwzTMkA3Rp8VCnPvzy7IN+6x1Ki pZk= X-IronPort-AV: E=Sophos;i="5.75,386,1589266800"; d="scan'208";a="84346656" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 23 Jul 2020 06:18:27 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Thu, 23 Jul 2020 06:18:19 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Thu, 23 Jul 2020 06:17:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejsIR/I1qsQa0vl1TkAjnPHsfTpBZctwh2kCZ1KoDqOxpWbtxcGDxdaBvco+YjidrXGvyy92BcRSpgfPoby1GjIZ5QPqKH8UvObTyGMrHdnXxUlNrve6MZWyw97Uf1g/ov13cyZffkJVASQjV0vhoMmIVXfwiWzT4o8bnq0k361dG+TCoCbvLObbYMumB3rFglUqBN4PVDzuwcJUX7w1C2kvTDzb4YqvCzMuUrrvnP4X+4UWest6pe0qnXwNS3GlogDTSghmIm3XX/wD/cqkNfofMiZHnc30zwCJVSVVot8YjvjYo5WpekxkJ/K3Wff/o45lU1F2PdVAYJjjHczZgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZ6B77O5/M4+OCP1S2wQpay9y1ccfSiO5darEm/SpL0=; b=ZoIKg9jkWksml8BWhuZtvHt9qfZdt1SsaDVEaZAANrN0oZC+G8RULBxz0rra6fuR9g0BALJSPPy50D7j/raFvOu4Gfc3rsE/Cx5WJaAg+rXRJFMZuZRtr1Pj+8H82x/UA7LYkZdyE0Abg53DOJg/WVo44T4yTdT0P4at9k8EgTNN7/toh2JcWeiow3+h/ZQZNr2Y+K2hMFWGIdH3oeZsNNgpJZaCizP7cZxayjXTf3VJayMH4FmdmX+qQrbO05ZUrEMHbGO2f2omM85H3jAame4kIIGfKBDvHsptWotFyySFxnx8e7+gip8vLEEoBK0erXAe4kDbxsR65FsjNv0meg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZ6B77O5/M4+OCP1S2wQpay9y1ccfSiO5darEm/SpL0=; b=jZDlk7Gu9l/QagD6WuOepuHTVdKuvOH5W3OuMNtehBNu+hhFtzZ9yHEwa9vhcnW35vGPluNDUEAThtccgQlfMvfOUXyFYvGk89UgWGgK+Uh08iOMNMpErpPyR1tnX2gZbmXHmBva6TZ5XmrIDGr8XTCGYyOFvPgSoH6x1UksWEw= Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SN6PR11MB2893.namprd11.prod.outlook.com (2603:10b6:805:dc::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.21; Thu, 23 Jul 2020 13:18:16 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::851c:67fc:a034:9ea0]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::851c:67fc:a034:9ea0%4]) with mapi id 15.20.3216.022; Thu, 23 Jul 2020 13:18:15 +0000 From: To: , , , , Subject: Re: [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB Thread-Topic: [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB Thread-Index: AQHWX4JuelDTpdq80UW3XJv+RJlkGakTZ76AgAASg4CAAVL2AIAAWzGA Date: Thu, 23 Jul 2020 13:18:15 +0000 Message-ID: References: <20200721171316.1427582-1-codrin.ciubotariu@microchip.com> <0ec99957-57e9-b384-425a-ccf0e877f1a1@microchip.com> <7cab13f6-ac54-8f5c-c1bf-35e6c3b5d9db@microchip.com> <8a78218a-9fbe-889d-8501-ad67ccb6e59b@microchip.com> In-Reply-To: <8a78218a-9fbe-889d-8501-ad67ccb6e59b@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 authentication-results: microchip.com; dkim=none (message not signed) header.d=none;microchip.com; dmarc=none action=none header.from=microchip.com; x-originating-ip: [84.232.220.208] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3971270c-3c89-411d-d384-08d82f0adbfb x-ms-traffictypediagnostic: SN6PR11MB2893: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fSqg90P9a/VE+om3BcccsQlSB7PVoN0+2V/YpAkEIqZ4mlXJv44IWmrV3rEg+zphbmEQhRZMMzEiuj6ZVnnk4WfJ+havj5mWryG88Asxiu9mWZwlQp7kCvbA+8M+U2Gp2MBvWJHVDsI0otAybiU7fjDqL8ldDuuvoVWqQKm+a1GhpsNIjMuxDlDgYpnRXBsLusny4fb9AB+Yovwvg0PcFuuVVzr3JYhlU7RO3Q6cC7U8kVxc3u6aj1tCkuapaa2LJ0o252KKru6DlxsrbiTBWcmYkyJlXt+xRlvB0HjQPARkl9ywyv+sRvDOZ6YMcg/sZRTggvfbtuNKYlIWdqNDu1roe83GCG8sSjw3jTaM8a86ll1dvjKPvBNkqCr1UZOn x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(376002)(366004)(136003)(39860400002)(346002)(396003)(107886003)(53546011)(2616005)(6506007)(66476007)(478600001)(86362001)(26005)(31696002)(4326008)(7416002)(64756008)(36756003)(5660300002)(8676002)(6512007)(66446008)(8936002)(54906003)(110136005)(6486002)(316002)(66946007)(71200400001)(91956017)(76116006)(2906002)(31686004)(186003)(66556008)(83380400001)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 5vq67hbu6orUVWRD49v/04P2TKZd2O2HC8k7bS/yWVNKZyyOl3ckqzkvGJxpTGSQE6CvrTWRulk2NmFowzxrC1NSDf1pzzGWpBvxns9nstfM3q+l8v/YMxZNklNvDcWryAlG5gonI8lDigKaGmC11SI+ozdXTO/65Nx7syWcbt7mTrRxN7GOX2/aU+mAWp7ip5bpFJgtaYhcKFVkHtPG8ccgyOcq0Q0rM8mQQEobqVKVquTLHlzdQKm/6arXwzX3pXx0sW8h7fF6mLg8lTHIG1+UQ6Elk6Tik17/1oF+GwxNnBOt6N2LXwS/SLzGpOE+UeuPxDGtARABlJd0EJETRs6z/hT/Wjzf6DUXaBMdUDqer4R8ewkUjKI2zqMAR9IlNkHs4eUxbANaqv+MQlSKI8QUnHVoPWwY28wSh8cRauAIRALSmb+c/NKfZSEptPu/PsGK14/kEKEsHTTqDHdkRnsaTza+GH2nA2K55dymx5PBc9VJIeLo6Y8CPvSo0eaC Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3971270c-3c89-411d-d384-08d82f0adbfb X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2020 13:18:15.8478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6C/z4Anu6vAD1UQ/OBNHmydJzdpzd5MqmAqNw4QL4ulgXPwLtUfJiiSevgbIDAy3qTxixwfYQhTR+XJPrjH+Frlj0NLZxbcnSYV6ZwWBu3M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2893 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_091830_357071_D16432AD X-CRM114-Status: GOOD ( 19.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, alexandre.belloni@bootlin.com, f.fainelli@gmail.com, Ludovic.Desroches@microchip.com, robh+dt@kernel.org, kuba@kernel.org, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23.07.2020 10:51, Claudiu Beznea - M18063 wrote: > > > On 22.07.2020 14:38, Codrin Ciubotariu - M19940 wrote: >> On 22.07.2020 13:32, Claudiu Beznea - M18063 wrote: >>> >>> >>> On 21.07.2020 20:13, Codrin Ciubotariu wrote: >>>> Adding the PHY nodes directly under the Ethernet node became deprecated, >>>> so the aim of this patch series is to make MACB use an MDIO node as >>>> container for MDIO devices. >>>> This patch series starts with a small patch to use the device-managed >>>> devm_mdiobus_alloc(). In the next two patches we update the bindings and >>>> adapt macb driver to parse the device-tree PHY nodes from under an MDIO >>>> node. The last patches add the MDIO node in the device-trees of sama5d2, >>>> sama5d3, samad4 and sam9x60 boards. >>>> >>> >>> Tested this series on sama5d2_xplained in the following scenarios: >>> >>> 1/ PHY bindings from patch 4/7: >>> mdio { >>> #address-cells = <1>; >>> #size-cells = <0>; >>> ethernet-phy@1 { >>> reg = <0x1>; >>> interrupt-parent = <&pioA>; >>> interrupts = ; >>> }; >>> >>> 2/ PHY bindings before this series: >>> ethernet-phy@1 { >>> reg = <0x1>; >>> interrupt-parent = <&pioA>; >>> interrupts = ; >>> }; >>> >>> 3/ No PHY bindings at all. >>> >>> All 3 cases went OK. >>> >>> You can add: >>> Tested-by: Claudiu Beznea >>> Acked-by: Claudiu Beznea >> >> Thank you very much Claudiu! >> There is still one more case in my mind. macb could be a fixed-link with >> an MDIO DSA switch. While the macb would have a fixed connection with a >> port from the DSA switch, the switch could be configured using macb's >> MDIO. The dt would be something like: >> >> macb { >> fixed-link { >> ... >> }; >> mdio { >> switch@0 { >> ... >> }; >> }; >> }; > > Do you have a setup for testing this? At the moment I don't know a > configuration like this that macb is working with. There isn't one that I am aware of, but we should address it. > >> >> To support this, in patch 3/7 I should first check for the mdio node to >> return of_mdiobus_register() and then check if it's a fixed-link to >> return simple mdiobus_register(). I will address this in v3...> >> Thanks and best regards, >> Codrin >> >>> >>> Thank you, >>> Claudiu Beznea >>> >>>> Changes in v2: >>>> - renamed patch 2/7 from "macb: bindings doc: use an MDIO node as a >>>> container for PHY nodes" to "dt-bindings: net: macb: use an MDIO >>>> node as a container for PHY nodes" >>>> - added back a newline removed by mistake in patch 3/7 >>>> >>>> Codrin Ciubotariu (7): >>>> net: macb: use device-managed devm_mdiobus_alloc() >>>> dt-bindings: net: macb: use an MDIO node as a container for PHY nodes >>>> net: macb: parse PHY nodes found under an MDIO node >>>> ARM: dts: at91: sama5d2: add an mdio sub-node to macb >>>> ARM: dts: at91: sama5d3: add an mdio sub-node to macb >>>> ARM: dts: at91: sama5d4: add an mdio sub-node to macb >>>> ARM: dts: at91: sam9x60: add an mdio sub-node to macb >>>> >>>> Documentation/devicetree/bindings/net/macb.txt | 15 ++++++++++++--- >>>> arch/arm/boot/dts/at91-sam9x60ek.dts | 8 ++++++-- >>>> arch/arm/boot/dts/at91-sama5d27_som1.dtsi | 16 ++++++++++------ >>>> arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi | 17 ++++++++++------- >>>> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts | 13 ++++++++----- >>>> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 12 ++++++++---- >>>> arch/arm/boot/dts/at91-sama5d3_xplained.dts | 16 ++++++++++++---- >>>> arch/arm/boot/dts/at91-sama5d4_xplained.dts | 12 ++++++++---- >>>> drivers/net/ethernet/cadence/macb_main.c | 18 ++++++++++++------ >>>> 9 files changed, 86 insertions(+), 41 deletions(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel