From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DAE1CA0EFC for ; Fri, 30 Aug 2024 10:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MgSm99y0KRX2W9LCG6vYvqeAv5Fhuz5ARIXmDjdGZpc=; b=sxC3lT+h/byeygu5Vsq+K1bDxO Cwf9EbGiClS200skW8M2EPx5GGCm+6i0D8dw3mF7sZh2HCyigdvV7w9O5x2qq0fz5gs2w2+vAzM7I Jt2BxB17I6d1ZUUJiJp9Z1HhwwrBQgIqo5/ERD+y23iDTzXehSswsrVJvIpSxsEU+VtssK70c0dI9 t+IXLes+FqHbM8xeGIxpQskxkAPhWlpec0ZuTsL5BVsKskxBK741Pa0MTyiaHUiPw7Y8benVAO0sK figF506A6jYuXZXtO8mmYT2/V+uql+qrPOIYxbF7nX796cT1MyF8iynkL/zZdnOD3zLHrGmr9Ia9b YKvRFRHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjz84-00000005ss0-2EpG; Fri, 30 Aug 2024 10:45:20 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjz5J-00000005s9E-12t7 for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 10:42:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8FE5CA4199E; Fri, 30 Aug 2024 10:42:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9481FC4CEC2; Fri, 30 Aug 2024 10:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725014548; bh=jA4lsgsFD3X8QkYNItr6qi1y+umk+wphRQhygk8nt0c=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=Gtug+pcLEhXm1o4ptqD2oXpjWByeNyAkqMC+xTmyG7+Cs+7axtNBqHbtE3KDsEYTQ iMAFTcSHVOJNrgYZfjEigiw/cX7ZsJ3ky4yGDfaT+q6NG9+qGX0QFpsjfiUKTm1sbA yoalz97N1Rspmtd9aGt1yCKEFn3+32KbsMSZKiB40K090tRG3Pl4P+gnhFDP0OA71W QVWvxqTGAfqve1yFziZoVHMc0Gz43ieqtiQKm26MjqQ6JyRsl2bQl+XwHZF9pFqwuJ sywxqej+OHLSdx1Yi58cVIht9T+l2P51vrTWO8qsWSsLsQiDTKj/SOHR8csMW66AJ6 WbGPKE+xnYnVw== Message-ID: Date: Fri, 30 Aug 2024 12:42:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next v2 2/4] soc: ti: knav_dma: Use dev_err_probe() to simplfy code From: Krzysztof Kozlowski To: Nishanth Menon , Jinjie Ruan Cc: ssantosh@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jic23@kernel.org References: <20240830063228.3519385-1-ruanjinjie@huawei.com> <20240830063228.3519385-3-ruanjinjie@huawei.com> <20240830103155.5vs2hdokw6yysq47@finance> <1757c33c-a407-4a23-806d-658d9abe051f@kernel.org> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <1757c33c-a407-4a23-806d-658d9abe051f@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_034229_454289_B18133CC X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/08/2024 12:36, Krzysztof Kozlowski wrote: > On 30/08/2024 12:31, Nishanth Menon wrote: >> On 14:32-20240830, Jinjie Ruan wrote: >>> Use the dev_err_probe() helper to simplify error handling >>> during probe. >>> >>> Signed-off-by: Jinjie Ruan >>> --- >>> v2: >>> - Split into 2 patches. >>> --- >>> drivers/soc/ti/knav_dma.c | 12 ++++-------- >>> 1 file changed, 4 insertions(+), 8 deletions(-) >>> >>> diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c >>> index 15e41d3a5e22..eeec422a46f0 100644 >>> --- a/drivers/soc/ti/knav_dma.c >>> +++ b/drivers/soc/ti/knav_dma.c >>> @@ -708,17 +708,13 @@ static int knav_dma_probe(struct platform_device *pdev) >>> struct device_node *node = pdev->dev.of_node; >>> int ret = 0; >>> >>> - if (!node) { >>> - dev_err(&pdev->dev, "could not find device info\n"); >>> - return -EINVAL; >>> - } >>> + if (!node) >>> + return dev_err_probe(&pdev->dev, -EINVAL, "could not find device info\n"); >>> >>> kdev = devm_kzalloc(dev, >>> sizeof(struct knav_dma_pool_device), GFP_KERNEL); >>> - if (!kdev) { >>> - dev_err(dev, "could not allocate driver mem\n"); >>> - return -ENOMEM; >>> - } >>> + if (!kdev) >>> + return dev_err_probe(dev, -ENOMEM, "could not allocate driver mem\n"); >> >> These make no sense to me :( -> just using dev_err_probe when there is >> no chance of -EPROBE_DEFER ? > > Well, this does not make sense from other point of view - memory > allocation errors should have any printks... s/should/should not/ obviously :) > > This patchset - like several others from Jinjie - is some sort of > automation without careful consideration and without thinking whether > code makes sense. > > Therefore I suggest to review it thoroughly and do not trust the > "innocent" look of such changes. Best regards, Krzysztof