From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27B27C61DA4 for ; Sat, 18 Feb 2023 10:11:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=reH3jTs3uamuM3bmI9O2a+1DI7tlCdVtNwaYNUqFP4A=; b=qW7Nr154LnnORS g1jnqYgvIEdufXvm+aipnzr2JMdCrjSQmWLa4qB/pwCasTADnnxveIYo4exYvQfQNmexbXlSh0ATW QRLBg/xS6DRFRi8EVdKJuUqz9ylTUwhrVTmSxovrePZJXVzMgNUyWK3JgHBcozVb/3ImHKpgAc+jZ 04u6RtbpeqeWutAsctvI6MLHPT8yEr8yKO8VdoDLIDMA9qDP/eek0ST4HoepoK+XhSoQCg6IwVGgY 3TN4el4Aq3FM7iZm6oG0kBgzpDP1czIVN8sfZUbBkMI8dxbs9Rx6k5JM0ojOAXruHeFXRidZgsZbV ANE8aeArHfUvzBwDOSLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTKAv-00GkOW-QL; Sat, 18 Feb 2023 10:10:37 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTKAr-00GkNN-Vo for linux-arm-kernel@lists.infradead.org; Sat, 18 Feb 2023 10:10:35 +0000 Received: by mail-ed1-x52d.google.com with SMTP id t19so1091944edi.13 for ; Sat, 18 Feb 2023 02:10:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=HF0DcS0ZS+01AvWrN70KNxaOHsB2n9jllNRuloPze0Y=; b=kl5doSpWXi3Kei5ZgZG95krT8GMZx2JqflbaScqDaqQydetrFulbPqz0JWomcjDEjX JcxfQ5ztullNQFpgR/zCaOwWMOXQO+O3m+oXhfsay0TaNbCDDkSXU+8y0W31n2WDMXu4 9aD0Hj4ihvgwTzGkACrNT1lvy7EagPt4ReyW6QOF4ArzUJsP1BAS/qv0y8qc2J+8ZSSI B0iG+37MK6cUqvk1JAA076ynwqYpGsMcSenViIZquQct0DUW7r2yInSgu4X0Ez2Lefa4 mpEw91OB44Gv8jn/E0mjeGbuZBjAqKLVvyIpd5e/QRCRWW0UGrQjarYAvzOUxMLZpDs3 kN4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HF0DcS0ZS+01AvWrN70KNxaOHsB2n9jllNRuloPze0Y=; b=Eb+Q04VV47QRJcaT2eSg++Mz11jqm1Chsy/F9SK+RAuxsJpetYh+imJQI4RCbkzIkl ZvjwnF3bfuU/HfAhUki88ZgYz53c8GE7QNtQvzVYHel/5SuAvFHnjMgjMsfEaorMg9uX M8WYcJ7BIzL59TDDcfVJJjeT6cSn5N89QJa4ky/gU85c+9LEAmbdJZt94rcppZG6Vjcf 72H4IXjF8trLnKUW4bqkggOhli+YdWdy0B8oUuvSjjGJW1Sx4mBwC1jhZ4Bfo/D/+wCF njF8BTf1cnnoFlDac/3QShkuGIlMMw59c5p+8hNdCw/0a57SJ+nJYr4yxz6e946BZ07X RG+w== X-Gm-Message-State: AO0yUKV2FnRGBI45wt/fGIPEEVpJxWWbKLDwtKZVTd/UbQAjRzUfY0Wk APjXJIDVeGqgwSlxYkPBj9IU7g== X-Google-Smtp-Source: AK7set8Oz5135GMjU3IWKlGah+gmHtwLX1ikikSRnXZqIU/R0XwcVJQ4kDyRpW7TI+dkkdbXVFovNQ== X-Received: by 2002:aa7:c051:0:b0:4ac:d30d:c3a3 with SMTP id k17-20020aa7c051000000b004acd30dc3a3mr2891721edo.32.1676715028023; Sat, 18 Feb 2023 02:10:28 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id e9-20020a50a689000000b004accf3a63cbsm3318177edc.68.2023.02.18.02.10.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Feb 2023 02:10:27 -0800 (PST) Message-ID: Date: Sat, 18 Feb 2023 11:10:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v5 3/5] ARM: dts: hpe: Add I2C Topology To: nick.hawkins@hpe.com, verdun@hpe.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wsa@kernel.org References: <20230217155054.99757-1-nick.hawkins@hpe.com> <20230217155054.99757-4-nick.hawkins@hpe.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230217155054.99757-4-nick.hawkins@hpe.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230218_021034_080434_CC9A25BD X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/02/2023 16:50, nick.hawkins@hpe.com wrote: > diff --git a/arch/arm/boot/dts/hpe-gxp.dtsi b/arch/arm/boot/dts/hpe-gxp.dtsi > index cf735b3c4f35..3bc071149bae 100644 > --- a/arch/arm/boot/dts/hpe-gxp.dtsi > +++ b/arch/arm/boot/dts/hpe-gxp.dtsi > @@ -122,6 +122,131 @@ > interrupts = <6>; > interrupt-parent = <&vic0>; > }; > + > + sysreg_system_controller: syscon@f8 { > + compatible = "hpe,gxp-sysreg", "syscon"; > + reg = <0xf8 0x8>; > + }; > + > + i2c0: i2c@2000 { > + compatible = "hpe,gxp-i2c"; > + reg = <0x2000 0x70>; > + interrupts = <9>; > + interrupt-parent = <&vic0>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + hpe,sysreg = <&sysreg_system_controller>; > + clock-frequency = <100000>; clock-frequency is a property of the board. If it is fixed in the SoC, then make it fixed in the driver and there is no point for this property in DT. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel