* [PATCH v4 2/2] arm64: dts: imx8mp-msc-sm2s: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board [not found] <20220812084120.376042-1-martyn.welch@collabora.com> @ 2022-08-12 8:41 ` Martyn Welch 2022-08-12 9:47 ` Krzysztof Kozlowski 0 siblings, 1 reply; 8+ messages in thread From: Martyn Welch @ 2022-08-12 8:41 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team Cc: kernel, Martyn Welch, devicetree, linux-kernel, linux-arm-kernel Add device trees for one of a number of MSC's (parent company, Avnet) variants of the SM2S-IMX8PLUS system on module along with the compatible SM2S-SK-AL-EP1 carrier board. As the name suggests, this family of SoMs use the NXP i.MX8MP SoC and provide the SMARC module interface. Signed-off-by: Martyn Welch <martyn.welch@collabora.com> --- Changes in v2 - Added compatibles - Removed underscores from node names - Make node names more generic - Reorder properties - Fix issues found by dtbs_check in these files Changes in v3: - Switched to avnet vendor string in compatibles - Corrected patch description Changes in v4: - Switched from phy-reset-gpios to reset-gpios, removing duplication - Removed unneeded sdma1 node arch/arm64/boot/dts/freescale/Makefile | 1 + .../freescale/imx8mp-msc-sm2s-14N0600E.dts | 72 ++ .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 53 ++ .../boot/dts/freescale/imx8mp-msc-sm2s.dtsi | 812 ++++++++++++++++++ 4 files changed, 938 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s.dtsi diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile index 8bf7f7ecebaa..139c8b95c9c9 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice-gw7902.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb +dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts new file mode 100644 index 000000000000..9e976e8baaee --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts @@ -0,0 +1,72 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2022 Avnet Embedded GmbH + */ +/dts-v1/; + +#include "imx8mp-msc-sm2s.dtsi" + +/ { + model = "MSC SM2S-IMX8PLUS-QC6-14N0600E SoM"; + compatible = "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp", + "fsl,imx8mp"; + + memory@40000000 { + device_type = "memory"; + reg = <0x0 0x40000000 0 0x80000000>; /* bank0, 2GiB */ + }; +}; + +&cpu_alert0 { + temperature = <95000>; +}; + +&cpu_crit0 { + temperature = <105000>; +}; + +&soc_alert0 { + temperature = <95000>; +}; + +&soc_crit0 { + temperature = <105000>; +}; + +&tca6424 { + gbe0-int-hog { + gpio-hog; + input; + gpios = <3 GPIO_ACTIVE_LOW>; + }; + + gbe1-int-hog { + gpio-hog; + input; + gpios = <4 GPIO_ACTIVE_LOW>; + }; + + cam2-rst-hog { + gpio-hog; + output-high; + gpios = <9 GPIO_ACTIVE_LOW>; + }; + + cam2-pwr-hog { + gpio-hog; + output-high; + gpios = <10 GPIO_ACTIVE_LOW>; + }; + + tpm-int-hog { + gpio-hog; + input; + gpios = <13 GPIO_ACTIVE_LOW>; + }; + + wifi-int-hog { + gpio-hog; + input; + gpios = <14 GPIO_ACTIVE_LOW>; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts new file mode 100644 index 000000000000..523d2d80a3f1 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts @@ -0,0 +1,53 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2022 Avnet Embedded GmbH + */ + +/dts-v1/; + +#include "imx8mp-msc-sm2s-14N0600E.dts" +#include <dt-bindings/clock/imx8mp-clock.h> +#include <dt-bindings/gpio/gpio.h> + +/ { + model = "MSC SM2-MB-EP1 Carrier Board with SM2S-IMX8PLUS-QC6-14N0600E SoM"; + compatible = "avnet,sm2s-imx8mp-14N0600E-ep1", + "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp", + "fsl,imx8mp"; +}; + +&flexcan1 { + status = "okay"; +}; + +&flexcan2 { + status = "okay"; +}; + +&usdhc2 { + no-1-8-v; +}; + +&iomuxc { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_smarc_gpio>; + + pinctrl_smarc_gpio: smarcgpiosgrp { + fsl,pins = + <MX8MP_IOMUXC_GPIO1_IO11__GPIO1_IO11 0x19>, /* GPIO0 */ + <MX8MP_IOMUXC_SAI1_RXC__GPIO4_IO01 0x19>, /* GPIO1 */ + <MX8MP_IOMUXC_SAI1_RXD0__GPIO4_IO02 0x19>, /* GPIO2 */ + <MX8MP_IOMUXC_SAI1_RXD1__GPIO4_IO03 0x19>, /* GPIO3 */ + <MX8MP_IOMUXC_SAI3_RXC__GPIO4_IO29 0x19>, /* GPIO4 */ + <MX8MP_IOMUXC_SAI3_MCLK__GPIO5_IO02 0x19>, /* GPIO5 */ + <MX8MP_IOMUXC_SAI1_TXD6__GPIO4_IO18 0x19>, /* GPIO6 */ + <MX8MP_IOMUXC_GPIO1_IO10__GPIO1_IO10 0x19>, /* GPIO7 */ + <MX8MP_IOMUXC_SAI1_MCLK__GPIO4_IO20 0x19>, /* GPIO8 */ + <MX8MP_IOMUXC_SAI2_RXFS__GPIO4_IO21 0x19>, /* GPIO9 */ + <MX8MP_IOMUXC_SAI2_RXC__GPIO4_IO22 0x19>, /* GPIO10 */ + <MX8MP_IOMUXC_SAI3_RXFS__GPIO4_IO28 0x19>, /* GPIO11 */ + <MX8MP_IOMUXC_SAI1_TXD7__GPIO4_IO19 0x19>, /* GPIO12 */ + <MX8MP_IOMUXC_SAI1_RXFS__GPIO4_IO00 0x19>; /* GPIO13 */ + }; +}; + diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s.dtsi new file mode 100644 index 000000000000..72e7dfb0a77f --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s.dtsi @@ -0,0 +1,812 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2022 Avnet Embedded GmbH + */ + +/dts-v1/; + +#include "imx8mp.dtsi" +#include <dt-bindings/net/ti-dp83867.h> + +/ { + aliases { + rtc0 = &sys_rtc; + rtc1 = &snvs_rtc; + }; + + chosen { + stdout-path = &uart2; + }; + + reg_usb0_host_vbus: regulator-usb0-vbus { + compatible = "regulator-fixed"; + regulator-name = "usb0_host_vbus"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb0_vbus>; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + gpio = <&gpio1 12 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + + reg_usb1_host_vbus: regulator-usb1-vbus { + compatible = "regulator-fixed"; + regulator-name = "usb1_host_vbus"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb1_vbus>; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + gpio = <&gpio1 14 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + + reg_usdhc2_vmmc: regulator-usdhc2 { + compatible = "regulator-fixed"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usdhc2_vmmc>; + regulator-name = "VSD_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; + enable-active-high; + startup-delay-us = <100>; + off-on-delay-us = <12000>; + }; + + reg_flexcan1_xceiver: regulator-flexcan1 { + compatible = "regulator-fixed"; + regulator-name = "flexcan1-xceiver"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + enable-active-high; + }; + + reg_flexcan2_xceiver: regulator-flexcan2 { + compatible = "regulator-fixed"; + regulator-name = "flexcan2-xceiver"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + enable-active-high; + }; + + lcd0_backlight: backlight-0 { + compatible = "pwm-backlight"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lcd0_backlight>; + pwms = <&pwm1 0 100000 0>; + brightness-levels = <0 255>; + num-interpolated-steps = <255>; + default-brightness-level = <255>; + enable-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>; + status = "disabled"; + }; + + lcd1_backlight: backlight-1 { + compatible = "pwm-backlight"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lcd1_backlight>; + pwms = <&pwm2 0 100000 0>; + brightness-levels = <0 255>; + num-interpolated-steps = <255>; + default-brightness-level = <255>; + enable-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>; + status = "disabled"; + }; + + leds { + compatible = "gpio-leds"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_leds>; + status = "okay"; + + led-sw { + label = "sw-led"; + gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>; + default-state = "off"; + linux,default-trigger = "heartbeat"; + }; + }; + + extcon_usb0: extcon-usb0 { + compatible = "linux,extcon-usb-gpio"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb0_extcon>; + id-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>; + }; +}; + +&A53_0 { + cpu-supply = <&vcc_arm>; +}; + +&A53_1 { + cpu-supply = <&vcc_arm>; +}; + +&A53_2 { + cpu-supply = <&vcc_arm>; +}; + +&A53_3 { + cpu-supply = <&vcc_arm>; +}; + +&ecspi1 { + #address-cells = <1>; + #size-cells = <0>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ecspi1>; + cs-gpios = <0>, <&gpio2 8 GPIO_ACTIVE_LOW>; +}; + +&ecspi2 { + #address-cells = <1>; + #size-cells = <0>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ecspi2>; + cs-gpios = <0>, <&gpio2 9 GPIO_ACTIVE_LOW>; +}; + +&eqos { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_eqos>; + phy-mode = "rgmii-id"; + phy-handle = <ðphy0>; + status = "okay"; + + mdio { + compatible = "snps,dwmac-mdio"; + #address-cells = <1>; + #size-cells = <0>; + + ethphy0: ethernet-phy@1 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <1>; + eee-broken-1000t; + reset-gpios = <&tca6424 16 GPIO_ACTIVE_LOW>; + reset-assert-us = <1000>; + reset-deassert-us = <1000>; + ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_25_NS>; + ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_25_NS>; + ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>; + ti,clk-output-sel = <DP83867_CLK_O_SEL_OFF>; + }; + }; +}; + +&fec { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_fec>; + phy-mode = "rgmii-id"; + phy-handle = <ðphy1>; + fsl,magic-packet; + status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy1: ethernet-phy@1 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <1>; + eee-broken-1000t; + reset-gpios = <&tca6424 17 GPIO_ACTIVE_LOW>; + reset-assert-us = <1000>; + reset-deassert-us = <1000>; + ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_25_NS>; + ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_25_NS>; + ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>; + ti,clk-output-sel = <DP83867_CLK_O_SEL_OFF>; + }; + }; +}; + +&i2c1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c1>; + clock-frequency = <400000>; + status = "okay"; + + id_eeprom: eeprom@50 { + compatible = "atmel,24c64"; + reg = <0x50>; + pagesize = <32>; + }; +}; + +&i2c2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c2>; + clock-frequency = <400000>; + status = "disabled"; +}; + +&i2c3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c3>; + clock-frequency = <400000>; + status = "disabled"; +}; + +&i2c4 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c4>; + clock-frequency = <400000>; + status = "disabled"; +}; + +&i2c5 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c5>; + clock-frequency = <400000>; + status = "disabled"; +}; + +&i2c6 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c6>; + clock-frequency = <400000>; + status = "okay"; + + tca6424: gpio@22 { + compatible = "ti,tca6424"; + reg = <0x22>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_tca6424>; + gpio-controller; + #gpio-cells = <2>; + gpio-line-names = "BOOT_SEL0#", "BOOT_SEL1#", "BOOT_SEL2#", + "gbe0_int", "gbe1_int", "pmic_int", "rtc_int", "lvds_int", + "PCIE_WAKE#", "cam2_rst", "cam2_pwr", "SLEEP#", + "wifi_pd", "tpm_int", "wifi_int", "PCIE_A_RST#", + "gbe0_rst", "gbe1_rst", "LID#", "BATLOW#", "CHARGING#", + "CHARGER_PRSNT#"; + interrupt-parent = <&gpio1>; + interrupts = <9 IRQ_TYPE_EDGE_RISING>; + interrupt-controller; + #interrupt-cells = <2>; + }; + + dsi_lvds_bridge: bridge@2d { + compatible = "ti,sn65dsi83"; + reg = <0x2d>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lvds_bridge>; + enable-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>; + status = "disabled"; + }; + + pmic: pmic@30 { + compatible = "ricoh,rn5t567"; + reg = <0x30>; + interrupt-parent = <&tca6424>; + interrupts = <5 IRQ_TYPE_EDGE_FALLING>; + + regulators { + DCDC1 { + regulator-name = "VCC_SOC"; + regulator-always-on; + regulator-min-microvolt = <950000>; + regulator-max-microvolt = <950000>; + }; + DCDC2 { + regulator-name = "VCC_DRAM"; + regulator-always-on; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + }; + vcc_arm: DCDC3 { + regulator-name = "VCC_ARM"; + regulator-always-on; + regulator-min-microvolt = <950000>; + regulator-max-microvolt = <950000>; + }; + DCDC4 { + regulator-name = "VCC_1V8"; + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + LDO1 { + regulator-name = "VCC_LDO1_2V5"; + regulator-always-on; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; + }; + LDO2 { + regulator-name = "VCC_LDO2_1V8"; + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + LDO3 { + regulator-name = "VCC_ETH_2V5"; + regulator-always-on; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; + }; + LDO4 { + regulator-name = "VCC_DDR4_2V5"; + regulator-always-on; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; + }; + LDO5 { + regulator-name = "VCC_LDO5_1V8"; + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + LDORTC1 { + regulator-name = "VCC_SNVS_1V8"; + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + LDORTC2 { + regulator-name = "VCC_SNVS_3V3"; + regulator-always-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + }; + }; + + sys_rtc: rtc@32 { + compatible = "ricoh,r2221tl"; + reg = <0x32>; + interrupt-parent = <&tca6424>; + interrupts = <6 IRQ_TYPE_EDGE_FALLING>; + }; + + tmp_sensor: temperature-sensor@71 { + compatible = "ti,tmp103"; + reg = <0x71>; + }; +}; + +&flexcan1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_flexcan1>; + xceiver-supply = <®_flexcan1_xceiver>; + status = "disabled"; +}; + +&flexcan2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_flexcan2>; + xceiver-supply = <®_flexcan2_xceiver>; + status = "disabled"; +}; + +&flexspi { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_flexspi0>; + status = "okay"; + + qspi_flash: flash@0 { + compatible = "jedec,spi-nor"; + reg = <0>; + #address-cells = <1>; + #size-cells = <1>; + spi-max-frequency = <80000000>; + spi-tx-bus-width = <4>; + spi-rx-bus-width = <4>; + }; +}; + +&pwm1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm1>; + status = "disabled"; +}; + +&pwm2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm2>; + status = "disabled"; +}; + +&pwm3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm3>; + status = "disabled"; +}; + +&pwm4 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm4>; + status = "disabled"; +}; + +&snvs_pwrkey { + status = "okay"; +}; + +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart1>; + status = "okay"; +}; + +&uart2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart2>; + uart-has-rtscts; + status = "okay"; +}; + +&uart3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart3>; + uart-has-rtscts; + status = "okay"; +}; + +&uart4 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart4>; + status = "disabled"; +}; + +&usb3_phy0 { + vbus-supply = <®_usb0_host_vbus>; + status = "okay"; +}; + +&usb3_phy1 { + vbus-supply = <®_usb1_host_vbus>; + status = "okay"; +}; + +&usb3_0 { + status = "okay"; +}; + +&usb3_1 { + status = "okay"; +}; + +&usb_dwc3_0 { + dr_mode = "otg"; + hnp-disable; + srp-disable; + adp-disable; + extcon = <&extcon_usb0>; + status = "okay"; +}; + +&usb_dwc3_1 { + dr_mode = "host"; + status = "okay"; +}; + +&usdhc2 { + assigned-clocks = <&clk IMX8MP_CLK_USDHC2>; + assigned-clock-rates = <400000000>; + pinctrl-names = "default", "state_100mhz", "state_200mhz"; + pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>; + pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>; + pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>; + cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio2 20 GPIO_ACTIVE_HIGH>; + bus-width = <4>; + vmmc-supply = <®_usdhc2_vmmc>; + status = "okay"; +}; + +&usdhc3 { + assigned-clocks = <&clk IMX8MP_CLK_USDHC3>; + assigned-clock-rates = <400000000>; + pinctrl-names = "default", "state_100mhz", "state_200mhz"; + pinctrl-0 = <&pinctrl_usdhc3>; + pinctrl-1 = <&pinctrl_usdhc3_100mhz>; + pinctrl-2 = <&pinctrl_usdhc3_200mhz>; + bus-width = <8>; + non-removable; + status = "okay"; +}; + +&wdog1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_wdog>; + fsl,ext-reset-output; + status = "okay"; +}; + +&iomuxc { + pinctrl_ecspi1: ecspi1grp { + fsl,pins = + <MX8MP_IOMUXC_ECSPI1_MISO__ECSPI1_MISO 0x82>, + <MX8MP_IOMUXC_ECSPI1_MOSI__ECSPI1_MOSI 0x82>, + <MX8MP_IOMUXC_ECSPI1_SCLK__ECSPI1_SCLK 0x82>, + <MX8MP_IOMUXC_ECSPI1_SS0__ECSPI1_SS0 0x40000>, + <MX8MP_IOMUXC_SD1_DATA6__GPIO2_IO08 0x40000>; + }; + + pinctrl_ecspi2: ecspi2grp { + fsl,pins = + <MX8MP_IOMUXC_ECSPI2_MISO__ECSPI2_MISO 0x82>, + <MX8MP_IOMUXC_ECSPI2_MOSI__ECSPI2_MOSI 0x82>, + <MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x82>, + <MX8MP_IOMUXC_ECSPI2_SS0__ECSPI2_SS0 0x40000>, + <MX8MP_IOMUXC_SD1_DATA7__GPIO2_IO09 0x40000>; + }; + + pinctrl_eqos: eqosgrp { + fsl,pins = + <MX8MP_IOMUXC_ENET_MDC__ENET_QOS_MDC 0x3>, + <MX8MP_IOMUXC_ENET_MDIO__ENET_QOS_MDIO 0x3>, + <MX8MP_IOMUXC_ENET_RD0__ENET_QOS_RGMII_RD0 0x91>, + <MX8MP_IOMUXC_ENET_RD1__ENET_QOS_RGMII_RD1 0x91>, + <MX8MP_IOMUXC_ENET_RD2__ENET_QOS_RGMII_RD2 0x91>, + <MX8MP_IOMUXC_ENET_RD3__ENET_QOS_RGMII_RD3 0x91>, + <MX8MP_IOMUXC_ENET_RXC__CCM_ENET_QOS_CLOCK_GENERATE_RX_CLK 0x91>, + <MX8MP_IOMUXC_ENET_RX_CTL__ENET_QOS_RGMII_RX_CTL 0x91>, + <MX8MP_IOMUXC_ENET_TD0__ENET_QOS_RGMII_TD0 0x1f>, + <MX8MP_IOMUXC_ENET_TD1__ENET_QOS_RGMII_TD1 0x1f>, + <MX8MP_IOMUXC_ENET_TD2__ENET_QOS_RGMII_TD2 0x1f>, + <MX8MP_IOMUXC_ENET_TD3__ENET_QOS_RGMII_TD3 0x1f>, + <MX8MP_IOMUXC_ENET_TX_CTL__ENET_QOS_RGMII_TX_CTL 0x1f>, + <MX8MP_IOMUXC_ENET_TXC__CCM_ENET_QOS_CLOCK_GENERATE_TX_CLK 0x1f>; + }; + + pinctrl_fec: fecgrp { + fsl,pins = + <MX8MP_IOMUXC_SAI1_RXD2__ENET1_MDC 0x3>, + <MX8MP_IOMUXC_SAI1_RXD3__ENET1_MDIO 0x3>, + <MX8MP_IOMUXC_SAI1_RXD4__ENET1_RGMII_RD0 0x91>, + <MX8MP_IOMUXC_SAI1_RXD5__ENET1_RGMII_RD1 0x91>, + <MX8MP_IOMUXC_SAI1_RXD6__ENET1_RGMII_RD2 0x91>, + <MX8MP_IOMUXC_SAI1_RXD7__ENET1_RGMII_RD3 0x91>, + <MX8MP_IOMUXC_SAI1_TXC__ENET1_RGMII_RXC 0x91>, + <MX8MP_IOMUXC_SAI1_TXFS__ENET1_RGMII_RX_CTL 0x91>, + <MX8MP_IOMUXC_SAI1_TXD0__ENET1_RGMII_TD0 0x1f>, + <MX8MP_IOMUXC_SAI1_TXD1__ENET1_RGMII_TD1 0x1f>, + <MX8MP_IOMUXC_SAI1_TXD2__ENET1_RGMII_TD2 0x1f>, + <MX8MP_IOMUXC_SAI1_TXD3__ENET1_RGMII_TD3 0x1f>, + <MX8MP_IOMUXC_SAI1_TXD4__ENET1_RGMII_TX_CTL 0x1f>, + <MX8MP_IOMUXC_SAI1_TXD5__ENET1_RGMII_TXC 0x1f>; + }; + + pinctrl_flexcan1: flexcan1grp { + fsl,pins = + <MX8MP_IOMUXC_SAI5_RXD1__CAN1_TX 0x154>, + <MX8MP_IOMUXC_SAI5_RXD2__CAN1_RX 0x154>; + }; + + pinctrl_flexcan2: flexcan2grp { + fsl,pins = + <MX8MP_IOMUXC_SAI5_MCLK__CAN2_RX 0x154>, + <MX8MP_IOMUXC_SAI5_RXD3__CAN2_TX 0x154>; + }; + + pinctrl_flexspi0: flexspi0grp { + fsl,pins = + <MX8MP_IOMUXC_NAND_ALE__FLEXSPI_A_SCLK 0x1c2>, + <MX8MP_IOMUXC_NAND_CE0_B__FLEXSPI_A_SS0_B 0x82>, + <MX8MP_IOMUXC_NAND_DATA00__FLEXSPI_A_DATA00 0x82>, + <MX8MP_IOMUXC_NAND_DATA01__FLEXSPI_A_DATA01 0x82>, + <MX8MP_IOMUXC_NAND_DATA02__FLEXSPI_A_DATA02 0x82>, + <MX8MP_IOMUXC_NAND_DATA03__FLEXSPI_A_DATA03 0x82>, + <MX8MP_IOMUXC_NAND_DQS__GPIO3_IO14 0x19>; + }; + + pinctrl_i2c1: i2c1grp { + fsl,pins = + <MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL 0x400001c3>, + <MX8MP_IOMUXC_I2C1_SDA__I2C1_SDA 0x400001c3>; + }; + + pinctrl_i2c2: i2c2grp { + fsl,pins = + <MX8MP_IOMUXC_I2C2_SCL__I2C2_SCL 0x400001c3>, + <MX8MP_IOMUXC_I2C2_SDA__I2C2_SDA 0x400001c3>; + }; + + pinctrl_i2c3: i2c3grp { + fsl,pins = + <MX8MP_IOMUXC_I2C3_SCL__I2C3_SCL 0x400001c3>, + <MX8MP_IOMUXC_I2C3_SDA__I2C3_SDA 0x400001c3>; + }; + + pinctrl_i2c4: i2c4grp { + fsl,pins = + <MX8MP_IOMUXC_I2C4_SCL__I2C4_SCL 0x400001c3>, + <MX8MP_IOMUXC_I2C4_SDA__I2C4_SDA 0x400001c3>; + }; + + pinctrl_i2c5: i2c5grp { + fsl,pins = + <MX8MP_IOMUXC_SPDIF_TX__I2C5_SCL 0x400001c3>, + <MX8MP_IOMUXC_SPDIF_RX__I2C5_SDA 0x400001c3>; + }; + + pinctrl_i2c6: i2c6grp { + fsl,pins = + <MX8MP_IOMUXC_SAI5_RXFS__I2C6_SCL 0x400001c3>, + <MX8MP_IOMUXC_SAI5_RXC__I2C6_SDA 0x400001c3>; + }; + + pinctrl_lcd0_backlight: lcd0-backlightgrp { + fsl,pins = + <MX8MP_IOMUXC_GPIO1_IO05__GPIO1_IO05 0x41>; + }; + + pinctrl_lcd1_backlight: lcd1-backlightgrp { + fsl,pins = + <MX8MP_IOMUXC_GPIO1_IO06__GPIO1_IO06 0x41>; + }; + + pinctrl_leds: ledsgrp { + fsl,pins = + <MX8MP_IOMUXC_GPIO1_IO08__GPIO1_IO08 0x19>; + }; + + pinctrl_lvds_bridge: lvds-bridgegrp { + fsl,pins = + <MX8MP_IOMUXC_GPIO1_IO07__GPIO1_IO07 0x41>; + }; + + pinctrl_pwm1: pwm1grp { + fsl,pins = + <MX8MP_IOMUXC_SPDIF_EXT_CLK__PWM1_OUT 0x116>; + }; + + pinctrl_pwm2: pwm2grp { + fsl,pins = + <MX8MP_IOMUXC_SAI5_RXD0__PWM2_OUT 0x116>; + }; + + pinctrl_pwm3: pwm3grp { + fsl,pins = + <MX8MP_IOMUXC_GPIO1_IO10__PWM3_OUT 0x116>; + }; + + pinctrl_pwm4: pwm4grp { + fsl,pins = + <MX8MP_IOMUXC_SAI3_MCLK__PWM4_OUT 0x116>; + }; + + pinctrl_tca6424: tca6424grp { + fsl,pins = + <MX8MP_IOMUXC_GPIO1_IO09__GPIO1_IO09 0x41>; + }; + + pinctrl_uart1: uart1grp { + fsl,pins = + <MX8MP_IOMUXC_UART1_RXD__UART1_DCE_RX 0x49>, + <MX8MP_IOMUXC_UART1_TXD__UART1_DCE_TX 0x49>; + }; + + pinctrl_uart2: uart2grp { + fsl,pins = + <MX8MP_IOMUXC_SD1_DATA4__GPIO2_IO06 0x1c4>, + <MX8MP_IOMUXC_SD1_DATA5__GPIO2_IO07 0x1c4>, + <MX8MP_IOMUXC_UART2_RXD__UART2_DCE_RX 0x49>, + <MX8MP_IOMUXC_UART2_TXD__UART2_DCE_TX 0x49>; + }; + + pinctrl_uart3: uart3grp { + fsl,pins = + <MX8MP_IOMUXC_SD1_RESET_B__GPIO2_IO10 0x1c4>, + <MX8MP_IOMUXC_SD1_STROBE__GPIO2_IO11 0x1c4>, + <MX8MP_IOMUXC_UART3_RXD__UART3_DCE_RX 0x49>, + <MX8MP_IOMUXC_UART3_TXD__UART3_DCE_TX 0x49>; + }; + + pinctrl_uart4: uart4grp { + fsl,pins = + <MX8MP_IOMUXC_UART4_RXD__UART4_DCE_RX 0x49>, + <MX8MP_IOMUXC_UART4_TXD__UART4_DCE_TX 0x49>; + }; + + pinctrl_usb0_extcon: usb0-extcongrp { + fsl,pins = + <MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03 0x19>; + }; + + pinctrl_usb0_vbus: usb0-vbusgrp { + fsl,pins = + <MX8MP_IOMUXC_GPIO1_IO12__GPIO1_IO12 0x19>; + }; + + pinctrl_usb1_vbus: usb1-vbusgrp { + fsl,pins = + <MX8MP_IOMUXC_GPIO1_IO14__GPIO1_IO14 0x19>; + }; + + pinctrl_usdhc2_gpio: usdhc2-gpiogrp { + fsl,pins = + <MX8MP_IOMUXC_SD2_CD_B__GPIO2_IO12 0x1c4>, + <MX8MP_IOMUXC_SD2_WP__GPIO2_IO20 0x1c4>; + }; + + pinctrl_usdhc2: usdhc2grp { + fsl,pins = + <MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK 0x190>, + <MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD 0x1d0>, + <MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0 0x1d0>, + <MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1 0x1d0>, + <MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2 0x1d0>, + <MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3 0x1d0>, + <MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT 0xc1>; + }; + + pinctrl_usdhc2_vmmc: usdhc2-vmmcgrp { + fsl,pins = + <MX8MP_IOMUXC_SD2_RESET_B__GPIO2_IO19 0x41>; + }; + + pinctrl_usdhc2_100mhz: usdhc2-100mhzgrp { + fsl,pins = + <MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK 0x194>, + <MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD 0x1d4>, + <MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0 0x1d4>, + <MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1 0x1d4>, + <MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2 0x1d4>, + <MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3 0x1d4>, + <MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT 0xc1>; + }; + + pinctrl_usdhc2_200mhz: usdhc2-200mhzgrp { + fsl,pins = + <MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK 0x196>, + <MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD 0x1d6>, + <MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0 0x1d6>, + <MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1 0x1d6>, + <MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2 0x1d6>, + <MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3 0x1d6>, + <MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT 0xc1>; + }; + + pinctrl_usdhc3: usdhc3grp { + fsl,pins = + <MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK 0x190>, + <MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD 0x1d0>, + <MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0 0x1d0>, + <MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1 0x1d0>, + <MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2 0x1d0>, + <MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3 0x1d0>, + <MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4 0x1d0>, + <MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5 0x1d0>, + <MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6 0x1d0>, + <MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7 0x1d0>, + <MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE 0x190>; + }; + + pinctrl_usdhc3_100mhz: usdhc3-100mhzgrp { + fsl,pins = + <MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK 0x194>, + <MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD 0x1d4>, + <MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0 0x1d4>, + <MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1 0x1d4>, + <MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2 0x1d4>, + <MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3 0x1d4>, + <MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4 0x1d4>, + <MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5 0x1d4>, + <MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6 0x1d4>, + <MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7 0x1d4>, + <MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE 0x194>; + }; + + pinctrl_usdhc3_200mhz: usdhc3-200mhzgrp { + fsl,pins = + <MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK 0x196>, + <MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD 0x1d6>, + <MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0 0x1d6>, + <MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1 0x1d6>, + <MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2 0x1d6>, + <MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3 0x1d6>, + <MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4 0x1d6>, + <MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5 0x1d6>, + <MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6 0x1d6>, + <MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7 0x1d6>, + <MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE 0x196>; + }; + + pinctrl_wdog: wdoggrp { + fsl,pins = + <MX8MP_IOMUXC_GPIO1_IO02__WDOG1_WDOG_B 0xc6>; + }; +}; -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: imx8mp-msc-sm2s: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board 2022-08-12 8:41 ` [PATCH v4 2/2] arm64: dts: imx8mp-msc-sm2s: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board Martyn Welch @ 2022-08-12 9:47 ` Krzysztof Kozlowski 2022-08-12 11:35 ` Martyn Welch 0 siblings, 1 reply; 8+ messages in thread From: Krzysztof Kozlowski @ 2022-08-12 9:47 UTC (permalink / raw) To: Martyn Welch, Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team Cc: kernel, devicetree, linux-kernel, linux-arm-kernel On 12/08/2022 11:41, Martyn Welch wrote: > Add device trees for one of a number of MSC's (parent company, Avnet) > variants of the SM2S-IMX8PLUS system on module along with the compatible > SM2S-SK-AL-EP1 carrier board. As the name suggests, this family of SoMs use > the NXP i.MX8MP SoC and provide the SMARC module interface. > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > --- > > Changes in v2 > - Added compatibles > - Removed underscores from node names > - Make node names more generic > - Reorder properties > - Fix issues found by dtbs_check in these files > > Changes in v3: > - Switched to avnet vendor string in compatibles > - Corrected patch description > > Changes in v4: > - Switched from phy-reset-gpios to reset-gpios, removing duplication > - Removed unneeded sdma1 node > > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../freescale/imx8mp-msc-sm2s-14N0600E.dts | 72 ++ > .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 53 ++ > .../boot/dts/freescale/imx8mp-msc-sm2s.dtsi | 812 ++++++++++++++++++ > 4 files changed, 938 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s.dtsi > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 8bf7f7ecebaa..139c8b95c9c9 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice-gw7902.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts > new file mode 100644 > index 000000000000..9e976e8baaee > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts > @@ -0,0 +1,72 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2022 Avnet Embedded GmbH > + */ > +/dts-v1/; > + > +#include "imx8mp-msc-sm2s.dtsi" > + > +/ { > + model = "MSC SM2S-IMX8PLUS-QC6-14N0600E SoM"; > + compatible = "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp", > + "fsl,imx8mp"; This does not match your bindings. Please test your DTS. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: imx8mp-msc-sm2s: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board 2022-08-12 9:47 ` Krzysztof Kozlowski @ 2022-08-12 11:35 ` Martyn Welch 2022-08-12 13:42 ` Krzysztof Kozlowski 0 siblings, 1 reply; 8+ messages in thread From: Martyn Welch @ 2022-08-12 11:35 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team Cc: kernel, devicetree, linux-kernel, linux-arm-kernel On Fri, 2022-08-12 at 12:47 +0300, Krzysztof Kozlowski wrote: > On 12/08/2022 11:41, Martyn Welch wrote: > > Add device trees for one of a number of MSC's (parent company, > > Avnet) > > variants of the SM2S-IMX8PLUS system on module along with the > > compatible > > SM2S-SK-AL-EP1 carrier board. As the name suggests, this family of > > SoMs use > > the NXP i.MX8MP SoC and provide the SMARC module interface. > > > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > > --- > > > > Changes in v2 > > - Added compatibles > > - Removed underscores from node names > > - Make node names more generic > > - Reorder properties > > - Fix issues found by dtbs_check in these files > > > > Changes in v3: > > - Switched to avnet vendor string in compatibles > > - Corrected patch description > > > > Changes in v4: > > - Switched from phy-reset-gpios to reset-gpios, removing > > duplication > > - Removed unneeded sdma1 node > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../freescale/imx8mp-msc-sm2s-14N0600E.dts | 72 ++ > > .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 53 ++ > > .../boot/dts/freescale/imx8mp-msc-sm2s.dtsi | 812 > > ++++++++++++++++++ > > 4 files changed, 938 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > 14N0600E.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > ep1.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc- > > sm2s.dtsi > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > b/arch/arm64/boot/dts/freescale/Makefile > > index 8bf7f7ecebaa..139c8b95c9c9 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice- > > gw7902.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > 14N0600E.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > 14N0600E.dts > > new file mode 100644 > > index 000000000000..9e976e8baaee > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts > > @@ -0,0 +1,72 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2022 Avnet Embedded GmbH > > + */ > > +/dts-v1/; > > + > > +#include "imx8mp-msc-sm2s.dtsi" > > + > > +/ { > > + model = "MSC SM2S-IMX8PLUS-QC6-14N0600E SoM"; > > + compatible = "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s- > > imx8mp", > > + "fsl,imx8mp"; > > This does not match your bindings. Please test your DTS. > Hi Krzysztof, I'm not sure I follow. This is the DTS for the SoM. The only way I can test the SoM at the moment is on combination with the "EP1" carrier board. That has been tested. The strings match those specified in the bindings unless I'm being blind to something. I guess I can build the DTB for just the SoM and boot with that or thinking about it, rename this as a .dtsi, given that it's unlikely that anyone is going to have a carrier barebones enough that it could be considered just the SoM? Martyn > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: imx8mp-msc-sm2s: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board 2022-08-12 11:35 ` Martyn Welch @ 2022-08-12 13:42 ` Krzysztof Kozlowski 2022-08-12 15:03 ` Martyn Welch 0 siblings, 1 reply; 8+ messages in thread From: Krzysztof Kozlowski @ 2022-08-12 13:42 UTC (permalink / raw) To: Martyn Welch, Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team Cc: kernel, devicetree, linux-kernel, linux-arm-kernel On 12/08/2022 14:35, Martyn Welch wrote: > On Fri, 2022-08-12 at 12:47 +0300, Krzysztof Kozlowski wrote: >> On 12/08/2022 11:41, Martyn Welch wrote: >>> Add device trees for one of a number of MSC's (parent company, >>> Avnet) >>> variants of the SM2S-IMX8PLUS system on module along with the >>> compatible >>> SM2S-SK-AL-EP1 carrier board. As the name suggests, this family of >>> SoMs use >>> the NXP i.MX8MP SoC and provide the SMARC module interface. >>> >>> Signed-off-by: Martyn Welch <martyn.welch@collabora.com> >>> --- >>> >>> Changes in v2 >>> - Added compatibles >>> - Removed underscores from node names >>> - Make node names more generic >>> - Reorder properties >>> - Fix issues found by dtbs_check in these files >>> >>> Changes in v3: >>> - Switched to avnet vendor string in compatibles >>> - Corrected patch description >>> >>> Changes in v4: >>> - Switched from phy-reset-gpios to reset-gpios, removing >>> duplication >>> - Removed unneeded sdma1 node >>> >>> arch/arm64/boot/dts/freescale/Makefile | 1 + >>> .../freescale/imx8mp-msc-sm2s-14N0600E.dts | 72 ++ >>> .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 53 ++ >>> .../boot/dts/freescale/imx8mp-msc-sm2s.dtsi | 812 >>> ++++++++++++++++++ >>> 4 files changed, 938 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- >>> 14N0600E.dts >>> create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- >>> ep1.dts >>> create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc- >>> sm2s.dtsi >>> >>> diff --git a/arch/arm64/boot/dts/freescale/Makefile >>> b/arch/arm64/boot/dts/freescale/Makefile >>> index 8bf7f7ecebaa..139c8b95c9c9 100644 >>> --- a/arch/arm64/boot/dts/freescale/Makefile >>> +++ b/arch/arm64/boot/dts/freescale/Makefile >>> @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice- >>> gw7902.dtb >>> dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb >>> dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb >>> dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb >>> +dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb >>> dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb >>> dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb >>> dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- >>> 14N0600E.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- >>> 14N0600E.dts >>> new file mode 100644 >>> index 000000000000..9e976e8baaee >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts >>> @@ -0,0 +1,72 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Copyright (C) 2022 Avnet Embedded GmbH >>> + */ >>> +/dts-v1/; >>> + >>> +#include "imx8mp-msc-sm2s.dtsi" >>> + >>> +/ { >>> + model = "MSC SM2S-IMX8PLUS-QC6-14N0600E SoM"; >>> + compatible = "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s- >>> imx8mp", >>> + "fsl,imx8mp"; >> >> This does not match your bindings. Please test your DTS. >> > > Hi Krzysztof, > > I'm not sure I follow. This is the DTS for the SoM. SoMs usually do not have DTSes because they cannot be run on their own. SoMs almost always require a baseboard/carrier. Therefore this should not be DTS, but that was not my comment. > The only way I can > test the SoM at the moment is on combination with the "EP1" carrier > board. ... so you basically say it cannot be a DTS. > That has been tested. The strings match those specified in the > bindings unless I'm being blind to something. Test the DTS - make dtbs_check (there are several variations/arguments/helpers): Documentation/devicetree/bindings/writing-schema.rst > > I guess I can build the DTB for just the SoM But you just did it, didn't you? This is a DTS. > and boot with that or > thinking about it, rename this as a .dtsi, given that it's unlikely > that anyone is going to have a carrier barebones enough that it could > be considered just the SoM? Anyway, I wanted DT bindings tests for DTS. Not actual tests on hardware, because the compatibles do not matter in that aspect. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: imx8mp-msc-sm2s: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board 2022-08-12 13:42 ` Krzysztof Kozlowski @ 2022-08-12 15:03 ` Martyn Welch 2022-08-12 17:31 ` Krzysztof Kozlowski 0 siblings, 1 reply; 8+ messages in thread From: Martyn Welch @ 2022-08-12 15:03 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team Cc: kernel, devicetree, linux-kernel, linux-arm-kernel On Fri, 2022-08-12 at 16:42 +0300, Krzysztof Kozlowski wrote: > On 12/08/2022 14:35, Martyn Welch wrote: > > On Fri, 2022-08-12 at 12:47 +0300, Krzysztof Kozlowski wrote: > > > On 12/08/2022 11:41, Martyn Welch wrote: > > > > Add device trees for one of a number of MSC's (parent company, > > > > Avnet) > > > > variants of the SM2S-IMX8PLUS system on module along with the > > > > compatible > > > > SM2S-SK-AL-EP1 carrier board. As the name suggests, this family > > > > of > > > > SoMs use > > > > the NXP i.MX8MP SoC and provide the SMARC module interface. > > > > > > > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > > > > --- > > > > > > > > Changes in v2 > > > > - Added compatibles > > > > - Removed underscores from node names > > > > - Make node names more generic > > > > - Reorder properties > > > > - Fix issues found by dtbs_check in these files > > > > > > > > Changes in v3: > > > > - Switched to avnet vendor string in compatibles > > > > - Corrected patch description > > > > > > > > Changes in v4: > > > > - Switched from phy-reset-gpios to reset-gpios, removing > > > > duplication > > > > - Removed unneeded sdma1 node > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > > .../freescale/imx8mp-msc-sm2s-14N0600E.dts | 72 ++ > > > > .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 53 ++ > > > > .../boot/dts/freescale/imx8mp-msc-sm2s.dtsi | 812 > > > > ++++++++++++++++++ > > > > 4 files changed, 938 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc- > > > > sm2s- > > > > 14N0600E.dts > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc- > > > > sm2s- > > > > ep1.dts > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc- > > > > sm2s.dtsi > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > > > b/arch/arm64/boot/dts/freescale/Makefile > > > > index 8bf7f7ecebaa..139c8b95c9c9 100644 > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice- > > > > gw7902.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > > > 14N0600E.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > > > 14N0600E.dts > > > > new file mode 100644 > > > > index 000000000000..9e976e8baaee > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > > > 14N0600E.dts > > > > @@ -0,0 +1,72 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > +/* > > > > + * Copyright (C) 2022 Avnet Embedded GmbH > > > > + */ > > > > +/dts-v1/; > > > > + > > > > +#include "imx8mp-msc-sm2s.dtsi" > > > > + > > > > +/ { > > > > + model = "MSC SM2S-IMX8PLUS-QC6-14N0600E SoM"; > > > > + compatible = "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s- > > > > imx8mp", > > > > + "fsl,imx8mp"; > > > > > > This does not match your bindings. Please test your DTS. > > > > > > > Hi Krzysztof, > > > > I'm not sure I follow. This is the DTS for the SoM. > > SoMs usually do not have DTSes because they cannot be run on their > own. > SoMs almost always require a baseboard/carrier. Therefore this should > not be DTS, but that was not my comment. > OK, so does making this as dtsi resolve the issue for you? I assume as a dtsi I would also need to remove the model and compatible? > > The only way I can > > test the SoM at the moment is on combination with the "EP1" carrier > > board. > > ... so you basically say it cannot be a DTS. > > > That has been tested. The strings match those specified in the > > bindings unless I'm being blind to something. > > Test the DTS - make dtbs_check (there are several > variations/arguments/helpers): > Documentation/devicetree/bindings/writing-schema.rst > Yep, ran that. > > > > I guess I can build the DTB for just the SoM > > But you just did it, didn't you? This is a DTS. > As you can see from the patch, I didn't add that file directly to the Makefile, so dtbs_check didn't check it directly. > > > > and boot with that or > > thinking about it, rename this as a .dtsi, given that it's unlikely > > that anyone is going to have a carrier barebones enough that it > > could > > be considered just the SoM? > > Anyway, I wanted DT bindings tests for DTS. Not actual tests on > hardware, because the compatibles do not matter in that aspect. > The tests threw quite a few errors that seemed to be related to the imx8mp.dtsi. The only ones that seemed to be related to the files I've created seem to be the result of including optional pins in the pin muxing, which need to be there AFAIK, but seem to be resulting in warnings from the tool. Martyn > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: imx8mp-msc-sm2s: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board 2022-08-12 15:03 ` Martyn Welch @ 2022-08-12 17:31 ` Krzysztof Kozlowski 2022-08-15 7:45 ` Martyn Welch 0 siblings, 1 reply; 8+ messages in thread From: Krzysztof Kozlowski @ 2022-08-12 17:31 UTC (permalink / raw) To: Martyn Welch, Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team Cc: kernel, devicetree, linux-kernel, linux-arm-kernel On 12/08/2022 18:03, Martyn Welch wrote: > The tests threw quite a few errors that seemed to be related to the > imx8mp.dtsi. The only ones that seemed to be related to the files I've > created seem to be the result of including optional pins in the pin > muxing, which need to be there AFAIK, but seem to be resulting in > warnings from the tool. Your DTS defined three compatibles which were not documented by the bindings change, therefore I expect the warning from schema. To be sure, I just run it and it is clearly visible: /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed: ['avnet,sm2s-imx8mp-14N0600E', 'avnet,sm2s-imx8mp', 'fsl,imx8mp'] is too long ['avnet,sm2s-imx8mp-14N0600E', 'avnet,sm2s-imx8mp', 'fsl,imx8mp'] is too short It's not possible to miss it, it's the biggest warning... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: imx8mp-msc-sm2s: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board 2022-08-12 17:31 ` Krzysztof Kozlowski @ 2022-08-15 7:45 ` Martyn Welch 2022-08-16 10:11 ` Krzysztof Kozlowski 0 siblings, 1 reply; 8+ messages in thread From: Martyn Welch @ 2022-08-15 7:45 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team Cc: kernel, devicetree, linux-kernel, linux-arm-kernel On Fri, 2022-08-12 at 20:31 +0300, Krzysztof Kozlowski wrote: > On 12/08/2022 18:03, Martyn Welch wrote: > > The tests threw quite a few errors that seemed to be related to the > > imx8mp.dtsi. The only ones that seemed to be related to the files > > I've > > created seem to be the result of including optional pins in the pin > > muxing, which need to be there AFAIK, but seem to be resulting in > > warnings from the tool. > > Your DTS defined three compatibles which were not documented by the > bindings change, therefore I expect the warning from schema. > > To be sure, I just run it and it is clearly visible: > > /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/freescale/imx8mp- > msc-sm2s-14N0600E.dtb: > /: compatible: 'oneOf' conditional failed, one must be fixed: > > ['avnet,sm2s-imx8mp-14N0600E', 'avnet,sm2s-imx8mp', > 'fsl,imx8mp'] is > too long > > ['avnet,sm2s-imx8mp-14N0600E', 'avnet,sm2s-imx8mp', > 'fsl,imx8mp'] is > too short > > > It's not possible to miss it, it's the biggest warning... > This is the sum total of what I'm getting when running it: $ make dtbs_check warning: python package 'yamllint' not installed, skipping CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb CHECK arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: ecspi1grp:fsl,pins:0: [488, 1096, 1372, 0, 0, 130, 484, 1092, 1376, 0, 0, 130, 480, 1088, 1368, 0, 0, 130, 492, 1100, 1380, 0, 0, 262144, 172, 780, 0, 5, 0, 262144] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: ecspi2grp:fsl,pins:0: [504, 1112, 1388, 0, 1, 130, 500, 1108, 1392, 0, 1, 130, 496, 1104, 1384, 0, 1, 130, 508, 1116, 1396, 0, 1, 262144, 176, 784, 0, 5, 0, 262144] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: eqosgrp:fsl,pins:0: [84, 692, 0, 0, 0, 3, 88, 696, 1424, 0, 1, 3, 124, 732, 0, 0, 0, 145, 128, 736, 0, 0, 0, 145, 132, 740, 0, 0, 0, 145, 136, 744, 0, 0, 0, 145, 120, 728, 0, 0, 0, 145, 116, 724, 0, 0, 0, 145, 104, 712, 0, 0, 0, 31, 100, 708, 0, 0, 0, 31, 96, 704, 0, 0, 0, 31, 92, 700, 0, 0, 0, 31, 108, 716, 0, 0, 0, 31, 112, 720, 0, 0, 0, 31] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: fecgrp:fsl,pins:0: [344, 952, 0, 4, 0, 3, 348, 956, 1404, 4, 1, 3, 352, 960, 1408, 4, 1, 145, 356, 964, 1412, 4, 1, 145, 360, 968, 0, 4, 0, 145, 364, 972, 0, 4, 0, 145, 372, 980, 0, 4, 0, 145, 368, 976, 1416, 4, 1, 145, 376, 984, 0, 4, 0, 31, 380, 988, 0, 4, 0, 31, 384, 992, 0, 4, 0, 31, 388, 996, 0, 4, 0, 31, 392, 1000, 0, 4, 0, 31, 396, 1004, 0, 4, 0, 31] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: flexcan1grp:fsl,pins:0: [312, 920, 0, 6, 0, 340, 316, 924, 1356, 6, 0, 340] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: flexcan2grp:fsl,pins:0: [324, 932, 1360, 6, 0, 340, 320, 928, 0, 6, 0, 340] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: flexspi0grp:fsl,pins:0: [224, 832, 0, 1, 0, 450, 228, 836, 0, 1, 0, 130, 248, 856, 0, 1, 0, 130, 252, 860, 0, 1, 0, 130, 256, 864, 0, 1, 0, 130, 260, 868, 0, 1, 0, 130, 280, 888, 0, 5, 0, 25] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: i2c1grp:fsl,pins:0: [512, 1120, 1444, 0, 2, 1073742275, 516, 1124, 1448, 0, 2, 1073742275] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: i2c2grp:fsl,pins:0: [520, 1128, 1452, 0, 2, 1073742275, 524, 1132, 1456, 0, 2, 1073742275] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: i2c3grp:fsl,pins:0: [528, 1136, 1460, 0, 4, 1073742275, 532, 1140, 1464, 0, 4, 1073742275] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: i2c4grp:fsl,pins:0: [536, 1144, 1468, 0, 5, 1073742275, 540, 1148, 1472, 0, 5, 1073742275] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: i2c5grp:fsl,pins:0: [468, 1076, 1476, 2, 2, 1073742275, 472, 1080, 1480, 2, 2, 1073742275] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: i2c6grp:fsl,pins:0: [300, 908, 1484, 3, 1, 1073742275, 304, 912, 1488, 3, 1, 1073742275] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: uart1grp:fsl,pins:0: [544, 1152, 1512, 0, 4, 73, 548, 1156, 0, 0, 0, 73] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: uart2grp:fsl,pins:0: [164, 772, 0, 5, 0, 452, 168, 776, 0, 5, 0, 452, 552, 1160, 1520, 0, 6, 73, 556, 1164, 0, 0, 0, 73] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: uart3grp:fsl,pins:0: [180, 788, 0, 5, 0, 452, 184, 792, 0, 5, 0, 452, 560, 1168, 1528, 0, 6, 73, 564, 1172, 0, 0, 0, 73] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: uart4grp:fsl,pins:0: [568, 1176, 1536, 0, 8, 73, 572, 1180, 0, 0, 0, 73] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc2-gpiogrp:fsl,pins:0: [188, 796, 0, 5, 0, 452, 220, 828, 0, 5, 0, 452] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc2grp:fsl,pins:0: [192, 800, 0, 0, 0, 400, 196, 804, 0, 0, 0, 464, 200, 808, 0, 0, 0, 464, 204, 812, 0, 0, 0, 464, 208, 816, 0, 0, 0, 464, 212, 820, 0, 0, 0, 464, 36, 644, 0, 1, 0, 193] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc2-100mhzgrp:fsl,pins:0: [192, 800, 0, 0, 0, 404, 196, 804, 0, 0, 0, 468, 200, 808, 0, 0, 0, 468, 204, 812, 0, 0, 0, 468, 208, 816, 0, 0, 0, 468, 212, 820, 0, 0, 0, 468, 36, 644, 0, 1, 0, 193] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc2-200mhzgrp:fsl,pins:0: [192, 800, 0, 0, 0, 406, 196, 804, 0, 0, 0, 470, 200, 808, 0, 0, 0, 470, 204, 812, 0, 0, 0, 470, 208, 816, 0, 0, 0, 470, 212, 820, 0, 0, 0, 470, 36, 644, 0, 1, 0, 193] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc3grp:fsl,pins:0: [292, 900, 1540, 2, 1, 400, 296, 904, 1548, 2, 1, 464, 264, 872, 1552, 2, 1, 464, 268, 876, 1556, 2, 1, 464, 272, 880, 1560, 2, 1, 464, 276, 884, 1564, 2, 1, 464, 284, 892, 1568, 2, 1, 464, 236, 844, 1572, 2, 1, 464, 240, 848, 1576, 2, 1, 464, 244, 852, 1580, 2, 1, 464, 232, 840, 1584, 2, 1, 400] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc3-100mhzgrp:fsl,pins:0: [292, 900, 1540, 2, 1, 404, 296, 904, 1548, 2, 1, 468, 264, 872, 1552, 2, 1, 468, 268, 876, 1556, 2, 1, 468, 272, 880, 1560, 2, 1, 468, 276, 884, 1564, 2, 1, 468, 284, 892, 1568, 2, 1, 468, 236, 844, 1572, 2, 1, 468, 240, 848, 1576, 2, 1, 468, 244, 852, 1580, 2, 1, 468, 232, 840, 1584, 2, 1, 404] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc3-200mhzgrp:fsl,pins:0: [292, 900, 1540, 2, 1, 406, 296, 904, 1548, 2, 1, 470, 264, 872, 1552, 2, 1, 470, 268, 876, 1556, 2, 1, 470, 272, 880, 1560, 2, 1, 470, 276, 884, 1564, 2, 1, 470, 284, 892, 1568, 2, 1, 470, 236, 844, 1572, 2, 1, 470, 240, 848, 1576, 2, 1, 470, 244, 852, 1580, 2, 1, 470, 232, 840, 1584, 2, 1, 406] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: smarcgpiosgrp:fsl,pins:0: [64, 672, 0, 0, 0, 25, 332, 940, 0, 5, 0, 25, 336, 944, 0, 5, 0, 25, 340, 948, 0, 5, 0, 25, 444, 1052, 0, 5, 0, 25, 464, 1072, 0, 5, 0, 25, 400, 1008, 0, 5, 0, 25, 60, 668, 0, 0, 0, 25, 408, 1016, 0, 5, 0, 25, 412, 1020, 0, 5, 0, 25, 416, 1024, 0, 5, 0, 25, 440, 1048, 0, 5, 0, 25, 404, 1012, 0, 5, 0, 25, 328, 936, 0, 5, 0, 25] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30000000/iomuxc-gpr@30340000: failed to match any schema with compatible: ['fsl,imx8mp-iomuxc-gpr', 'syscon'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30000000/anatop@30360000: failed to match any schema with compatible: ['fsl,imx8mp-anatop', 'fsl,imx8mm-anatop', 'syscon'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30000000/anatop@30360000: failed to match any schema with compatible: ['fsl,imx8mp-anatop', 'fsl,imx8mm-anatop', 'syscon'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30000000/snvs@30370000: failed to match any schema with compatible: ['fsl,sec-v4.0-mon', 'syscon', 'simple-mfd'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30000000/snvs@30370000/snvs-rtc-lp: failed to match any schema with compatible: ['fsl,sec-v4.0-mon-rtc-lp'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30000000/snvs@30370000/snvs-powerkey: failed to match any schema with compatible: ['fsl,sec-v4.0-pwrkey'] /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: gpc@303a0000: 'oneOf' conditional failed, one must be fixed: 'interrupts' is a required property 'interrupts-extended' is a required property From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30800000/crypto@30900000: failed to match any schema with compatible: ['fsl,sec-v4.0'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30800000/crypto@30900000/jr@1000: failed to match any schema with compatible: ['fsl,sec-v4.0-job-ring'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30800000/crypto@30900000/jr@2000: failed to match any schema with compatible: ['fsl,sec-v4.0-job-ring'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30800000/crypto@30900000/jr@3000: failed to match any schema with compatible: ['fsl,sec-v4.0-job-ring'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30800000/dma-controller@30bd0000: failed to match any schema with compatible: ['fsl,imx8mp-sdma', 'fsl,imx8mq-sdma'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30800000/dma-controller@30bd0000: failed to match any schema with compatible: ['fsl,imx8mp-sdma', 'fsl,imx8mq-sdma'] /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: usb-phy@381f0040: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: usb@32f10100: 'power-domains' does not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+' From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: usb-phy@382f0040: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: usb@32f10108: 'power-domains' does not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+' From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /extcon- usb0: failed to match any schema with compatible: ['linux,extcon-usb- gpio'] Unless I'm missing something, that's all from dtsi I'm including, not from the files I'm trying to add (with the possible exception of the tools not understanding that pinctrl nodes might have optional entities in them. Do you have patch 1 of the series in your tree?: https://lore.kernel.org/linux-devicetree/20220812084120.376042-1-martyn.welch@collabora.com/ I thought that was exactly what that was doing... Martyn > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: imx8mp-msc-sm2s: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board 2022-08-15 7:45 ` Martyn Welch @ 2022-08-16 10:11 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2022-08-16 10:11 UTC (permalink / raw) To: Martyn Welch, Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team Cc: kernel, devicetree, linux-kernel, linux-arm-kernel On 15/08/2022 10:45, Martyn Welch wrote: > From schema: /home/martyn/Documents/geh0003/linux- > upstream/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml > /home/martyn/Documents/geh0003/linux- > upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: > usb@32f10108: 'power-domains' does not match any of the regexes: > '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+' > From schema: /home/martyn/Documents/geh0003/linux- > upstream/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /extcon- > usb0: failed to match any schema with compatible: ['linux,extcon-usb- > gpio'] > > > Unless I'm missing something, that's all from dtsi I'm including, not > from the files I'm trying to add (with the possible exception of the > tools not understanding that pinctrl nodes might have optional entities > in them. > > Do you have patch 1 of the series in your tree?: > > https://lore.kernel.org/linux-devicetree/20220812084120.376042-1-martyn.welch@collabora.com/ > > I thought that was exactly what that was doing... I have it and when you read it you should notice it won't work for your case. You define one set of compatibles and implement something a bit else. Regardless whether you see the error or not, the bindings must match your DTS. Here anyway the DTS will be gone, so no errors... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-08-16 10:13 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220812084120.376042-1-martyn.welch@collabora.com>
2022-08-12 8:41 ` [PATCH v4 2/2] arm64: dts: imx8mp-msc-sm2s: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board Martyn Welch
2022-08-12 9:47 ` Krzysztof Kozlowski
2022-08-12 11:35 ` Martyn Welch
2022-08-12 13:42 ` Krzysztof Kozlowski
2022-08-12 15:03 ` Martyn Welch
2022-08-12 17:31 ` Krzysztof Kozlowski
2022-08-15 7:45 ` Martyn Welch
2022-08-16 10:11 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).