From: Stephen Boyd <sboyd@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: conor+dt@kernel.org, heiko@sntech.de, kever.yang@rock-chips.com,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
robh+dt@kernel.org, zhangqing@rock-chips.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, huangtao@rock-chips.com,
andy.yan@rock-chips.com
Subject: Re: [PATCH v4 0/4] rockchip: add GATE_LINK
Date: Wed, 25 Oct 2023 14:40:30 -0700 [thread overview]
Message-ID: <dc96dc36c6df1d3bfa3006298e353f39.sboyd@kernel.org> (raw)
In-Reply-To: <20231025194849.4esjw4w2trgalp55@mercury.elektranox.org>
Quoting Sebastian Reichel (2023-10-25 12:48:49)
> Hello Stephen,
>
> On Mon, Oct 23, 2023 at 06:47:17PM -0700, Stephen Boyd wrote:
> > Quoting Elaine Zhang (2023-10-18 00:01:40)
> > > Recent Rockchip SoCs have a new hardware block called Native Interface
> > > Unit (NIU), which gates clocks to devices behind them. These effectively
> > > need two parent clocks.
> > > Use GATE_LINK to handle this.
> >
> > Why can't pm clks be used here? The qcom clk driver has been doing that
> > for some time now.
> >
> > $ git grep pm_clk_add -- drivers/clk/qcom/
>
> Maybe I'm mistaken, but as far as I can tell this is adding the
> dependency on controller level and only works because Qualcomm
> has multiple separate clock controllers. In the Rockchip design
> there is only one platform device.
>
> Note, that the original downstream code from Rockchip actually used
> pm_clk infrastructure by moving these clocks to separate platform
> devices. I changed this when upstreaming the code, since that leaks
> into DT and from DT point of view there should be only one clock
> controller.
>
Why can't the rockchip driver bind to a single device node and make
sub-devices for each clk domain and register clks for those? Maybe it
can use the auxiliary driver infrastructure to do that?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-25 21:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 7:01 [PATCH v4 0/4] rockchip: add GATE_LINK Elaine Zhang
2023-10-18 7:01 ` [PATCH v4 1/4] clk: gate: export clk_gate_endisable Elaine Zhang
2023-10-18 7:01 ` [PATCH v4 2/4] clk: rockchip: add support for gate link Elaine Zhang
2023-10-18 7:01 ` [PATCH v4 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id Elaine Zhang
2023-10-18 7:14 ` Krzysztof Kozlowski
2023-10-18 7:01 ` [PATCH v4 4/4] clk: rockchip: rk3588: Adjust the GATE_LINK parameter Elaine Zhang
2023-10-20 17:42 ` [PATCH v4 0/4] rockchip: add GATE_LINK Sebastian Reichel
2023-10-24 1:47 ` Stephen Boyd
2023-10-25 19:48 ` Sebastian Reichel
2023-10-25 21:40 ` Stephen Boyd [this message]
2023-10-26 2:25 ` zhangqing
2023-10-26 21:29 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc96dc36c6df1d3bfa3006298e353f39.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).