From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2043CC433F5 for ; Wed, 1 Jun 2022 07:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=grEa4on4NQDPAX/rhhxbjVGKvb8wJ14Eoo2dNHn2QQ0=; b=Kt/JLwt7X6o8SD 4JxNL8SKlSQhpGFJ1MovIfLVE4Dda4REW/XSobfXzOgNGQYx1mu4y+ofemdxh1BSbOTUebF44CIo+ 5SbczcpSETEsqF015J/Zf7T7vcYuOyx3Ob8WbN/GZCt+VigRRKZIFokMFtYHrpy6AxU4OeHCMD8GP jnLfQxn0XxEeQIje1LCq+nVV12OYlOcOg5rwE+y8PfZv9BJfpoaQrgK61XqgU40szVnxnPqdYT5fw U7tWRJwhZyDE3xihjMyzJF2sgV0Ivvqmbe8rptjnbkA1nHQlksfcrJpdkB8Kd+VOe1Jr9DgJiEfek kBtMCtoIXmR3rdH4NZNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJ2H-00ES3w-EZ; Wed, 01 Jun 2022 07:44:57 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJ2D-00ES2F-7z for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 07:44:55 +0000 Received: by mail-ej1-x631.google.com with SMTP id me5so1449008ejb.2 for ; Wed, 01 Jun 2022 00:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=MD6HPERyaclpLbVMS6v8zy/sUdA8rjzF4KgrEmNDbGU=; b=hpCDFNGJOfLdJmn4/pwebhNLUcf3UnAL4E7KtosnNifftBSckZy+8V+W8exyq5uoNf +K8F8gNkChRV6cCtAef34O2RWKyl+1wl88ezP006HV4IGJhwGxk0dHHdeuN8C3Rz1YgW maUsuqUnpfkv8UqYhXaBB0ruMIlsPLytNmnG3tfP5Zt0pEtUa55T02LQZS0zkpO2nKi2 ZewDtrUIfnG7yycAPH7sgryG50SuZIFEBErokp6CHB5IYAN+fkYBIeayEQGecgrVt8Xt C98Zv6CoXoorzOjKSH/PawJqhUAq+hg+y5oV0CPUlMSYbNKw0A9vqdWKBD1Y7XuKCsgG wnVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=MD6HPERyaclpLbVMS6v8zy/sUdA8rjzF4KgrEmNDbGU=; b=WU9zT5B9waDCSu8oFTT6Nk0rtz+r3r0iwED34GLvYJpP4wjoD54oVePDMRlrdMkcHN 9ElTpe1NmWS3N+QkNhF3jk5Ed2yzkWA2nj9IVnMuuKkEyxEC7O7BFCaNsMZ55vcYJl+x kNIxYiIDc51ufIMlazrODLl/8ARCvN0BpL53CBtSaXYDLWAT6UzDrb3MqlwajLez1yai cpalhIPWctE8vuQNJIfV1FTl5sflIiobMoA3bJ1uS9JfSsukTnJauRksJoVFDzAS8iTH xAV/CeCMkkhQNYGCty00VF7hnBiUjg95ahRZHo2MPGWCoYoJifPEccBAHNIhmvogmXOD cNwA== X-Gm-Message-State: AOAM530Ee9bzQqTX7NUBmL7dSDxvi3//9NYEZSjdCXXsjwZBE926xxRI Yvj/BQhsGqX0fLSrhcRYhFWjBg== X-Google-Smtp-Source: ABdhPJxhiKO2Cr8rVY6Z7xoEe3aLmQOf+fpslbIVDg4hxcAF04VZVj+2cCeAb+WNtpL5juwTIyioDA== X-Received: by 2002:a17:907:7baa:b0:6fe:b3dc:2378 with SMTP id ne42-20020a1709077baa00b006feb3dc2378mr49731224ejc.266.1654069491828; Wed, 01 Jun 2022 00:44:51 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id fi20-20020a1709073ad400b006fec8e8eff6sm377188ejc.176.2022.06.01.00.44.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 00:44:51 -0700 (PDT) Message-ID: Date: Wed, 1 Jun 2022 09:44:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 4/5] dt-bindings: crypto: add documentation for aspeed hace Content-Language: en-US To: Neal Liu , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Johnny Huang Cc: linux-aspeed@lists.ozlabs.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220601054204.1522976-1-neal_liu@aspeedtech.com> <20220601054204.1522976-5-neal_liu@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20220601054204.1522976-5-neal_liu@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_004453_388413_8EA53E5E X-CRM114-Status: GOOD ( 19.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/06/2022 07:42, Neal Liu wrote: > Add device tree binding documentation for the Aspeed Hash > and Crypto Engines (HACE) Controller. > > Signed-off-by: Neal Liu > Signed-off-by: Johnny Huang > --- > .../bindings/crypto/aspeed,hace.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/aspeed,hace.yaml > > diff --git a/Documentation/devicetree/bindings/crypto/aspeed,hace.yaml b/Documentation/devicetree/bindings/crypto/aspeed,hace.yaml > new file mode 100644 > index 000000000000..36b4ad0dc7fa > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/aspeed,hace.yaml Filename should be rather from the first compatible, so "aspeed,ast2500-hace.yaml" > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/crypto/aspeed,hace.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ASPEED HACE hash and crypto Hardware Accelerator Device Tree Bindings s/Device Tree Bindings// > + > +maintainers: > + - Neal Liu > + > +description: | > + The Hash and Crypto Engine (HACE) is designed to accelerate the throughput > + of hash data digest, encryption, and decryption. Basically, HACE can be > + divided into two independently engines - Hash Engine and Crypto Engine. > + > +properties: > + compatible: > + enum: > + - aspeed,ast2500-hace > + - aspeed,ast2600-hace > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + maxItems: 1 You need to list clock names, however usually it does not make sense to have names for just one main device clock. > + > + interrupts: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - resets > + > +additionalProperties: false > + > +examples: > + - | > + #include > + hace: hace@1e6d0000 { Generic node names so "crypto". > + compatible = "aspeed,ast2600-hace"; > + reg = <0x1e6d0000 0x200>; > + interrupts = <4>; > + clocks = <&syscon ASPEED_CLK_GATE_YCLK>; > + clock-names = "yclk"; > + resets = <&syscon ASPEED_RESET_HACE>; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel