* [PATCH 0/2] Add bootph-all property to necessary nodes to enable ethernet boot for AM68-SK, J722s and AM62p-SK
@ 2025-01-06 12:31 Chintan Vankar
2025-01-06 12:31 ` [PATCH 1/2] arm64: dts: ti: k3-am68-sk*: Add bootph-all property to necessary nodes to enable Ethernet boot Chintan Vankar
2025-01-06 12:31 ` [PATCH 2/2] arm64: dts: ti: k3-am62p5*/k3-j722s: " Chintan Vankar
0 siblings, 2 replies; 9+ messages in thread
From: Chintan Vankar @ 2025-01-06 12:31 UTC (permalink / raw)
To: Conor Dooley, Krzysztof Kozlowski, Rob Herring, Tero Kristo,
Vignesh Raghavendra, Nishanth Menon
Cc: srk, s-vadapalli, danishanwar, linux-kernel, devicetree,
linux-arm-kernel, Chintan Vankar
This series adds bootph-all property to necessary nodes to enable
ethernet boot support for AM68-SK, J722s and AM62p-SK.
This series is based on linux-next tagged next-20250106.
Chintan Vankar (2):
arm64: dts: ti: k3-am68-sk*: Add bootph-all property to necessary
nodes to enable Ethernet boot
arm64: dts: ti: k3-am62p5*/k3-j722s: Add bootph-all property to
necessary nodes to enable Ethernet boot
arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 +++
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 ++
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 5 +++++
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 ++
arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 3 +++
5 files changed, 15 insertions(+)
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] arm64: dts: ti: k3-am68-sk*: Add bootph-all property to necessary nodes to enable Ethernet boot
2025-01-06 12:31 [PATCH 0/2] Add bootph-all property to necessary nodes to enable ethernet boot for AM68-SK, J722s and AM62p-SK Chintan Vankar
@ 2025-01-06 12:31 ` Chintan Vankar
2025-01-07 13:59 ` Roger Quadros
2025-01-07 14:04 ` Roger Quadros
2025-01-06 12:31 ` [PATCH 2/2] arm64: dts: ti: k3-am62p5*/k3-j722s: " Chintan Vankar
1 sibling, 2 replies; 9+ messages in thread
From: Chintan Vankar @ 2025-01-06 12:31 UTC (permalink / raw)
To: Conor Dooley, Krzysztof Kozlowski, Rob Herring, Tero Kristo,
Vignesh Raghavendra, Nishanth Menon
Cc: srk, s-vadapalli, danishanwar, linux-kernel, devicetree,
linux-arm-kernel, Chintan Vankar
Ethernet boot requires CPSW nodes to be present starting from R5 SPL
stage. Add bootph-all property to necessary nodes for CPSW to enable those
nodes during SPL stage along with later boot stages for AM68-SK.
Signed-off-by: Chintan Vankar <c-vankar@ti.com>
---
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 5 +++++
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 ++
2 files changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
index 11522b36e0ce..f1f8b228926d 100644
--- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
@@ -333,6 +333,7 @@ J721S2_WKUP_IOPAD(0x008, PIN_OUTPUT, 0) /* (E22) MCU_RGMII1_TD3 */
J721S2_WKUP_IOPAD(0x018, PIN_OUTPUT, 0) /* (F21) MCU_RGMII1_TXC */
J721S2_WKUP_IOPAD(0x000, PIN_OUTPUT, 0) /* (F22) MCU_RGMII1_TX_CTL */
>;
+ bootph-all;
};
mcu_mdio_pins_default: mcu-mdio-default-pins {
@@ -340,6 +341,7 @@ mcu_mdio_pins_default: mcu-mdio-default-pins {
J721S2_WKUP_IOPAD(0x034, PIN_OUTPUT, 0) /* (A21) MCU_MDIO0_MDC */
J721S2_WKUP_IOPAD(0x030, PIN_INPUT, 0) /* (A22) MCU_MDIO0_MDIO */
>;
+ bootph-all;
};
mcu_mcan0_pins_default: mcu-mcan0-default-pins {
@@ -610,11 +612,13 @@ &main_sdhci1 {
&mcu_cpsw {
pinctrl-names = "default";
pinctrl-0 = <&mcu_cpsw_pins_default>, <&mcu_mdio_pins_default>;
+ bootph-all;
};
&davinci_mdio {
phy0: ethernet-phy@0 {
reg = <0>;
+ bootph-all;
ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
ti,min-output-impedance;
@@ -624,6 +628,7 @@ phy0: ethernet-phy@0 {
&cpsw_port1 {
phy-mode = "rgmii-rxid";
phy-handle = <&phy0>;
+ bootph-all;
};
&mcu_mcan0 {
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
index bc31266126d0..cfae226d3c63 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
@@ -154,12 +154,14 @@ mcu_conf: bus@40f00000 {
cpsw_mac_syscon: ethernet-mac-syscon@200 {
compatible = "ti,am62p-cpsw-mac-efuse", "syscon";
reg = <0x200 0x8>;
+ bootph-all;
};
phy_gmii_sel: phy@4040 {
compatible = "ti,am654-phy-gmii-sel";
reg = <0x4040 0x4>;
#phy-cells = <1>;
+ bootph-all;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm64: dts: ti: k3-am62p5*/k3-j722s: Add bootph-all property to necessary nodes to enable Ethernet boot
2025-01-06 12:31 [PATCH 0/2] Add bootph-all property to necessary nodes to enable ethernet boot for AM68-SK, J722s and AM62p-SK Chintan Vankar
2025-01-06 12:31 ` [PATCH 1/2] arm64: dts: ti: k3-am68-sk*: Add bootph-all property to necessary nodes to enable Ethernet boot Chintan Vankar
@ 2025-01-06 12:31 ` Chintan Vankar
2025-01-07 14:02 ` Roger Quadros
2025-01-09 16:24 ` Roger Quadros
1 sibling, 2 replies; 9+ messages in thread
From: Chintan Vankar @ 2025-01-06 12:31 UTC (permalink / raw)
To: Conor Dooley, Krzysztof Kozlowski, Rob Herring, Tero Kristo,
Vignesh Raghavendra, Nishanth Menon
Cc: srk, s-vadapalli, danishanwar, linux-kernel, devicetree,
linux-arm-kernel, Chintan Vankar
Ethernet boot requires CPSW nodes to be present starting from R5 SPL
stage. Add bootph-all property to necessary nodes for CPSW to enable those
nodes during SPL stage along with later boot stages for AM62p-SK and
J722s.
Signed-off-by: Chintan Vankar <c-vankar@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 +++
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 ++
arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 3 +++
3 files changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
index 6e3beb5c2e01..96ddc5c17991 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
@@ -50,6 +50,7 @@ phy_gmii_sel: phy@4044 {
compatible = "ti,am654-phy-gmii-sel";
reg = <0x4044 0x8>;
#phy-cells = <1>;
+ bootph-all;
};
epwm_tbclk: clock-controller@4130 {
@@ -714,6 +715,7 @@ ethernet-ports {
#size-cells = <0>;
cpsw_port1: port@1 {
+ bootph-all;
reg = <1>;
ti,mac-only;
label = "port1";
@@ -742,6 +744,7 @@ cpsw3g_mdio: mdio@f00 {
clock-names = "fck";
bus_freq = <1000000>;
status = "disabled";
+ bootph-all;
};
cpts@3d000 {
diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index ad71d2f27f53..28b08eb79da3 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -226,6 +226,7 @@ main_mdio1_pins_default: main-mdio1-default-pins {
AM62PX_IOPAD(0x0160, PIN_OUTPUT, 0) /* (F17) MDIO0_MDC */
AM62PX_IOPAD(0x015c, PIN_INPUT, 0) /* (F16) MDIO0_MDIO */
>;
+ bootph-all;
};
main_mmc1_pins_default: main-mmc1-default-pins {
@@ -495,6 +496,7 @@ &cpsw3g_mdio {
cpsw3g_phy0: ethernet-phy@0 {
reg = <0>;
+ bootph-all;
ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
ti,min-output-impedance;
diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
index 796287c76b69..1785c9848664 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
@@ -303,6 +303,7 @@ mdio_pins_default: mdio-default-pins {
J722S_IOPAD(0x0160, PIN_OUTPUT, 0) /* (AC24) MDIO0_MDC */
J722S_IOPAD(0x015c, PIN_INPUT, 0) /* (AD25) MDIO0_MDIO */
>;
+ bootph-all;
};
ospi0_pins_default: ospi0-default-pins {
@@ -337,6 +338,7 @@ J722S_IOPAD(0x0140, PIN_OUTPUT, 0) /* (AF24) RGMII1_TD3 */
J722S_IOPAD(0x0130, PIN_OUTPUT, 0) /* (AG26) RGMII1_TXC */
J722S_IOPAD(0x012c, PIN_OUTPUT, 0) /* (AF25) RGMII1_TX_CTL */
>;
+ bootph-all;
};
main_usb1_pins_default: main-usb1-default-pins {
@@ -374,6 +376,7 @@ &cpsw3g_mdio {
cpsw3g_phy0: ethernet-phy@0 {
reg = <0>;
+ bootph-all;
ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
ti,min-output-impedance;
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: k3-am68-sk*: Add bootph-all property to necessary nodes to enable Ethernet boot
2025-01-06 12:31 ` [PATCH 1/2] arm64: dts: ti: k3-am68-sk*: Add bootph-all property to necessary nodes to enable Ethernet boot Chintan Vankar
@ 2025-01-07 13:59 ` Roger Quadros
2025-01-07 14:04 ` Roger Quadros
1 sibling, 0 replies; 9+ messages in thread
From: Roger Quadros @ 2025-01-07 13:59 UTC (permalink / raw)
To: Chintan Vankar, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
Tero Kristo, Vignesh Raghavendra, Nishanth Menon
Cc: srk, s-vadapalli, danishanwar, linux-kernel, devicetree,
linux-arm-kernel
On 06/01/2025 14:31, Chintan Vankar wrote:
> Ethernet boot requires CPSW nodes to be present starting from R5 SPL
> stage. Add bootph-all property to necessary nodes for CPSW to enable those
> nodes during SPL stage along with later boot stages for AM68-SK.
>
> Signed-off-by: Chintan Vankar <c-vankar@ti.com>
Reviewed-by: Roger Quadros <rogerq@@kernel.org>
--
cheers,
-roger
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: ti: k3-am62p5*/k3-j722s: Add bootph-all property to necessary nodes to enable Ethernet boot
2025-01-06 12:31 ` [PATCH 2/2] arm64: dts: ti: k3-am62p5*/k3-j722s: " Chintan Vankar
@ 2025-01-07 14:02 ` Roger Quadros
2025-01-09 16:24 ` Roger Quadros
1 sibling, 0 replies; 9+ messages in thread
From: Roger Quadros @ 2025-01-07 14:02 UTC (permalink / raw)
To: Chintan Vankar, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
Tero Kristo, Vignesh Raghavendra, Nishanth Menon
Cc: srk, s-vadapalli, danishanwar, linux-kernel, devicetree,
linux-arm-kernel
On 06/01/2025 14:31, Chintan Vankar wrote:
> Ethernet boot requires CPSW nodes to be present starting from R5 SPL
> stage. Add bootph-all property to necessary nodes for CPSW to enable those
> nodes during SPL stage along with later boot stages for AM62p-SK and
> J722s.
>
> Signed-off-by: Chintan Vankar <c-vankar@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 +++
> arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 ++
> arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 3 +++
> 3 files changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> index 6e3beb5c2e01..96ddc5c17991 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> @@ -50,6 +50,7 @@ phy_gmii_sel: phy@4044 {
> compatible = "ti,am654-phy-gmii-sel";
> reg = <0x4044 0x8>;
> #phy-cells = <1>;
> + bootph-all;
Shouldn't bootph-all be the first property in the DT node?
> };
>
> epwm_tbclk: clock-controller@4130 {
> @@ -714,6 +715,7 @@ ethernet-ports {
> #size-cells = <0>;
>
> cpsw_port1: port@1 {
> + bootph-all;
> reg = <1>;
> ti,mac-only;
> label = "port1";
> @@ -742,6 +744,7 @@ cpsw3g_mdio: mdio@f00 {
> clock-names = "fck";
> bus_freq = <1000000>;
> status = "disabled";
> + bootph-all;
> };
>
> cpts@3d000 {
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> index ad71d2f27f53..28b08eb79da3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> @@ -226,6 +226,7 @@ main_mdio1_pins_default: main-mdio1-default-pins {
> AM62PX_IOPAD(0x0160, PIN_OUTPUT, 0) /* (F17) MDIO0_MDC */
> AM62PX_IOPAD(0x015c, PIN_INPUT, 0) /* (F16) MDIO0_MDIO */
> >;
> + bootph-all;
> };
>
> main_mmc1_pins_default: main-mmc1-default-pins {
> @@ -495,6 +496,7 @@ &cpsw3g_mdio {
>
> cpsw3g_phy0: ethernet-phy@0 {
> reg = <0>;
> + bootph-all;
> ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
> ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
> ti,min-output-impedance;
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> index 796287c76b69..1785c9848664 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> @@ -303,6 +303,7 @@ mdio_pins_default: mdio-default-pins {
> J722S_IOPAD(0x0160, PIN_OUTPUT, 0) /* (AC24) MDIO0_MDC */
> J722S_IOPAD(0x015c, PIN_INPUT, 0) /* (AD25) MDIO0_MDIO */
> >;
> + bootph-all;
> };
>
> ospi0_pins_default: ospi0-default-pins {
> @@ -337,6 +338,7 @@ J722S_IOPAD(0x0140, PIN_OUTPUT, 0) /* (AF24) RGMII1_TD3 */
> J722S_IOPAD(0x0130, PIN_OUTPUT, 0) /* (AG26) RGMII1_TXC */
> J722S_IOPAD(0x012c, PIN_OUTPUT, 0) /* (AF25) RGMII1_TX_CTL */
> >;
> + bootph-all;
> };
>
> main_usb1_pins_default: main-usb1-default-pins {
> @@ -374,6 +376,7 @@ &cpsw3g_mdio {
>
> cpsw3g_phy0: ethernet-phy@0 {
> reg = <0>;
> + bootph-all;
> ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
> ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
> ti,min-output-impedance;
--
cheers,
-roger
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: k3-am68-sk*: Add bootph-all property to necessary nodes to enable Ethernet boot
2025-01-06 12:31 ` [PATCH 1/2] arm64: dts: ti: k3-am68-sk*: Add bootph-all property to necessary nodes to enable Ethernet boot Chintan Vankar
2025-01-07 13:59 ` Roger Quadros
@ 2025-01-07 14:04 ` Roger Quadros
2025-01-09 7:01 ` Vankar, Chintan
1 sibling, 1 reply; 9+ messages in thread
From: Roger Quadros @ 2025-01-07 14:04 UTC (permalink / raw)
To: Chintan Vankar, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
Tero Kristo, Vignesh Raghavendra, Nishanth Menon
Cc: srk, s-vadapalli, danishanwar, linux-kernel, devicetree,
linux-arm-kernel
On 06/01/2025 14:31, Chintan Vankar wrote:
> Ethernet boot requires CPSW nodes to be present starting from R5 SPL
> stage. Add bootph-all property to necessary nodes for CPSW to enable those
> nodes during SPL stage along with later boot stages for AM68-SK.
>
> Signed-off-by: Chintan Vankar <c-vankar@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 5 +++++
> arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 ++
> 2 files changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> index 11522b36e0ce..f1f8b228926d 100644
> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> @@ -333,6 +333,7 @@ J721S2_WKUP_IOPAD(0x008, PIN_OUTPUT, 0) /* (E22) MCU_RGMII1_TD3 */
> J721S2_WKUP_IOPAD(0x018, PIN_OUTPUT, 0) /* (F21) MCU_RGMII1_TXC */
> J721S2_WKUP_IOPAD(0x000, PIN_OUTPUT, 0) /* (F22) MCU_RGMII1_TX_CTL */
> >;
> + bootph-all;
Shouldn't bootph-all be the first property in the DT nodes?
> };
>
> mcu_mdio_pins_default: mcu-mdio-default-pins {
> @@ -340,6 +341,7 @@ mcu_mdio_pins_default: mcu-mdio-default-pins {
> J721S2_WKUP_IOPAD(0x034, PIN_OUTPUT, 0) /* (A21) MCU_MDIO0_MDC */
> J721S2_WKUP_IOPAD(0x030, PIN_INPUT, 0) /* (A22) MCU_MDIO0_MDIO */
> >;
> + bootph-all;
> };
>
> mcu_mcan0_pins_default: mcu-mcan0-default-pins {
> @@ -610,11 +612,13 @@ &main_sdhci1 {
> &mcu_cpsw {
> pinctrl-names = "default";
> pinctrl-0 = <&mcu_cpsw_pins_default>, <&mcu_mdio_pins_default>;
> + bootph-all;
> };
>
> &davinci_mdio {
> phy0: ethernet-phy@0 {
> reg = <0>;
> + bootph-all;
> ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
> ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
> ti,min-output-impedance;
> @@ -624,6 +628,7 @@ phy0: ethernet-phy@0 {
> &cpsw_port1 {
> phy-mode = "rgmii-rxid";
> phy-handle = <&phy0>;
> + bootph-all;
> };
>
> &mcu_mcan0 {
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> index bc31266126d0..cfae226d3c63 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> @@ -154,12 +154,14 @@ mcu_conf: bus@40f00000 {
> cpsw_mac_syscon: ethernet-mac-syscon@200 {
> compatible = "ti,am62p-cpsw-mac-efuse", "syscon";
> reg = <0x200 0x8>;
> + bootph-all;
> };
>
> phy_gmii_sel: phy@4040 {
> compatible = "ti,am654-phy-gmii-sel";
> reg = <0x4040 0x4>;
> #phy-cells = <1>;
> + bootph-all;
> };
>
> };
--
cheers,
-roger
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: k3-am68-sk*: Add bootph-all property to necessary nodes to enable Ethernet boot
2025-01-07 14:04 ` Roger Quadros
@ 2025-01-09 7:01 ` Vankar, Chintan
2025-01-09 16:22 ` Roger Quadros
0 siblings, 1 reply; 9+ messages in thread
From: Vankar, Chintan @ 2025-01-09 7:01 UTC (permalink / raw)
To: Roger Quadros, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
Tero Kristo, Vignesh Raghavendra, Nishanth Menon
Cc: srk, s-vadapalli, danishanwar, linux-kernel, devicetree,
linux-arm-kernel
On 1/7/2025 7:34 PM, Roger Quadros wrote:
>
>
> On 06/01/2025 14:31, Chintan Vankar wrote:
>> Ethernet boot requires CPSW nodes to be present starting from R5 SPL
>> stage. Add bootph-all property to necessary nodes for CPSW to enable those
>> nodes during SPL stage along with later boot stages for AM68-SK.
>>
>> Signed-off-by: Chintan Vankar <c-vankar@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 5 +++++
>> arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 ++
>> 2 files changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>> index 11522b36e0ce..f1f8b228926d 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>> @@ -333,6 +333,7 @@ J721S2_WKUP_IOPAD(0x008, PIN_OUTPUT, 0) /* (E22) MCU_RGMII1_TD3 */
>> J721S2_WKUP_IOPAD(0x018, PIN_OUTPUT, 0) /* (F21) MCU_RGMII1_TXC */
>> J721S2_WKUP_IOPAD(0x000, PIN_OUTPUT, 0) /* (F22) MCU_RGMII1_TX_CTL */
>> >;
>> + bootph-all;
>
> Shouldn't bootph-all be the first property in the DT nodes?
Hello Roger, You are correct that we used to add 'bootph-all' property
as the first property in DT nodes, but after seeing this comment of
Vignesh at here:
https://lore.kernel.org/r/79bc9fe7-0a35-4f07-b34e-367a4b1e1755@ti.com/,
I have moved it to the end of all required property.
>
>> };
>>
>> mcu_mdio_pins_default: mcu-mdio-default-pins {
>> @@ -340,6 +341,7 @@ mcu_mdio_pins_default: mcu-mdio-default-pins {
>> J721S2_WKUP_IOPAD(0x034, PIN_OUTPUT, 0) /* (A21) MCU_MDIO0_MDC */
>> J721S2_WKUP_IOPAD(0x030, PIN_INPUT, 0) /* (A22) MCU_MDIO0_MDIO */
>> >;
>> + bootph-all;
>> };
>>
>> mcu_mcan0_pins_default: mcu-mcan0-default-pins {
>> @@ -610,11 +612,13 @@ &main_sdhci1 {
>> &mcu_cpsw {
>> pinctrl-names = "default";
>> pinctrl-0 = <&mcu_cpsw_pins_default>, <&mcu_mdio_pins_default>;
>> + bootph-all;
>> };
>>
>> &davinci_mdio {
>> phy0: ethernet-phy@0 {
>> reg = <0>;
>> + bootph-all;
>> ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
>> ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
>> ti,min-output-impedance;
>> @@ -624,6 +628,7 @@ phy0: ethernet-phy@0 {
>> &cpsw_port1 {
>> phy-mode = "rgmii-rxid";
>> phy-handle = <&phy0>;
>> + bootph-all;
>> };
>>
>> &mcu_mcan0 {
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
>> index bc31266126d0..cfae226d3c63 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
>> @@ -154,12 +154,14 @@ mcu_conf: bus@40f00000 {
>> cpsw_mac_syscon: ethernet-mac-syscon@200 {
>> compatible = "ti,am62p-cpsw-mac-efuse", "syscon";
>> reg = <0x200 0x8>;
>> + bootph-all;
>> };
>>
>> phy_gmii_sel: phy@4040 {
>> compatible = "ti,am654-phy-gmii-sel";
>> reg = <0x4040 0x4>;
>> #phy-cells = <1>;
>> + bootph-all;
>> };
>>
>> };
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: k3-am68-sk*: Add bootph-all property to necessary nodes to enable Ethernet boot
2025-01-09 7:01 ` Vankar, Chintan
@ 2025-01-09 16:22 ` Roger Quadros
0 siblings, 0 replies; 9+ messages in thread
From: Roger Quadros @ 2025-01-09 16:22 UTC (permalink / raw)
To: Vankar, Chintan, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
Tero Kristo, Vignesh Raghavendra, Nishanth Menon
Cc: srk, s-vadapalli, danishanwar, linux-kernel, devicetree,
linux-arm-kernel
On 09/01/2025 09:01, Vankar, Chintan wrote:
>
>
> On 1/7/2025 7:34 PM, Roger Quadros wrote:
>>
>>
>> On 06/01/2025 14:31, Chintan Vankar wrote:
>>> Ethernet boot requires CPSW nodes to be present starting from R5 SPL
>>> stage. Add bootph-all property to necessary nodes for CPSW to enable those
>>> nodes during SPL stage along with later boot stages for AM68-SK.
>>>
>>> Signed-off-by: Chintan Vankar <c-vankar@ti.com>
>>> ---
>>> arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 5 +++++
>>> arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 ++
>>> 2 files changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>>> index 11522b36e0ce..f1f8b228926d 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>>> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>>> @@ -333,6 +333,7 @@ J721S2_WKUP_IOPAD(0x008, PIN_OUTPUT, 0) /* (E22) MCU_RGMII1_TD3 */
>>> J721S2_WKUP_IOPAD(0x018, PIN_OUTPUT, 0) /* (F21) MCU_RGMII1_TXC */
>>> J721S2_WKUP_IOPAD(0x000, PIN_OUTPUT, 0) /* (F22) MCU_RGMII1_TX_CTL */
>>> >;
>>> + bootph-all;
>>
>> Shouldn't bootph-all be the first property in the DT nodes?
>
> Hello Roger, You are correct that we used to add 'bootph-all' property
> as the first property in DT nodes, but after seeing this comment of
> Vignesh at here:
> https://lore.kernel.org/r/79bc9fe7-0a35-4f07-b34e-367a4b1e1755@ti.com/,
> I have moved it to the end of all required property.
OK. Thanks for the clarification.
>
>>
>>> };
>>> mcu_mdio_pins_default: mcu-mdio-default-pins {
>>> @@ -340,6 +341,7 @@ mcu_mdio_pins_default: mcu-mdio-default-pins {
>>> J721S2_WKUP_IOPAD(0x034, PIN_OUTPUT, 0) /* (A21) MCU_MDIO0_MDC */
>>> J721S2_WKUP_IOPAD(0x030, PIN_INPUT, 0) /* (A22) MCU_MDIO0_MDIO */
>>> >;
>>> + bootph-all;
>>> };
>>> mcu_mcan0_pins_default: mcu-mcan0-default-pins {
>>> @@ -610,11 +612,13 @@ &main_sdhci1 {
>>> &mcu_cpsw {
>>> pinctrl-names = "default";
>>> pinctrl-0 = <&mcu_cpsw_pins_default>, <&mcu_mdio_pins_default>;
>>> + bootph-all;
>>> };
>>> &davinci_mdio {
>>> phy0: ethernet-phy@0 {
>>> reg = <0>;
>>> + bootph-all;
>>> ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
>>> ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
>>> ti,min-output-impedance;
>>> @@ -624,6 +628,7 @@ phy0: ethernet-phy@0 {
>>> &cpsw_port1 {
>>> phy-mode = "rgmii-rxid";
>>> phy-handle = <&phy0>;
>>> + bootph-all;
>>> };
>>> &mcu_mcan0 {
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
>>> index bc31266126d0..cfae226d3c63 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
>>> @@ -154,12 +154,14 @@ mcu_conf: bus@40f00000 {
>>> cpsw_mac_syscon: ethernet-mac-syscon@200 {
>>> compatible = "ti,am62p-cpsw-mac-efuse", "syscon";
>>> reg = <0x200 0x8>;
>>> + bootph-all;
>>> };
>>> phy_gmii_sel: phy@4040 {
>>> compatible = "ti,am654-phy-gmii-sel";
>>> reg = <0x4040 0x4>;
>>> #phy-cells = <1>;
>>> + bootph-all;
>>> };
>>> };
>>
--
cheers,
-roger
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: ti: k3-am62p5*/k3-j722s: Add bootph-all property to necessary nodes to enable Ethernet boot
2025-01-06 12:31 ` [PATCH 2/2] arm64: dts: ti: k3-am62p5*/k3-j722s: " Chintan Vankar
2025-01-07 14:02 ` Roger Quadros
@ 2025-01-09 16:24 ` Roger Quadros
1 sibling, 0 replies; 9+ messages in thread
From: Roger Quadros @ 2025-01-09 16:24 UTC (permalink / raw)
To: Chintan Vankar, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
Tero Kristo, Vignesh Raghavendra, Nishanth Menon
Cc: srk, s-vadapalli, danishanwar, linux-kernel, devicetree,
linux-arm-kernel
On 06/01/2025 14:31, Chintan Vankar wrote:
> Ethernet boot requires CPSW nodes to be present starting from R5 SPL
> stage. Add bootph-all property to necessary nodes for CPSW to enable those
> nodes during SPL stage along with later boot stages for AM62p-SK and
> J722s.
>
> Signed-off-by: Chintan Vankar <c-vankar@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-01-09 17:37 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-06 12:31 [PATCH 0/2] Add bootph-all property to necessary nodes to enable ethernet boot for AM68-SK, J722s and AM62p-SK Chintan Vankar
2025-01-06 12:31 ` [PATCH 1/2] arm64: dts: ti: k3-am68-sk*: Add bootph-all property to necessary nodes to enable Ethernet boot Chintan Vankar
2025-01-07 13:59 ` Roger Quadros
2025-01-07 14:04 ` Roger Quadros
2025-01-09 7:01 ` Vankar, Chintan
2025-01-09 16:22 ` Roger Quadros
2025-01-06 12:31 ` [PATCH 2/2] arm64: dts: ti: k3-am62p5*/k3-j722s: " Chintan Vankar
2025-01-07 14:02 ` Roger Quadros
2025-01-09 16:24 ` Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).