From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5995EB64DC for ; Fri, 14 Jul 2023 19:35:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mIgVgHYzW3PI4mCGbQFEvPRwHyleL9cj+W3XsLbbwcs=; b=Ag6JrBfy1hnMps 6y+k0jmubWLA+uezNvSC+iqTFEqZK+7GF2nv/PRxNits0NuD9+H8f0Bl9PWAT4dMz31JV3AVknllB OsQELJspG32Bb7IHygSOp5/uFWe/R08T9NiUsrxxnVSG6kQ9Fvb6+nM9zDkDdGl53T6DXL8OugTVy lRHGH0kzgSoHrHcDp4aYtRvLQUb5nNLK68XL4SFWdeHW7bmnyDVT0rhOJACgHJ9ohiErABCHx/EE0 L0VU7FcvZr9zhRPGTYzCz54sA083MXfmd3qBXfksrdxZrzFQTOM0nEJ5ZwQF+jk3i71hNO6LhsRqy KQN2z/Tb50rLwBmrYdbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qKOZF-0076Cm-28; Fri, 14 Jul 2023 19:35:05 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qKOZA-0076BM-1f; Fri, 14 Jul 2023 19:35:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5D0F361DAF; Fri, 14 Jul 2023 19:34:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A64C0C433C7; Fri, 14 Jul 2023 19:34:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689363298; bh=coJii5owjJT4psrykdkd2QZrVS8+72vCzDQtZKFwADs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Qs69AsxFTwxe7qQ9dAN1lLk532XZRcYbAlVYzjJD+j6L1k2cgP+nY21n8aKZ/xTqS yIrUprT1gUdZd5+myyllx4fx2LY801n9XsQj9jB0Xv4vn8U95LkUyBsE6DQWUrtcaE cfWcbUB5eykdGbpqw4cHUdzJkS423d39ApYdkQM2geD7Cl1DiHsuJmQNe5wuUVJIHF ch+4A8vSG8vDxjMHCWdQ6oUXXQU5MBV0YIJS2gmEazA5YA3Y9sECSsM9D/DQ9+UYVp V2VJbU8B0GRWLR4kA9/sBvV9Vu1sSV0YAreNqw0cWVX2eephIXifBN2sFYL8qEMnfH sV5wF6scpfxDA== Message-ID: Date: Fri, 14 Jul 2023 14:34:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] firmware: Explicitly include correct DT includes Content-Language: en-US To: Rob Herring , Sudeep Holla , Cristian Marussi , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Matthias Brugger , AngeloGioacchino Del Regno , Florian Fainelli , Broadcom internal kernel review list , Thierry Reding , Jonathan Hunter , Michal Simek Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org References: <20230714174438.4054854-1-robh@kernel.org> From: Dinh Nguyen In-Reply-To: <20230714174438.4054854-1-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230714_123500_622089_52D3D04A X-CRM114-Status: GOOD ( 11.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/14/23 12:44, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > --- > drivers/firmware/arm_scmi/driver.c | 4 ++-- > drivers/firmware/imx/imx-dsp.c | 1 - > drivers/firmware/imx/imx-scu-irq.c | 1 + > drivers/firmware/imx/imx-scu.c | 1 + > drivers/firmware/mtk-adsp-ipc.c | 1 - > drivers/firmware/raspberrypi.c | 1 + > drivers/firmware/scpi_pm_domain.c | 3 ++- > drivers/firmware/stratix10-rsu.c | 1 - For stratix10-rsu.c, Acked-by: Dinh Nguyen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel