From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7B5C33CAF for ; Thu, 23 Jan 2020 15:05:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F61D21734 for ; Thu, 23 Jan 2020 15:05:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eUBGKcsY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="CURSxL7V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F61D21734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lmTY7BAyn3xw3z+lbw3pYjymqjhizwuFcQB0+Pj/c5s=; b=eUBGKcsYJ5vl24aODmnWHSR1i tYJO9rkW/RD/EWVfAqwkejl5jVINjpr1A5fmKXvVPZsU2X1Wi9nvYPETKQGyB1sv/Sk3mBK+Ky6WO aXRB1RcrXIifTs1FxLO3/2IMwl5rDjy60mlaG/SdthQIf6p+zQFLrrRznozfBUyQjlZTnkLo595s0 rt0aKnlxdQSku1eldF9Smha9a5i0vK77yNI2kiPuvS/eNHvzTzLV68LitA655aToxTUdfpW2VbDvV UH7eYytwnoTkxGUIFHKhhMUE7CmP0yqnwR11Nm0xygMEQRXc2q9M37yZurW7KiEpBvAxtZQ0FxgGs 7aF/Tc1zA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iue2X-0006ME-1r; Thu, 23 Jan 2020 15:05:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iue2U-0006Lf-8g for linux-arm-kernel@lists.infradead.org; Thu, 23 Jan 2020 15:04:59 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 474BC21734; Thu, 23 Jan 2020 15:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579791897; bh=cXKhlQW0taEdIQmJmGtJTvN9ODAXdbf+/jNFdwXkHVo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CURSxL7VvAIhvb00aI5FFq0XAY7fHU9MNQadVpFZ9MNgZ7Pb6DbUl6VuNeV+9q0Ig dsV9Z9zvvszjpRyBBFr73dafMivcyvI0pRJgvg7fVS86K9BVem7gn5U4aaed/AoHTj 1fCy3HC63+X5mZtP29YkLHEQBCTIKwQwUbX5PnXQ= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iue2R-000yOm-I0; Thu, 23 Jan 2020 15:04:55 +0000 MIME-Version: 1.0 Date: Thu, 23 Jan 2020 15:04:55 +0000 From: Marc Zyngier To: Sudeep Holla Subject: Re: [PATCH] arm64: dts: fast models: Fix FVP PCI interrupt-map property In-Reply-To: <20200123150104.GA37953@bogus> References: <20200123145112.22170-1-maz@kernel.org> <20200123150104.GA37953@bogus> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.8 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: sudeep.holla@arm.com, liviu.dudau@arm.com, lorenzo.pieralisi@arm.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200123_070458_330670_9AC1808B X-CRM114-Status: GOOD ( 10.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Liviu Dudau , linux-arm-kernel@lists.infradead.org, Rob Herring Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-01-23 15:01, Sudeep Holla wrote: > On Thu, Jan 23, 2020 at 02:51:12PM +0000, Marc Zyngier wrote: >> The interrupt map for the FVP's PCI node is missing the >> parent-unit-address cells for each of the INTx entries, leading to the >> kernel code failing to parse the entries correctly. >> >> Add the missing zero cells, which are pretty useless as far as the GIC >> is concerned, but that the spec requires. This allows INTx to be >> usable >> on the model, and VFIO to work correctly. >> > > I assume we need, > > Fixes: fa083b99eb28 ("arm64: dts: fast models: Add DTS fo Base RevC > FVP") > > Please shout if that's not necessary. Yes, you're absolutely right (I'm not shouting! ;-). M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel