From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79EDCC4332F for ; Thu, 17 Nov 2022 18:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bth6AEzpGHoTj5gyXao0Ub34lnhEdBU2eSAnIWFqpys=; b=artt5lustM3uWN usGnm5S6iQAkTThjGpmPuKEEABuxj4nc2NXz3N5cNl3q9DWml80yaoXSSYdwgb7ff1s/k/Xs3/lxl F6gJ5NTMsUePoDbCsjMWiGq5PdEHfan+krzTNzDrWe3+JMPjd5iyCm7MSkWK6DtNQjXRZ6H65Arzw LZNgi4R47JfJMrgSoZ7Fb+KO6fsOcyqbYPQp0Zgauqg/JLKvW8DWmy4rY5j2NvSOiKXFbvwyzORox z2LrX7IDKBBL3WsHRq3m1/yrO1BNyti2ha1sviHrwwkCF3odVjvNvu0LW5evAwlSUsTxJfFYNKPqx 8iaXvEQelWPk4/GKqQcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovjMh-00Ge8Q-Ah; Thu, 17 Nov 2022 18:11:55 +0000 Received: from mout.kundenserver.de ([217.72.192.73]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovjMd-00Ge4e-Fs; Thu, 17 Nov 2022 18:11:53 +0000 Received: from [192.168.1.139] ([37.4.248.43]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MRBac-1oYYAc40d2-00N9JG; Thu, 17 Nov 2022 19:11:43 +0100 Message-ID: Date: Thu, 17 Nov 2022 19:11:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 0/3] vc04_services: Promote bool usage To: Dave Stevenson Cc: kieran.bingham@ideasonboard.com, Mauro Carvalho Chehab , Hans Verkuil , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Umang Jain , Ray Jui , Broadcom internal kernel review list , Dan Carpenter , Florian Fainelli , Greg Kroah-Hartman , linux-staging@lists.linux.dev References: <20221117160015.344528-1-umang.jain@ideasonboard.com> Content-Language: en-US From: Stefan Wahren In-Reply-To: <20221117160015.344528-1-umang.jain@ideasonboard.com> X-Provags-ID: V03:K1:v+yHu1Uvt3QU9GBLdXtKiy5Gtp6DZtAd5x9kAsCbgZddr7sCpwW YgpqInjBN5e7Jg8gHXUNNDDAojqouRTvvRR8Ou1F8zfpf9QSp368awubWM2F1sxb1D7o+lG KxOXQVJ94H0QY73UzYeYAmRJT+dxCn4GJr0UpXWw+u0vxTZt6K9YRpP/Ek91socwXkNlwl1 mc2rBrqoCUX1Kjzbkrk8A== X-UI-Out-Filterresults: notjunk:1;V03:K0:a6bVZyG4qA4=:opF8oSfOlQzjzSn4Hu6PHv 4Em422zZnieWf38nqpC/9aAx/pHP1bKBGdDzbol1N8MdSh2tC575lzg9qP5saCOqlzYg4giBL EWBlcPOf5LiyCb5NO4V7nTQJunaOaU2gh4TGdlaeO7dUfT2dIHbvfjuZjEirZUhx6O3GfqhG/ 8FgM9y2T4pABvhWUM9s2N24S8kKFj8IjrALdzwF5vxcbVjg/yYDwHhmXE0IMXB4ibmxscNb/j 3NoV2WB6aXdG0ksBdYlBj3MXpaGWyuf2DltNeb92II4lqBtvBKyKTYZ4embUWDomwb7kDIsjr 31x82j6HDb9Sxspv2XsoH13Qfbv21jMFA8Txe8DxQ4efPPHqsm1GtWuAnPo7CIjrw8hySz9x/ EcBlCl1/qs3xCveCZbPIb7wRwqsoYupAzMk2rxa1d/nVNuQMnzmj2wlFNeJi70m5to41HN0NS WVKSBBFgmgMwkwhdMvC4k8kXo9Nxw7I5448MVXbYFTxV0UQhYcZp3ygszkNFg013+Ir4xnxZ2 6k5FzNhzyyANaOySr/T41QcwTvDmvZ5CC88i7AK4POqdTCOU+GIWLiftFIr6oxFTnDsE8Rxgh O33cnw+AlON1dPVr9IVeJH0CbFCZzcwqWJcXWGUAmRcjctF0GdrLzwkdw6SZV0K2WsDUaou6h RYtXCbXKCJ31wBH6HFfMdOO42Vnzw6Pli6jHnKnPLC7nsCaZNohMpqYVUBYNZW16hIIT0VEOv mHPEUE8LDFd6q1XLw17uJGG0dX8GkO2ZPDy+16kV+KJraRd46aTtIF+8ECC4jXoQdpahwaGW0 k+U85BQ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_101151_860583_C17C0EA0 X-CRM114-Status: GOOD ( 12.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dave, Am 17.11.22 um 17:00 schrieb Umang Jain: > In commit 7967656ffbfa ("coding-style: Clarify the expectations around > bool") the check to dis-allow bool structure members was removed from > checkpatch.pl. It promotes bool structure members to store boolean > values. This enhances code readability. > > Umang Jain (3): > Revert "staging: mmal-vchiq: Avoid use of bool in structures" > vc04_services: mmal-vchiq: Use bool for vchiq_mmal_component.in_use > vc04_services: bcm2835-camera: Use bool values for > mmal_fmt.remove_padding > > .../bcm2835-camera/bcm2835-camera.c | 30 +++++++++---------- > .../vc04_services/vchiq-mmal/mmal-vchiq.c | 18 +++++------ > .../vc04_services/vchiq-mmal/mmal-vchiq.h | 6 ++-- could you please check these changes to be safe? I'm not sure that the affected declarations are really internal. I'm afraid this might affect firmware or userspace. > 3 files changed, 27 insertions(+), 27 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel